[PATCH v3] btrfs: fix check_shared for fiemap ioctl

2016-06-07 Thread Lu Fengqi
Only in the case of different root_id or different object_id, check_shared identified extent as the shared. However, If a extent was referred by different offset of same file, it should also be identified as shared. In addition, check_shared's loop scale is at least n^3, so if a extent has too

[PATCH] btrfs: account for non-CoW'd blocks in btrfs_abort_transaction

2016-06-07 Thread Jeff Mahoney
The test for !trans->blocks_used in btrfs_abort_transaction is insufficient to determine whether it's safe to drop the transaction handle on the floor. btrfs_cow_block, informed by should_cow_block, can return blocks that have already been CoW'd in the current transaction. trans->blocks_used is

Re: [PATCH RFC] btrfs: Slightly speedup btrfs_read_block_groups

2016-06-07 Thread Qu Wenruo
Ping? Thanks, Qu At 05/23/2016 04:02 PM, Qu Wenruo wrote: Any comment on this patch? BTW, for anyone who is interested in the speedup, and the trace result, I've updated it to google driver: https://drive.google.com/open?id=0BxpkL3ehzX3pbFEybXd3X3MzRGM

Re: btrfs: fix check_shared for fiemap ioctl

2016-06-07 Thread Lu Fengqi
At 06/08/2016 01:18 AM, Dan Carpenter wrote: Hello Lu Fengqi, The patch ac8332f0c3ac: "btrfs: fix check_shared for fiemap ioctl" from Jun 1, 2016, leads to the following static checker warning: fs/btrfs/backref.c:277 ref_tree_add() error: dereferencing freed memory 'node'

re: btrfs: fix check_shared for fiemap ioctl

2016-06-07 Thread Dan Carpenter
Hello Lu Fengqi, The patch ac8332f0c3ac: "btrfs: fix check_shared for fiemap ioctl" from Jun 1, 2016, leads to the following static checker warning: fs/btrfs/backref.c:277 ref_tree_add() error: dereferencing freed memory 'node' fs/btrfs/backref.c 271 origin_count =

Re: [PATCH v10 09/21] btrfs: dedupe: Inband in-memory only de-duplication implement

2016-06-07 Thread Mark Fasheh
On Tue, Jun 07, 2016 at 08:42:46AM +0800, Qu Wenruo wrote: > > > At 06/07/2016 03:54 AM, Mark Fasheh wrote: > >On Sat, Jun 04, 2016 at 06:26:39PM +0800, Qu Wenruo wrote: > >> > >> > >>On 06/03/2016 10:27 PM, Josef Bacik wrote: > >>>On 06/01/2016 09:12 PM, Qu Wenruo wrote: > > > At

Re: [Bug] Kernel 4.6.1 errors

2016-06-07 Thread Holger Hoffstätte
On Tue, 07 Jun 2016 17:54:26 +0200, g6094199 wrote: > he guys! > > I´m running Debian Sid where i have found several kernel errors today > and most of them are btrfs related. > > uname -a > Linux NAS 4.6.0-trunk-amd64 #1 SMP Debian 4.6-1~exp1 (2016-05-17) x86_64 > GNU/Linux This is

[Bug] Kernel 4.6.1 errors

2016-06-07 Thread g6094199
he guys! I´m running Debian Sid where i have found several kernel errors today and most of them are btrfs related. uname -a Linux NAS 4.6.0-trunk-amd64 #1 SMP Debian 4.6-1~exp1 (2016-05-17) x86_64 GNU/Linux Inside are 2 disks as Raid0, another disk as single and the system disk also as

Re: btrfs device delete /dev/sdc1 /mnt/raid1 user experience

2016-06-07 Thread Chris Murphy
On Mon, Jun 6, 2016 at 10:02 PM, Kai Hendry wrote: > Sorry I unsubscribed from linux-btrfs@vger.kernel.org since the traffic > was a bit too high for me. > > On Tue, 7 Jun 2016, at 11:42 AM, Chris Murphy wrote: >> Your command turned this from a 3 drive volume into a 2 drive

Re: btrfs device delete /dev/sdc1 /mnt/raid1 user experience

2016-06-07 Thread Austin S. Hemmelgarn
On 2016-06-07 09:52, Kai Hendry wrote: On Tue, 7 Jun 2016, at 07:10 PM, Austin S. Hemmelgarn wrote: Yes, although you would then need to be certain to run a balance with -dconvert=raid1 -mconvert=raid1 to clean up anything that got allocated before the new disk was added. I don't quite

Re: btrfs device delete /dev/sdc1 /mnt/raid1 user experience

2016-06-07 Thread Kai Hendry
On Tue, 7 Jun 2016, at 07:10 PM, Austin S. Hemmelgarn wrote: > Yes, although you would then need to be certain to run a balance with > -dconvert=raid1 -mconvert=raid1 to clean up anything that got allocated > before the new disk was added. I don't quite understand when I should run this

Re: btrfs device delete /dev/sdc1 /mnt/raid1 user experience

2016-06-07 Thread Austin S. Hemmelgarn
On 2016-06-07 00:02, Kai Hendry wrote: Sorry I unsubscribed from linux-btrfs@vger.kernel.org since the traffic was a bit too high for me. Entirely understandable, although for what it's worth it's nowhere near as busy as some other mailing lists (linux-ker...@vger.kernel.org for example sees