Re: [PATCH 3/3] btrfs-progs: Add command to check if balance op is req

2016-10-28 Thread Graham Cobb
On 28/10/16 16:20, David Sterba wrote: > I tend to agree with this approach. The usecase, with some random sample > balance options: > > $ btrfs balance start --analyze -dusage=10 -musage=5 /path Wouldn't a "balance analyze" command be better than "balance start --analyze"? I would have guessed

Re: [PATCH] btrfs-progs: repair: Trickle down EEXISTS while freeing

2016-10-28 Thread David Sterba
On Fri, Oct 28, 2016 at 10:02:06AM -0500, Goldwyn Rodrigues wrote: > > > On 10/28/2016 09:42 AM, David Sterba wrote: > > On Thu, Oct 27, 2016 at 01:05:08PM -0500, Goldwyn Rodrigues wrote: > >> While deleting pending extents, we insert extents to the > >> extent_tree. However, because of

Re: [PATCH 2/3] btrfs-progs: Add a command to show bg info

2016-10-28 Thread David Sterba
On Mon, Oct 17, 2016 at 05:35:14PM -0700, Divya Indi wrote: > Add a new subcommand to btrfs inspect-internal > > btrfs inspect-internal bg_analysis > Gives information about all the block groups. The sample output from the cover letter should also go here (or just here). Below are some

Re: [PATCH 1/3] btrfs-progs: Generic functions to retrieve chunks and their bg info

2016-10-28 Thread David Sterba
On Mon, Oct 17, 2016 at 05:35:13PM -0700, Divya Indi wrote: > An efficient alternative to retrieving block groups: > get_chunks(): Walk the chunk tree to retrieve the chunks. > get_bg_info(): For each retrieved chunk, lookup an exact match of block > group in the extent tree. > > Signed-off-by:

Re: Compression and device replace on raid10 kernel panic on 4.4.6 and 4.6.x

2016-10-28 Thread Lionel Bouton
Hi, as I don't have much time to handle a long backup recovery, I didn't try the delete/add combination to avoid any risk. What I tried though, was fatal_errors=bug. As I don't have any console I thought it might at least help log the problem instead of the usual kernel panic. No luck : the

Re: [PATCH 3/3] btrfs-progs: Add command to check if balance op is req

2016-10-28 Thread David Sterba
On Wed, Oct 19, 2016 at 10:08:23AM -0700, Divya Indi wrote: > On 10/17/2016 06:42 PM, Qu Wenruo wrote: > > At 10/18/2016 08:35 AM, Divya Indi wrote: > >> Add new subcommand to btrfs inspect-internal > >> > >> btrfs inspect-internal balance_check > >> Checks whether 'btrfs balance' can help

Re: [PATCH v2 3/6] Btrfs: incremental send, add generation for waiting_dir_move struct and check it in can_rmdir.

2016-10-28 Thread Filipe Manana
On Fri, Oct 28, 2016 at 2:40 AM, robbieko wrote: > From: Robbie Ko > > Example scenario: > Parent snapshot: > | dir258/ (ino 258, gen 27) > | dir257/ (ino 257, gen 27) > | dir259/ (ino 259, gen 27) > > Send snapshot: > |

Re: [PATCH 2/3] btrfs-progs: send: fix handling of multiple snapshots (-p option)

2016-10-28 Thread David Sterba
On Wed, Oct 19, 2016 at 11:35:03AM +0900, Tsutomu Itoh wrote: > We cannot send multiple snapshots at once by -p option. We cannot like that it's broken, or we cannot because it's not supposed to work that way. I guess it's the former, but the changelog text is a bit confusing. > > [before] > #

Re: [PATCH 0/4] Qgroup comment enhance and balance fix

2016-10-28 Thread Goldwyn Rodrigues
On 10/27/2016 07:33 PM, Qu Wenruo wrote: > Any comment? > > Especially the final patch will fix a long standing bug. > While I have tested it, and it works, I did not get time to review it. So, you can have my Tested-by: Goldwyn Rodrigues > Thanks, > Qu > > At

[PATCH] Btrfs: remove balance warning that does not reflect any problem

2016-10-28 Thread fdmanana
From: Filipe Manana On openSUSE/SLE systems where balance is triggered periodically in the background, snapshotting happens when doing package installations and upgrades, and (by default) the root system is organized with multiple subvolumes, the following warning was

Re: [PATCH] btrfs-progs: repair: Trickle down EEXISTS while freeing

2016-10-28 Thread Goldwyn Rodrigues
On 10/28/2016 09:42 AM, David Sterba wrote: > On Thu, Oct 27, 2016 at 01:05:08PM -0500, Goldwyn Rodrigues wrote: >> While deleting pending extents, we insert extents to the >> extent_tree. However, because of corruption, this might already >> be freed. We trickle the EEXISTS error and let the

Re: [PATCH] btrfs-progs: repair: Trickle down EEXISTS while freeing

2016-10-28 Thread David Sterba
On Thu, Oct 27, 2016 at 01:05:08PM -0500, Goldwyn Rodrigues wrote: > While deleting pending extents, we insert extents to the > extent_tree. However, because of corruption, this might already > be freed. We trickle the EEXISTS error and let the caller > decide what needs to be done with it. In

Re: [PATCH] btrfs: don't abuse REQ_OP_* flags for btrfs_map_block

2016-10-28 Thread David Sterba
On Thu, Oct 27, 2016 at 09:27:36AM +0200, Christoph Hellwig wrote: > btrfs_map_block supports different types of mappings, which to a large > extent resemble block layer operations. But they don't always do, and > currently btrfs dangerously overlays it's own flag over the block layer > flags.

Re: [PATCH] btrfs-progs: Ignore clang complete file

2016-10-28 Thread David Sterba
On Thu, Oct 27, 2016 at 10:32:48AM +0800, Qu Wenruo wrote: > While most guys are using ctags and cscope with vim, new completion tool > like vim-clang_completion is gaining its popularity, due to its compiler > level accuracy simpleness to use. > > Since ctags and cscope are already in

[GIT PULL] Btrfs

2016-10-28 Thread Chris Mason
Hi Linus, My for-linus-4.9 has two fixes in it: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus-4.9 My patch fixes the btrfs list_head abuse that we tracked down during Dave Jones' memory corruption investigation. With both Jens and my patches in place, I'm no

Re: [PATCH] btrfs-progs: fix build for programs including ioctl.h

2016-10-28 Thread Eric Sandeen
On 10/27/16 9:54 PM, Eric Sandeen wrote: > On 10/13/16 12:36 PM, Eric Sandeen wrote: >> This was reported when docker failed to build against >> btrfs-progs v4.8.1. >> >> It includes ioctl.h which now calls BUILD_ASSERT(), which >> is defined in kerncompat.h, which was not included in the >>

Re: mount error raid6

2016-10-28 Thread Jan Koester
On Sonntag, 25. September 2016 11:25:40 CEST you wrote: > Hi, > > i got some errors in dmesg if i want to mount my Filesystem, > > uname -a: > Linux dibsi 4.8.0-040800rc7-generic #201609182130 SMP Mon Sep 19 01:32:13 > UTC 2016 x86_64 x86_64 x86_64 GNU/Linux > > dmesg: > [ 71.599464] BTRFS

Re: It takes me up to 20 reboots for the system to start sda

2016-10-28 Thread Kai Krakow
Am Fri, 28 Oct 2016 02:21:27 -0600 schrieb Bearcat Şándor : > Thanks for the suggestions Kai. I'm using dracut 044. > > I tried using the rootdelay=2 kernel parameter to little effect other > than slowing down my booting. > > I found this, which may be related: >

Re: It takes me up to 20 reboots for the system to start sda

2016-10-28 Thread Bearcat Şándor
Thanks for the suggestions Kai. I'm using dracut 044. I tried using the rootdelay=2 kernel parameter to little effect other than slowing down my booting. I found this, which may be related: https://github.com/dracutdevs/dracut/issues/149 (btrfs raid on rootdev is unreliably mounted). On Thu,

Re: [PATCH v3] generic: make 17[1-4] work well when btrfs compression is enabled

2016-10-28 Thread Eryu Guan
On Fri, Oct 28, 2016 at 03:05:55PM +0800, Wang Xiaoguang wrote: > hi, > > On 10/27/2016 07:25 PM, Eryu Guan wrote: > > On Wed, Oct 26, 2016 at 05:52:11PM +0800, Wang Xiaoguang wrote: > > > When enabling btrfs compression, original codes can not fill fs > > > correctly, here we introduce

Re: [PATCH v3] generic: make 17[1-4] work well when btrfs compression is enabled

2016-10-28 Thread Eryu Guan
On Fri, Oct 28, 2016 at 03:00:29PM +0800, Wang Xiaoguang wrote: > hi, > > On 10/28/2016 01:13 AM, Darrick J. Wong wrote: > > On Wed, Oct 26, 2016 at 05:52:11PM +0800, Wang Xiaoguang wrote: > > > When enabling btrfs compression, original codes can not fill fs > > > correctly, here we introduce

Re: [PATCH v3] generic: make 17[1-4] work well when btrfs compression is enabled

2016-10-28 Thread Wang Xiaoguang
hi, On 10/27/2016 07:25 PM, Eryu Guan wrote: On Wed, Oct 26, 2016 at 05:52:11PM +0800, Wang Xiaoguang wrote: When enabling btrfs compression, original codes can not fill fs correctly, here we introduce _fill_fs() in common/rc, which'll keep creating and writing files until enospc error occurs.

Re: [PATCH v3] generic: make 17[1-4] work well when btrfs compression is enabled

2016-10-28 Thread Wang Xiaoguang
hi, On 10/28/2016 01:13 AM, Darrick J. Wong wrote: On Wed, Oct 26, 2016 at 05:52:11PM +0800, Wang Xiaoguang wrote: When enabling btrfs compression, original codes can not fill fs correctly, here we introduce _fill_fs() in common/rc, which'll keep creating and writing files until enospc error