[PATCH] btrfs: remove redundant assignment and check on variable ret

2017-05-06 Thread Colin King
From: Colin Ian King Variable ret is assigned to zero and is always zero throughout the function. Thus the check for ret being less than zero is always false and so mapping_set_error always has an -EIO error passed to it. Hence we can remove the redundant assignment

Re: [PATCH 9/9] btrfs-progs: modify: Introduce option to specify the pattern to fill mirror

2017-05-06 Thread Lakshmipathi.G
okay, but I'm not sure whether it can be useful here other than the sample cli usage. The reason, this tool relies heavily on Python/C layer[1]. The framework works like this: C-api(fs-progs) <--> Python/C api <--> Python program. C-api is typical fs library (like libext2fs/libbtrfs) and

"Corrected" errors persist after scrubbing

2017-05-06 Thread Tom Hale
Below (and also attached because of formatting) is an example of `btrfs scrub` incorrectly reporting that errors have been corrected. In this example, /dev/md127 is the device created by running: mdadm --build /dev/md0 --level=faulty --raid-devices=1 /dev/loop0 The filesystem is RAID1. # mdadm