Re: [PATCH v2] fstests: btrfs: Test if btrfs will corrupt nodatasum compressed extent when replacing device

2018-06-13 Thread Qu Wenruo
On 2018年06月14日 13:30, Eryu Guan wrote: > On Fri, Jun 08, 2018 at 02:17:23PM +0800, Qu Wenruo wrote: >> This is a long existing bug (from 2012) but exposed by a reporter >> recently, that when compressed extent without data csum get written to >> device-replace target device, the written data is

Re: [PATCH v2] fstests: btrfs: Test if btrfs will corrupt nodatasum compressed extent when replacing device

2018-06-13 Thread Eryu Guan
On Fri, Jun 08, 2018 at 02:17:23PM +0800, Qu Wenruo wrote: > This is a long existing bug (from 2012) but exposed by a reporter > recently, that when compressed extent without data csum get written to > device-replace target device, the written data is in fact uncompressed data > other than the

[PATCH] btrfs-progs: print bytenr of tree block in print_tree_block_error()

2018-06-13 Thread Su Yue
For easier debug, let print_tree_block_error() print bytenr of tree block. Signed-off-by: Su Yue --- disk-io.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/disk-io.c b/disk-io.c index 4a609a892be7..6ee65190f251 100644 --- a/disk-io.c +++ b/disk-io.c @@ -94,6 +94,9 @@ static void

Re: [LKP] [lkp-robot] [mm] 9092c71bb7: blogbench.write_score -12.3% regression

2018-06-13 Thread Huang, Ying
Ping again ... "Huang, Ying" writes: > Ping... > > "Huang, Ying" writes: > >> Hi, Josef, >> >> Do you have time to take a look at the regression? >> >> kernel test robot writes: >> >>> Greeting, >>> >>> FYI, we noticed a -12.3% regression of blogbench.write_score and a +9.6% >>> improvement

Re: [PATCH v2] btrfs: Rewrite retry logic in do_chunk_alloc

2018-06-13 Thread Nikolay Borisov
On 18.04.2018 10:27, Nikolay Borisov wrote: > do_chunk_alloc implements logic to detect whether there is currently > pending chunk allocation (by means of space_info->chunk_alloc being > set) and if so it loops around to the 'again' label. Additionally, > based on the state of the space_info

Re: [PATCH] btrfs: Document __btrfs_inc_extent_ref

2018-06-13 Thread Nikolay Borisov
On 18.05.2018 16:12, Nikolay Borisov wrote: > Here is a doc-only patch which tires to deobfuscate the terra-incognita > that arguments for delayed refs are. > > Signed-off-by: Nikolay Borisov > --- > Hello, > > This patch needs revieweing since I'm not entirely sure I managed to capture >

Re: deadlock on btrfs scrub...

2018-06-13 Thread Eli V
On Tue, Jun 12, 2018 at 7:48 PM, Alexander Zapatka wrote: > hello. a while ago i wrote to the list that i was getting a deadlock > when working with a btrfs file system on a drive that had a bad > sector. i finally resolved the bad sector, smartctl says there are no > bad sectors, and it has

Re: [PATCH REBASED 0/2] btrfs: Delay block group auto removal to avoid interfering qgroups

2018-06-13 Thread Qu Wenruo
Hi David, Please ignore this patchset. The fix can only reduce the possibility of the problem, but not really fix it. Although the root cause of the problem is still pretty the same, that btrfs_delete_unused_bgs() deletes some block groups still in usage. However it's not just about the

Re: [PATCH v3] btrfs: Add test that checks rmdir(2) can delete a subvolume

2018-06-13 Thread Eryu Guan
On Wed, Jun 13, 2018 at 03:06:45PM +0900, Misono Tomohiro wrote: > Add btrfs test that checks "rmdir" or "rm -r" command can delete a > subvolume like an ordinary directory. > > This behavior has been restricted long time but becomes allowed by > following commit in the kernel: > btrfs: Allow

[PATCH v3] btrfs: Add test that checks rmdir(2) can delete a subvolume

2018-06-13 Thread Misono Tomohiro
Add btrfs test that checks "rmdir" or "rm -r" command can delete a subvolume like an ordinary directory. This behavior has been restricted long time but becomes allowed by following commit in the kernel: btrfs: Allow rmdir(2) to delete an empty subvolume The test will be skipped if kernel does