Re: [PATCH] Btrfs: cleanup redundant code in __btrfs_close_devices()

2013-09-10 Thread Azat Khuzhin
On Mon, Sep 9, 2013 at 7:28 AM, Wang Shilong wangsl.f...@cn.fujitsu.com wrote: On 09/08/2013 12:15 AM, Azat Khuzhin wrote: Signed-off-by: Azat Khuzhin a3at.m...@gmail.com --- fs/btrfs/volumes.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/btrfs/volumes.c b/fs

Re: [PATCH] Btrfs: cleanup redundant code in __btrfs_close_devices()

2013-09-10 Thread Azat Khuzhin
On Tue, Sep 10, 2013 at 5:15 PM, Wang Shilong wangshilong1...@gmail.com wrote: On Mon, Sep 9, 2013 at 7:28 AM, Wang Shilong wangsl.f...@cn.fujitsu.com wrote: On 09/08/2013 12:15 AM, Azat Khuzhin wrote: Signed-off-by: Azat Khuzhin a3at.m...@gmail.com --- fs/btrfs/volumes.c |2 +- 1

[PATCH] Btrfs: cleanup redundant code in __btrfs_close_devices()

2013-09-07 Thread Azat Khuzhin
Signed-off-by: Azat Khuzhin a3at.m...@gmail.com --- fs/btrfs/volumes.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c index 1d1b595..124228e 100644 --- a/fs/btrfs/volumes.c +++ b/fs/btrfs/volumes.c @@ -644,7 +644,7 @@ static int

[PATCH] btrfs: use list_for_each_entry_safe() when delete items

2013-09-01 Thread Azat Khuzhin
may happen. } Signed-off-by: Azat Khuzhin a3at.m...@gmail.com Reviewed-by: Miao Xie mi...@cn.fujitsu.com --- V2: Add some comments from Miao into commit message fs/btrfs/volumes.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs

Re: [PATCH] btrfs: use list_for_each_entry_safe() when delete items

2013-08-31 Thread Azat Khuzhin
On Tue, Jul 30, 2013 at 7:40 AM, Miao Xie mi...@cn.fujitsu.com wrote: On mon, 29 Jul 2013 11:48:32 +0400, Azat Khuzhin wrote: On Sat, Jul 27, 2013 at 2:12 PM, Azat Khuzhin a3at.m...@gmail.com wrote: Replace list_for_each_entry() by list_for_each_entry_safe() in __btrfs_close_devices

Re: [PATCH] btrfs: use list_for_each_entry_safe() when delete items

2013-07-29 Thread Azat Khuzhin
On Sat, Jul 27, 2013 at 2:12 PM, Azat Khuzhin a3at.m...@gmail.com wrote: Replace list_for_each_entry() by list_for_each_entry_safe() in __btrfs_close_devices() There is another place that delete items lock_stripe_add(), but there we don't need safe version, because after deleting we exit from

[PATCH] btrfs: use list_for_each_entry_safe() when delete items

2013-07-27 Thread Azat Khuzhin
Replace list_for_each_entry() by list_for_each_entry_safe() in __btrfs_close_devices() There is another place that delete items lock_stripe_add(), but there we don't need safe version, because after deleting we exit from loop. Signed-off-by: Azat Khuzhin a3at.m...@gmail.com --- fs/btrfs

[PATCH] btrfs: use list_for_each_entry_safe() when delete items

2013-07-26 Thread Azat Khuzhin
Replace list_for_each_entry() by list_for_each_entry_safe() in next functions: - lock_stripe_add() - __btrfs_close_devices() Signed-off-by: Azat Khuzhin a3at.m...@gmail.com --- fs/btrfs/raid56.c |4 ++-- fs/btrfs/volumes.c |4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff