Re: [PATCH RFC 01/11] vfs: pull btrfs clone API to vfs layer

2015-08-25 Thread Dave Chinner
the problem being solved is, how it is being used by existing filesystems, how it will be used by your new changes, etc. You may have explained all this in patch 0 for the series, but that hasn't been cc'd to linux-fsdevel Cheers, Dave. PS: CC list spraying also plays badly with dup filters

Re: [PATCH RFC 01/11] vfs: pull btrfs clone API to vfs layer

2015-08-25 Thread Dave Chinner
On Wed, Aug 26, 2015 at 11:50:34AM +1000, Dave Chinner wrote: On Tue, Aug 25, 2015 at 11:33:39PM +0800, Peng Tao wrote: Now that a few file systems are adding clone functionality, namingly btrfs, NFS (later in the series) and XFS (ttp://oss.sgi.com/archives/xfs/2015-06/msg00407.html

Re: [PATCH v6 1/3] xfstests: btrfs: add functions to create dm-error device

2015-08-20 Thread Dave Chinner
On Thu, Aug 20, 2015 at 03:09:05PM +0800, Anand Jain wrote: (thanks for the off-ML emails from the people who helped me to understand). Dave, looks like you are suggesting something like.. --- +_dmerror_mount_options() +{ + _scratch_options mount + echo

Re: [PATCH v6 1/3] xfstests: btrfs: add functions to create dm-error device

2015-08-19 Thread Dave Chinner
_scratch_mount_options in the first place: I am shocked. What was missed ? Answering the question I asked: Q: what do we do instead of copy'n'paste of random code fragments? Think on it, because the answer to that question (and it's not a hard one) should tell you exactly what you need to do. -Dave. -- Dave

Re: [PATCH v6 1/3] xfstests: btrfs: add functions to create dm-error device

2015-08-18 Thread Dave Chinner
On Tue, Aug 18, 2015 at 12:26:54PM +0800, anand jain wrote: Hi Dave, All comments accepted thanks. except for this. +_mount_dmerror() +{ + $MOUNT_PROG -t $FSTYP $MOUNT_OPTIONS $DMERROR_DEV $SCRATCH_MNT +} Should mirror _scratch_mount. _mount -t $FSTYP `_scratch_mount_options

Re: [PATCH v2] fstests: generic/018: expand write backwards sync but contiguous to test regression in btrfs

2015-08-16 Thread Dave Chinner
- catch the error message, and if there isn't one on stderr then xfs_io need fixing... Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH v6 1/3] xfstests: btrfs: add functions to create dm-error device

2015-08-16 Thread Dave Chinner
comments, thanks v2-v2.1: fixed missed typo error fixup in the commit. v1-v2: accepts Dave Chinner's review comments, thanks This is not a change log. A change log describes the changes that were made, not who asked for changes to be made. i.e. I have no idea what changes you actually made from

Re: [PATCH] fstests: btrfs regression test for defrag tail extents

2015-08-10 Thread Dave Chinner
don't see anything btrfs specific in this test, so it belongs in tests/generic/ Also, how is this different to generic/018 testing fragmented files defrag back to one extent? Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-btrfs

Re: [PATCH v2] fstests: btrfs: Add regression test for reserved space leak.

2015-08-04 Thread Dave Chinner
trigger the bug. +sync Isn't '$BTRFS_UTIL_PROG filesystem sync' better instead of 'sync'? Thanks, Tsutomu Hi, Tsutomu-san, Yes, I did use such method before, but Dave said it's better to use unified interface to sync a filesystem other than the specialized one. So I still use sync

Re: [PATCH v2] fstests: btrfs: Add regression test for reserved space leak.

2015-08-04 Thread Dave Chinner
On Wed, Aug 05, 2015 at 11:52:36AM +0900, Tsutomu Itoh wrote: On 2015/08/05 10:57, Dave Chinner wrote: On Wed, Aug 05, 2015 at 09:39:35AM +0800, Qu Wenruo wrote: Tsutomu Itoh wrote on 2015/08/05 10:26 +0900: On 2015/08/05 10:08, Qu Wenruo wrote: +# As the reserved space freeing happens

Re: [PATCH] generic/311: Disable dmesg check

2015-07-22 Thread Dave Chinner
On Wed, Jul 22, 2015 at 07:28:55AM -0400, Josef Bacik wrote: On 07/22/2015 01:27 AM, Dave Chinner wrote: Josef, Chris, is this really how btrfs handles metadata write failures? This handling of errors seems like a design flaw rather than a desireable behaviour to me Jeeze you

Re: [PATCH] generic/311: Disable dmesg check

2015-07-22 Thread Dave Chinner
On Wed, Jul 22, 2015 at 08:47:54AM -0400, Josef Bacik wrote: On 07/22/2015 01:27 AM, Dave Chinner wrote: On Tue, Jul 21, 2015 at 08:37:39PM -0400, Josef Bacik wrote: This test is to verify that said shit is on disk after an fsync. The drop all writes from this point onwards does this silently

Re: [PATCH] generic/311: Disable dmesg check

2015-07-21 Thread Dave Chinner
On Tue, Jul 21, 2015 at 08:37:39PM -0400, Josef Bacik wrote: On 07/21/2015 08:01 PM, Dave Chinner wrote: On Tue, Jul 21, 2015 at 04:03:17PM +0530, Chandan Rajendra wrote: On Tuesday 21 Jul 2015 08:12:20 Dave Chinner wrote: On Mon, Jul 20, 2015 at 08:55:32AM -0400, Josef Bacik wrote: On 07/19

Re: [PATCH] generic/311: Disable dmesg check

2015-07-21 Thread Dave Chinner
On Tue, Jul 21, 2015 at 04:03:17PM +0530, Chandan Rajendra wrote: On Tuesday 21 Jul 2015 08:12:20 Dave Chinner wrote: On Mon, Jul 20, 2015 at 08:55:32AM -0400, Josef Bacik wrote: On 07/19/2015 07:54 PM, Dave Chinner wrote: On Fri, Jul 17, 2015 at 05:10:50PM +0530, Chandan Rajendra wrote

Re: [PATCH] generic/311: Disable dmesg check

2015-07-20 Thread Dave Chinner
On Mon, Jul 20, 2015 at 08:55:32AM -0400, Josef Bacik wrote: On 07/19/2015 07:54 PM, Dave Chinner wrote: On Fri, Jul 17, 2015 at 05:10:50PM +0530, Chandan Rajendra wrote: On Friday 17 Jul 2015 06:16:02 Brian Foster wrote: On Fri, Jul 17, 2015 at 12:56:43AM -0400, Chandan Rajendra wrote: When

Re: [PATCH] generic/311: Disable dmesg check

2015-07-19 Thread Dave Chinner
to make tests pass. The bug in the code being tested should be fixed so the warning/error is not generated. If you do not want to see the error, then expung the test from your subpagesize-blocksize test runs. Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send

Re: [PATCH RESEND] Btrfs: add autodefrag inode flag

2015-06-30 Thread Dave Chinner
flag, API and behaviour across filesystems? Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: i_version vs iversion (Was: Re: [RFC PATCH v2 1/2] Btrfs: add noi_version option to disable MS_I_VERSION)

2015-06-24 Thread Dave Chinner
On Wed, Jun 24, 2015 at 07:17:50PM -0400, Theodore Ts'o wrote: On Wed, Jun 24, 2015 at 08:02:15PM +0200, David Sterba wrote: This sounds similar to what Dave proposed, a per-inode I_VERSION attribute that can be changed through chattr. Though the negated meaning of the flag could

Re: i_version vs iversion (Was: Re: [RFC PATCH v2 1/2] Btrfs: add noi_version option to disable MS_I_VERSION)

2015-06-22 Thread Dave Chinner
, because we aren't ever going to turn it off Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in

Re: [PATCH 2/2][v2] blk-plug: don't flush nested plug lists

2015-04-08 Thread Dave Chinner
making a sweeping generalisation that the IO stack plugging infrastructure needs fundamental change? Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH] xfstests: generic: test for discard properly discarding unused extents

2015-04-01 Thread Dave Chinner
, just do it button. Urk. If btrfs requires two sync passes to really sync data/metadata, then that's a bug that needs to be fixed. Let's not encode superstition or work around bugs that really should be fixed in the test code Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe

Re: the wiki?

2015-03-31 Thread Dave Stevens
Quoting André-Sebastian Liebe an...@lianse.eu: Hi Dave, you should forward your question directly to kernel.org webmaster webmas...@kernel.org. They are using mediawiki in a multisite environment for all kernel.org related wikis. regards, André Thanks! Dave On 03/31/2015 04:00 AM, Dave

the wiki?

2015-03-30 Thread Dave Stevens
. Are there plans to migrate the content to a newer vesion? Dave -- As long as politics is the shadow cast on society by big business, the attenuation of the shadow will not change the substance. -- John Dewey -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body

Re: [PATCH 1/3] dm: log writes target

2015-03-21 Thread Dave Chinner
people are going to have the same problem understanding what this device is for because of that. I know this is effectively bikeshedding, but I think a less ambiguous name would be a good thing to have. e.g. dm-iotracer. Nobody will get confused that way Cheers, Dave. -- Dave Chinner da

Clone or Backup Filesystem with compression and dedup

2015-03-08 Thread dave
Greetings, I've searched the wiki and the web looking for possible answers to this question and haven't found information that addresses this use case specifically. I would greatly appreciate your help or pointing me in the right direction. Thanks in advance! Dave Use case: I have a 5TB

Re: [PATCH v3] fstests: generic test for directory fsync after adding hard links

2015-02-24 Thread Dave Chinner
, or needs to be maintained by someone else. Precisely. Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

OT raid-1 from raid-10?

2015-02-21 Thread Dave Stevens
If there's a better list please say so. I have a raid-10 array with two dirty drives and (according to the kernel) not enough mirrors to repair the raid-10. But I think drives sda and sdb are mirrored and maybe I could read the data off them if I changed the fs type from linux raid

Re: [PATCH] fstests: generic test for fsync followed by truncate and link

2015-02-16 Thread Dave Chinner
On Mon, Feb 16, 2015 at 12:19:58PM +0800, Liu Bo wrote: On Mon, Feb 16, 2015 at 11:33:37AM +1100, Dave Chinner wrote: On Fri, Feb 13, 2015 at 12:47:54PM +, Filipe Manana wrote: This test is motivated by an fsync issue discovered in btrfs. The issue was that we could lose file data

Re: [PATCH] fstests: generic test for fsync followed by truncate and link

2015-02-15 Thread Dave Chinner
and pain for application developers. The btrfs issue was fixed by the following linux kernel patch: Btrfs: don't remove extents and xattrs when logging new names Sounds like you've just introduced an ordered mode behavioural journalling regression into btrfs... Cheers, Dave. -- Dave Chinner

Re: [PATCH v5] btrfs: add regression test for remount with thread_pool resized

2015-01-26 Thread Dave Chinner
switch in it. That's the place to add any btrfs specific mkfs filters, either in line or as a callout to a special functionin common/btrfs. Cheers. Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body of a message to majord

Re: [PATCH v4] btrfs: add regression test for remount with thread_pool resized

2015-01-23 Thread Dave Chinner
. In fact, I'll go as far as to suggest that outputting operational status information on stderr is a bug/regression in mkfs.btrfs. Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body of a message to majord

Re: [PATCH] fstests: btrfs/079: Fix wrong value passed to available space check.

2015-01-20 Thread Dave Chinner
If the falloc fails, then the golden output match will fail. Let the test run, regardless, because the first thing it does is try to overwrite the fallocated region where the success or failure of the writes are completely ignored. Hence a falloc failure should also be ignored... Cheers, Dave. -- Dave

Re: [PATCH v2] xfstests: btrfs: fix up 001.out

2015-01-20 Thread Dave Chinner
| _filter_transcation_commit_default | \ sed -e 's/^Delete subvolume.*:/Delete subvolume/' } The golden output does not change - the filter simply removes the part of the message that changed between versions. Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line

Re: [PATCH] fstest: btrfs/006: Add extra check on return value and 'fi show' by device

2015-01-20 Thread Dave Chinner
On Wed, Jan 21, 2015 at 12:19:32PM +0800, Qu Wenruo wrote: From: Dave Chinner da...@fromorbit.com On Fri, Jan 16, 2015 at 09:57:10AM +0800, Qu Wenruo wrote: Reported in Red Hat BZ#1181627, 'btrfs fi show' on unmounted device will return 1 even no error happens. Please describe the bug

should I use btrfs on Centos 7 for a new production server?

2014-12-30 Thread Dave Stevens
an opinion? Dave -- As long as politics is the shadow cast on society by big business, the attenuation of the shadow will not change the substance. -- John Dewey -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body of a message to majord...@vger.kernel.org More

Re: [PATCH] btrfs: add regression test for remount with thread_pool resized

2014-12-23 Thread Dave Chinner
job). For reference: Regresssion commit: 08a9ff3264181986d1d692a4e6fce3669700c9f8 (All my fault) Fix commit: 800ee2247f483b6d05ed47ef3bbc90b56451746c That belongs in the commit message, not the test description. -Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send

Re: [PATCH v2] btrfs: add regression test for remount with thread_pool resized

2014-12-23 Thread Dave Chinner
used to indicate that the golden output expects no output from the test. Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH 1/2] btrfs-progs: Add support for btrfs-image + corrupt script fsck test case.

2014-12-23 Thread Dave Chinner
to test the kernel implementation of filesystems. I believe it includes user space code too, but I might be wrong so I'm CCing fstests and Dave to get an authoritative answer. We use fstests to test everything we ship for XFS - kernel and userspace. i.e. we have tests that corrupt filesystems

Re: [PATCH 1/2] btrfs-progs: Add support for btrfs-image + corrupt script fsck test case.

2014-12-23 Thread Dave Chinner
On Wed, Dec 24, 2014 at 10:56:04AM +0800, Qu Wenruo wrote: Original Message Subject: Re: [PATCH 1/2] btrfs-progs: Add support for btrfs-image + corrupt script fsck test case. From: Dave Chinner da...@fromorbit.com To: Filipe David Manana fdman...@gmail.com Date: 2014年12月

Re: [PATCH v3] xfstests: btrfs: add test case for qgroup account on shared extents

2014-12-17 Thread Dave Chinner
. If an unlink fails, we want to know about it. +_run_btrfs_util_prog filesystem sync $SCRATCH_MNT What's wrong with sync? +$BTRFS_UTIL_PROG qgroup show $SCRATCH_MNT | $SED_PROG -n '/[0-9]/p' | $AWK_PROG '{print $2 $3}' You can do regex matches with awk. Cheers, Dave. -- Dave Chinner da

Re: Running out of disk space during BTRFS_IOC_CLONE - rebalance doesn't help

2014-12-08 Thread Dave
file system [ 201.078328] systemd-journald[213]: Failed to truncate file to its own size: Read-only file system [ 201.088432] systemd-journald[213]: Failed to truncate file to its own size: Read-only file system -- -=[dave]=- Entropy isn't what it used to be. -- To unsubscribe from this list

Re: [PATCH] fstests: add btrfs test to stress chunk allocation/removal and fstrim

2014-11-30 Thread Dave Chinner
+082 auto I'd suggest that for a generic test we'd want to add the stress group to this, and allow the test to be scaled in terms of filesystem size and the number of concurrent trim and fallocate loops by $LOAD_FACTOR Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from

Re: [PATCH 3/4] vfs: don't let the dirty time inodes get more than a day stale

2014-11-26 Thread Dave Chinner
On Wed, Nov 26, 2014 at 05:20:17AM -0500, Theodore Ts'o wrote: On Wed, Nov 26, 2014 at 10:48:51AM +1100, Dave Chinner wrote: No abuse necessary at all. Just a different inode_dirtied_after() check is requires if the inode is on the time dirty list in move_expired_inodes(). I'm still

Re: [PATCH-v4 6/7] ext4: add support for a lazytime mount option

2014-11-26 Thread Dave Chinner
not matching what log recovery wrote to disk for all the other inode metadata... Optimistic unlogged inode updates are a slippery slope, and history tells me that it doesn't lead to a nice place Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line

Re: [PATCH-v4 6/7] ext4: add support for a lazytime mount option

2014-11-26 Thread Dave Chinner
On Wed, Nov 26, 2014 at 04:10:44PM -0700, Andreas Dilger wrote: On Nov 26, 2014, at 3:48 PM, Dave Chinner da...@fromorbit.com wrote: On Wed, Nov 26, 2014 at 05:23:56AM -0500, Theodore Ts'o wrote: Add an optimization for the MS_LAZYTIME mount option so that we will opportunistically write

Re: [PATCH 3/4] vfs: don't let the dirty time inodes get more than a day stale

2014-11-25 Thread Dave Chinner
On Mon, Nov 24, 2014 at 11:45:08PM -0500, Theodore Ts'o wrote: On Tue, Nov 25, 2014 at 12:53:32PM +1100, Dave Chinner wrote: On Fri, Nov 21, 2014 at 02:59:23PM -0500, Theodore Ts'o wrote: Guarantee that the on-disk timestamps will be no more than 24 hours stale. Signed-off

Re: [PATCH 2/4] vfs: add support for a lazytime mount option

2014-11-25 Thread Dave Chinner
On Mon, Nov 24, 2014 at 11:33:35PM -0500, Theodore Ts'o wrote: On Tue, Nov 25, 2014 at 12:52:39PM +1100, Dave Chinner wrote: +static void flush_sb_dirty_time(struct super_block *sb) +{ ... +} This just seems wrong to me, not to mention extremely expensive when we have millions

Re: [PATCH 2/4] vfs: add support for a lazytime mount option

2014-11-24 Thread Dave Chinner
#define I_DIO_WAKEUP (1 I_DIO_WAKEUP) #define I_LINKABLE (1 10) +#define I_DIRTY_TIME (1 11) #define I_DIRTY (I_DIRTY_SYNC | I_DIRTY_DATASYNC | I_DIRTY_PAGES) Shouldn't I_DIRTY also include I_DIRTY_TIME now? -- Dave Chinner da...@fromorbit.com

Re: [PATCH 3/4] vfs: don't let the dirty time inodes get more than a day stale

2014-11-24 Thread Dave Chinner
unnecessary. Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 1/5] direct-io: don't dirty ITER_BVEC pages on read

2014-11-21 Thread Dave Kleikamp
On 11/21/2014 04:08 AM, Omar Sandoval wrote: Reads through the iov_iter infrastructure for kernel pages shouldn't be dirtied by the direct I/O code. This is based on Dave Kleikamp's and Ming Lei's previously posted patches. Acked-by: Dave Kleikamp dave.kleik...@oracle.com Cc: Ming Lei

Re: [PATCH] Btrfs: do not move em to modified list when unpinning

2014-11-18 Thread Dave Chinner
xfstest? Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] mm: check memory reclaim bugs caused fs reentrance

2014-11-11 Thread Dave Chinner
pointed out allocation/reclaim context problems in XFS until we fixed them Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH] fstests: add generic test to verify xattr replace operations are atomic

2014-11-10 Thread Dave Chinner
On Mon, Nov 10, 2014 at 11:53:00AM +, Filipe David Manana wrote: On Mon, Nov 10, 2014 at 1:31 AM, Dave Chinner da...@fromorbit.com wrote: On Mon, Nov 10, 2014 at 12:49:12AM +, Filipe David Manana wrote: On Sun, Nov 9, 2014 at 11:45 PM, Dave Chinner da...@fromorbit.com wrote: On Fri

Re: [PATCH] fstests: add generic test to verify xattr replace operations are atomic

2014-11-09 Thread Dave Chinner
it as a separate patch and include all the tests (across all the test directories) that manipulate xattrs in some way. Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body of a message to majord...@vger.kernel.org More

Re: [PATCH] fstests: add generic test to verify xattr replace operations are atomic

2014-11-09 Thread Dave Chinner
On Mon, Nov 10, 2014 at 12:49:12AM +, Filipe David Manana wrote: On Sun, Nov 9, 2014 at 11:45 PM, Dave Chinner da...@fromorbit.com wrote: On Fri, Nov 07, 2014 at 08:40:26PM +, Filipe Manana wrote: This test verifies that replacing a xattr's value is an atomic operation

Re: [PATCH] btrfs: regression test for btrfs extent merge

2014-11-09 Thread Dave Chinner
, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2] fstests: btrfs, add test for snapshoting after file write + truncate

2014-11-09 Thread Dave Chinner
-- 1.9.1 -- To unsubscribe from this list: send the line unsubscribe fstests in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH] fstests: btrfs, add regression test for clone ioctl

2014-11-09 Thread Dave Chinner
$SCRATCH_MNT/$name xfs_io dumps errors into the output file and that causes failures. there is no need to use run_check here. -Dave. + done +} + +create_target_file() +{ + name=$1 + file_size=$(($num_extents * $extent_size)) + + run_check $XFS_IO_PROG -f -c pwrite -S 0xff 0

Re: btrfs: WARN_ON(data_sinfo-bytes_may_use bytes);

2014-10-24 Thread Dave Jones
.. That one was nothing special, just -q -l off. I've not been able to reproduce it in the last two days though. Dave -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: Poll: time to switch skinny-metadata on by default?

2014-10-22 Thread Dave
-42-g140eccb # btrfstune -x /dev/dm-0 /dev/dm-0 is mounted -- -=[dave]=- Entropy isn't what it used to be. -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

btrfs: WARN_ON(data_sinfo-bytes_may_use bytes);

2014-10-22 Thread Dave Jones
Just hit this while running trinity. WARNING: CPU: 3 PID: 9612 at fs/btrfs/extent-tree.c:3799 btrfs_free_reserved_data_space+0x1d1/0x280 [btrfs]() Modules linked in: rfcomm hidp bnep af_key llc2 scsi_transport_iscsi nfnetlink sctp libcrc32c can_raw can_bcm nfc caif_socket caif af_802154

Re: btrfs: WARN_ON(data_sinfo-bytes_may_use bytes);

2014-10-22 Thread Dave Jones
On Wed, Oct 22, 2014 at 09:07:31PM -0400, Dave Jones wrote: Just hit this while running trinity. WARNING: CPU: 3 PID: 9612 at fs/btrfs/extent-tree.c:3799 btrfs_free_reserved_data_space+0x1d1/0x280 [btrfs]() Modules linked in: rfcomm hidp bnep af_key llc2 scsi_transport_iscsi

[3.18rc1] btrfs triggering vm bug_on

2014-10-21 Thread Dave Jones
page:ea00088aa1c0 count:4 mapcount:0 mapping:88009901e2d8 index:0x0 flags: 0x2ffc000806(error|referenced|private) page dumped because: VM_BUG_ON_PAGE(!PageLocked(page)) [ cut here ] kernel BUG at mm/filemap.c:747! invalid opcode: [#1] PREEMPT SMP

Re: [3.18rc1] btrfs triggering vm bug_on

2014-10-21 Thread Dave Jones
On Wed, Oct 22, 2014 at 08:50:57AM +0800, Qu Wenruo wrote: Any reproducer? Thanks, Qu Original Message Subject: [3.18rc1] btrfs triggering vm bug_on From: Dave Jones da...@redhat.com To: Linux Kernel linux-ker...@vger.kernel.org Date: 2014年10月22日 05:57

Re: [PATCH] xfstests: add regression for inode bad compression ratio detection

2014-10-07 Thread Dave Chinner
: . common/defrag _extent_count $SCRATCH_MNT/data Will do the same thing without introducing a dependence on filefrag. Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body of a message to majord

Re: [PATCH 2/2] xfstests,btrfs/004: use FILEFRAG_PROG macro

2014-10-07 Thread Dave Chinner
() outputs a strings of the format #physical#length#logical#flags and this is then cut up later later by the test. fiemap outputs the same information, it just requires slightly different processing via the _filter_extents function to munge it into the same format... Cheers, Dave. -- Dave Chinner da

Re: [PATCH 2/2] xfstests,btrfs/004: use FILEFRAG_PROG macro

2014-10-07 Thread Dave Chinner
is in 512 byte blocks. And fiemap needs the -v option to output the flag state. Same information, different presentation. Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body of a message to majord...@vger.kernel.org

Re: [PATCH v3 00/15] xfstests: new btrfs stress test cases

2014-09-24 Thread Dave Chinner
. I can't make judgement on whether the tests are valid things to do to btrfs, so I'm reliant on people with actual btrfs expertise to vet these patches... -Dave. On Thu, Sep 18, 2014 at 01:49:24PM +0800, Eryu Guan wrote: This patchset add new stress test cases for btrfs by running two different

Re: [PATCH 01/15 v2] btrfs: new test to run btrfs balance and subvolume test simultaneously

2014-09-09 Thread Dave Chinner
On Tue, Sep 09, 2014 at 07:53:24PM +0800, Eryu Guan wrote: On Mon, Sep 08, 2014 at 08:01:27PM +1000, Dave Chinner wrote: I'm thinking that we need to start separating common/rc in filesystem specific include files. Not necessary for this series, but we really need to so using this file

Re: [PATCH 00/15 v2] xfstests: new btrfs stress test cases

2014-09-08 Thread Dave Chinner
: scrub-defrag 072: scrub-remount 073: defrag-remount Can I get some reviews for btrfs people for this series, please? Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body of a message to majord

Re: [PATCH 01/15 v2] btrfs: new test to run btrfs balance and subvolume test simultaneously

2014-09-08 Thread Dave Chinner
stuff under $TESTDIR/$seq.mnt. That's what the testdir is there for... Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH 02/15 v2] btrfs: new test to run btrfs balance and scrub simultaneously

2014-09-08 Thread Dave Chinner
btrfs sync before unmount? THose three lines should be just one: _check_scratch_fs If the test actually requires a special btrfs hack before unmount, add a comment explaining why that hack is necessary Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send

Re: [PATCH 04/15 v2] btrfs: new case to run btrfs balance and remount with different compress algorithms

2014-09-08 Thread Dave Chinner
+ -m raid1 -d raid0 + -m raid1 -d raid1 + -m raid10 -d raid10 + -m raid5 -d raid5 + -m raid6 -d raid6 +) This is pretty common, right? Perhaps this should be a config variable that can be overridden by the config file configuration? Cheers, Dave. -- Dave Chinner da

Re: ext4 vs btrfs performance on SSD array

2014-09-01 Thread Dave Chinner
/dev/sdd' before mounting the filesystem will probably fix it. -Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 01/15] btrfs: new test to run btrfs balance and subvolume test simultaneously

2014-08-21 Thread Dave Chinner
$seqres.full + +MKFS_OPTIONS=$MKFS_OPTIONS $mkfs_opts +# dup only works on single device it's doing exactly what you suggest. And it's wrong. This: _scratch_mkfs $mkfs_opts is all that is needed. This wheel does not need reinventing. ;) Cheers, Dave. -- Dave Chinner da

Re: [PATCH 01/15] btrfs: new test to run btrfs balance and subvolume test simultaneously

2014-08-21 Thread Dave Chinner
On Thu, Aug 21, 2014 at 05:15:01PM +0800, Qu Wenruo wrote: Original Message Subject: Re: [PATCH 01/15] btrfs: new test to run btrfs balance and subvolume test simultaneously From: Dave Chinner da...@fromorbit.com To: Qu Wenruo quwen...@cn.fujitsu.com Date: 2014年08月21日 17

Re: [PATCH 00/15] xfstests: new btrfs stress test cases

2014-08-21 Thread Dave Chinner
of run time, but we get much more fine-grained control of execution and reporting Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH] xfstest: add tests/btrfs/059 to test seed operations

2014-08-20 Thread Dave Chinner
. Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2] common: get fs type again using device canonical name in _fs_type

2014-08-01 Thread Dave Chinner
On Fri, Aug 01, 2014 at 01:02:58PM +0800, Eryu Guan wrote: On Fri, Aug 01, 2014 at 02:49:10PM +1000, Dave Chinner wrote: On Fri, Aug 01, 2014 at 12:02:41PM +0800, Eryu Guan wrote: On Fri, Aug 01, 2014 at 10:21:59AM +1000, Dave Chinner wrote: On Thu, Jul 31, 2014 at 06:52:37PM +0800, Eryu

Re: [PATCH v2] common: get fs type again using device canonical name in _fs_type

2014-07-31 Thread Dave Chinner
On Fri, Aug 01, 2014 at 12:02:41PM +0800, Eryu Guan wrote: On Fri, Aug 01, 2014 at 10:21:59AM +1000, Dave Chinner wrote: On Thu, Jul 31, 2014 at 06:52:37PM +0800, Eryu Guan wrote: When testing with lvm, a previous btrfsck run could change df output from something like /dev/mapper

Re: [PATCH] Remove certain calls for releasing page cache

2014-07-30 Thread Dave Airlie
from Stephen before. But if you want to work on the kernel, this isn't the way to do it, and nobody will ever take a patch from you seriously if you continue in this fashion. Dave. -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body of a message to majord

Re: [PATCH] Remove certain calls for releasing page cache

2014-07-30 Thread Dave Airlie
On 31 July 2014 12:05, Nick Krause xerofo...@gmail.com wrote: On Wed, Jul 30, 2014 at 7:30 PM, Dave Airlie airl...@gmail.com wrote: This patch removes the lines for releasing the page cache in certain files as this may aid in perfomance with writes in the compression rountines of btrfs. Please

Re: btrfs kernel workqueues performance regression

2014-07-22 Thread Dave Chinner
+ 0.33% [kernel] [k] do_raw_write_lock + 0.30% [kernel] [k] btrfs_clear_lock_blocking_rw + 0.29% [kernel] [k] btrfs_tree_read_lock All the CPU time is basically spend in locking functions. Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line

Re: [PATCH] xfstests/btrfs: add test for quota groups and drop snapshot

2014-07-10 Thread Dave Chinner
On Thu, Jul 10, 2014 at 10:36:14AM -0700, Mark Fasheh wrote: Hey Dave, thanks for the patch review! Pretty much all of what you wrote sounds good to me, there's just one or two items I wanted to clarify - those comments are inline. Thanks again, On Thu, Jul 10, 2014 at 10:43:30AM +1000, Dave

Re: [PATCH] xfstests/btrfs: add test for quota groups and drop snapshot

2014-07-09 Thread Dave Chinner
a couple of minutes, so it should not be in the quick group. Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH] generic/017: skip invalid block sizes for btrfs

2014-06-23 Thread Dave Chinner
/MOUNT_OPTIONS), or it specifically defines the configuration it is testing. Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH v3] xfstests/btrfs: add qgroup rescan stress test

2014-06-18 Thread Dave Chinner
On Wed, Jun 18, 2014 at 04:36:22PM +0800, Wang Shilong wrote: Hello Josef, The lastest Qgroup code still break this test sometimes. Ps: this test seems not merging into xfstests. Then repost it to fste...@vger.kernel.org. Sometimes patches get missed... Cheers, Dave. -- Dave Chinner da

Re: [systemd-devel] Slow startup of systemd-journal on BTRFS

2014-06-18 Thread Dave Chinner
to fragmentation in most cases. The current problems seem to be with the way btrfs does rewrites, not the use of fallocate() in systemd. Thanks for explanation, Lennart. Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-btrfs

Re: Slow startup of systemd-journal on BTRFS

2014-06-11 Thread Dave Chinner
this a filesystem problem and so refused to change the systemd code to be nice to the filesystem allocators, even though they don't actually need to use fallocate... Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-btrfs

Re: Slow startup of systemd-journal on BTRFS

2014-06-11 Thread Dave Chinner
On Thu, Jun 12, 2014 at 11:21:04AM +1000, Dave Chinner wrote: On Wed, Jun 11, 2014 at 11:28:54PM +0200, Goffredo Baroncelli wrote: Hi all, I would like to share a my experience about a slowness of systemd when used on BTRFS. My boot time was very high (about ~50 seconds); most

Re: [PATCH] btrfs: add regression test for remount with thread_pool resized

2014-06-09 Thread Dave Chinner
of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH v5] xfstests: add test for btrfs cloning with file holes

2014-06-09 Thread Dave Chinner
the same style as many of the other tests use for compound operations like this. Other than that the test look sgood. Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body of a message to majord...@vger.kernel.org

Re: [PATCH v2] xfstests: add test for btrfs clone + fsync durability

2014-06-09 Thread Dave Chinner
before ;) Use the -s option to xfs_io rather than repeated pwrite/fsync pairs. Otherwise looks fine. Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body of a message to majord...@vger.kernel.org More majordomo

Re: [RFC 00/32] making inode time stamps y2038 ready

2014-06-03 Thread Dave Chinner
to be independent of the physical filesystem time encoding Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[ANNOUNCE] xfstests: master branch updated to 45d1fac

2014-05-26 Thread Dave Chinner
mode 100755 tests/generic/027 create mode 100644 tests/generic/027.out -- Dave Chinner da...@fromorbit.com signature.asc Description: Digital signature

Re: [ANNOUNCE] xfstests: new mailing list

2014-05-19 Thread Dave Chinner
On Mon, May 19, 2014 at 07:55:41AM -0700, Christoph Hellwig wrote: On Sat, May 17, 2014 at 08:19:30AM +1000, Dave Chinner wrote: Renaming the test suite take a lot more work - .e.g renaming/moving source trees and a fixing all the documentation that points to it... In that case please call

Re: [ANNOUNCE] xfstests: new mailing list

2014-05-16 Thread Dave Chinner
all the documentation that points to it... So, small steps. Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

[ANNOUNCE] xfstests: new mailing list

2014-05-15 Thread Dave Chinner
through marc.info), but that should be set up real soon. I'll still be listening in on the XFS list for xfstests patches, bug reports and questions, so don't worry if you forget this new list exists... :) Cheers, Dave. -- Dave Chinner da...@fromorbit.com signature.asc Description: Digital

[ANNOUNCE] xfstests: master branch updated to 10fd79a

2014-05-13 Thread Dave Chinner
/xfs/013 create mode 100644 tests/xfs/013.out -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[ANNOUNCE] xfstests: master branch updated to ce0aa2b

2014-04-27 Thread Dave Chinner
in the next update. The new head of the master branch is commit: ce0aa2b common: Use _require_xfs_io_command() instead of helpers New Commits: Dave Chinner (6): [31a50c7] generic/204: tweak reserve pool size [ca93123] generic: cleanup space after test in TESTDIR [9d7807d] xfs: remove

<    1   2   3   4   5   6   7   >