Re: [BULK] Re: [PATCH] xfstests 311: test fsync with dm flakey V2

2013-04-26 Thread Dave Chinner
On Fri, Apr 26, 2013 at 03:31:01PM -0400, Josef Bacik wrote: On Thu, Apr 25, 2013 at 08:12:14PM -0600, Dave Chinner wrote: Ok so I think I'll just make this test do all the iterations of the fsync tester with and without --nolockfs, since without --nolockfs I'm still seeing problems

Re: [BULK] Re: [PATCH] xfstests 311: test fsync with dm flakey V2

2013-04-26 Thread Dave Chinner
On Fri, Apr 26, 2013 at 06:32:14PM -0400, Josef Bacik wrote: On Fri, Apr 26, 2013 at 04:05:22PM -0600, Dave Chinner wrote: On Fri, Apr 26, 2013 at 03:31:01PM -0400, Josef Bacik wrote: On Thu, Apr 25, 2013 at 08:12:14PM -0600, Dave Chinner wrote: Ok so I think I'll just make this test do

Re: [PATCH] xfstests 311: test fsync with dm flakey V2

2013-04-25 Thread Dave Chinner
group would be appropriate if it takes less than a minute. Also, fsync tests fall under the category of metadata and log, so they probably should be added, too. Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body

Re: [BULK] Re: [PATCH] xfstests 311: test fsync with dm flakey V2

2013-04-25 Thread Dave Chinner
On Thu, Apr 25, 2013 at 08:24:04PM -0400, Josef Bacik wrote: On Thu, Apr 25, 2013 at 04:45:56PM -0600, Dave Chinner wrote: On Thu, Apr 25, 2013 at 10:12:56AM -0400, Josef Bacik wrote: . + $here/src/fsync-tester -s $SEED -r -t $test_num $extra $testfile + if [ $? -ne 0

Re: [BULK] Re: [PATCH] xfstests 311: test fsync with dm flakey V2

2013-04-25 Thread Dave Chinner
On Thu, Apr 25, 2013 at 09:32:37PM -0400, Josef Bacik wrote: On Thu, Apr 25, 2013 at 07:08:29PM -0600, Dave Chinner wrote: On Thu, Apr 25, 2013 at 08:24:04PM -0400, Josef Bacik wrote: On Thu, Apr 25, 2013 at 04:45:56PM -0600, Dave Chinner wrote: On Thu, Apr 25, 2013 at 10:12:56AM -0400

Re: Announce re-factor all current xfstests patches request

2013-03-27 Thread Dave Chinner
can start using names rather then sequence numbers for tests. Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: Announce re-factor all current xfstests patches request

2013-03-27 Thread Dave Chinner
a central assignment perspective)? Support for named tests have not yet been added. From the check script: SUPPORTED_TESTS=[0-9][0-9][0-9] [0-9][0-9][0-9][0-9] Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body

Re: Announce re-factor all current xfstests patches request

2013-03-27 Thread Dave Chinner
the lsqa.pl script be able to take a directory argument, and just use the script to get the description Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body of a message to majord...@vger.kernel.org More majordomo

Re: Announce re-factor all current xfstests patches request

2013-03-27 Thread Dave Chinner
On Wed, Mar 27, 2013 at 05:48:04PM -0400, Theodore Ts'o wrote: On Thu, Mar 28, 2013 at 07:54:07AM +1100, Dave Chinner wrote: Support for named tests have not yet been added. From the check script: SUPPORTED_TESTS=[0-9][0-9][0-9] [0-9][0-9][0-9][0-9] Ah, I thought support for named

Re: [PATCH] xfstests: add background noise to test 276 (btrfs backref resolving)

2013-03-19 Thread Dave Chinner
is to use a common.blah file to do it. However, using test templates is the way I want to do it in future - it will be perfect for these sorts of test variations: http://oss.sgi.com/archives/xfs/2013-03/msg00578.html Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list

Re: [PATCH 3/3 V4] xfstests: btrfs tests for basic informational commands

2013-03-15 Thread Dave Chinner
: +# get standard environment, filters and checks +. ./common.rc +. ./btrfs.filter That should probably have been named common.filter.btrfs. I found this updating my patchset that moves all the common.* files into a common/ directory I'll rename it to common/filter.btrfs Cheers, Dave

Re: xfstests: 301: sparse copy between different filesystems/mountpoints on btrfs

2013-03-10 Thread Dave Chinner
harness expects TEST_DEV to be mounted on TEST_DIR, not anywhere else. If you need multiple scratch filesystems to test cross-device linkage errors, use loopback devices or make use of the btrfs scratch device pool... Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from

[PATCH V7 -next 25/33] btrfs: add support for read_iter and write_iter

2013-03-08 Thread Dave Kleikamp
btrfs can use generic_file_read_iter(). Base btrfs_file_write_iter() on btrfs_file_aio_write(), then have the latter call the former. Signed-off-by: Dave Kleikamp dave.kleik...@oracle.com Cc: Zach Brown z...@zabbo.net Cc: Chris Mason chris.ma...@fusionio.com Cc: linux-btrfs@vger.kernel.org

Re: [PATCH] Btrfs: add a incompatible format change for smaller metadata extent refs

2013-03-07 Thread Dave Chinner
in the wild, there will still be people using it 10 years later. IOWs, you'll probably never be able to delete the old code Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body of a message to majord...@vger.kernel.org

Re: [PATCH] xfstests 276: fix error 'FIBMAP: Invalid argument'

2013-02-27 Thread Dave Chinner
is in the commit description? Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] xfstests 276: fix error 'FIBMAP: Invalid argument'

2013-02-27 Thread Dave Chinner
On Thu, Feb 28, 2013 at 08:02:52AM +0800, Wang Sheng-Hui wrote: On 2013年02月28日 07:04, Dave Chinner wrote: On Wed, Feb 27, 2013 at 03:15:16PM +0800, Wang Sheng-Hui wrote: Btrfs doesn't support FIEMAP_FLAG_XATTR, which is enabled by -x option of filefrag, and will fail with 'FIBMAP: Invalid

btrfs crash when low on memory.

2013-02-26 Thread Dave Jones
} Dave -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH, RFC] btrfs-progs: require mkfs -f force option to overwrite filesystem or partition table

2013-02-25 Thread Dave Chinner
be an acceptable answer. Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [Tests] xfs test[298]: Btrfs Quota testing

2013-02-22 Thread Dave Chinner
subvolume '/test/vol1' +vol1 created +0/257 4096 4096 +qgroup limited to 2mb +dd: writing ‘/test/vol1/file1’: Disk quota exceeded You've got environment specific characters in your output. Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe

Re: [btrfs-progs] testing btrfs hierarchical quotas

2013-02-15 Thread Dave Chinner
Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] xfs_mkfs: wipe old signatures from the device

2013-02-14 Thread Dave Chinner
On Thu, Feb 14, 2013 at 09:36:38AM +0100, Lukáš Czerner wrote: On Thu, 14 Feb 2013, Chris Murphy wrote: Date: Thu, 14 Feb 2013 00:29:59 -0700 From: Chris Murphy li...@colorremedies.com To: Dave Chinner da...@fromorbit.com Cc: Karel Zak k...@redhat.com, Lukáš Czerner lczer...@redhat.com

Re: [PATCH] fs: encode_fh: return FILEID_INVALID if invalid fid_type

2013-02-11 Thread Dave Chinner
; /* invalid */ + return FILEID_INVALID; /* invalid */ } I think you can drop the /* invalid */ comment from there now as it is redundant with this change. Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body

[PATCH V6 23/30] btrfs: add support for read_iter and write_iter

2013-01-29 Thread Dave Kleikamp
btrfs can use generic_file_read_iter(). Base btrfs_file_write_iter() on btrfs_file_aio_write(), then have the latter call the former. Signed-off-by: Dave Kleikamp dave.kleik...@oracle.com Cc: Zach Brown z...@zabbo.net Cc: Chris Mason chris.ma...@fusionio.com Cc: linux-btrfs@vger.kernel.org

Re: [PATCH 4/4] fs: remove obsolete simple_strtofoo

2012-12-12 Thread Dave Chinner
On Fri, Dec 07, 2012 at 05:25:19PM +0530, Abhijit Pawar wrote: This patch replace the obsolete simple_strtofoo with kstrtofoo The XFS changes look fine. Consider those: Acked-by: Dave Chinner dchin...@redhat.com -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send

[PATCH v4 24/31] btrfs: add support for read_iter and write_iter

2012-11-22 Thread Dave Kleikamp
btrfs can use generic_file_read_iter(). Base btrfs_file_write_iter() on btrfs_file_aio_write(), then have the latter call the former. Signed-off-by: Dave Kleikamp dave.kleik...@oracle.com Cc: Zach Brown z...@zabbo.net Cc: Chris Mason chris.ma...@fusionio.com Cc: linux-btrfs@vger.kernel.org

Re: (late) REQUEST: Default mkfs.btrfs block size

2012-11-07 Thread Dave Chinner
to most questions about what is optimal?. i.e: http://xfs.org/index.php/XFS_FAQ#Q:_I_want_to_tune_my_XFS_filesystems_for_.3Csomething.3E Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body of a message to majord

Re: [PATCH] xfs: add hot tracking support.

2012-11-07 Thread Dave Chinner
On Wed, Nov 07, 2012 at 04:38:23PM +0800, Zhi Yong Wu wrote: HI, Dave, I guess that you should add some hot tracking stuff in some xfs_show_xxx function, right? Yes, it should - I thought I did that. I recall seeing int /proc/mounts, but maybe I was just hallucinating. I'll send an updated

Re: [RFC v4 03/15] vfs,hot_track: add the function for collecting I/O frequency

2012-10-28 Thread Dave Chinner
to update access frequency from read/writepage(s) hooks + */ +inline void hot_update_freqs(struct inode *inode, u64 start, + u64 len, int rw) This function seems too big. So we really need to inline this function? As Dave said in his comments, it will add a function call

[PATCH 21/22] btrfs: add support for read_iter and write_iter

2012-10-22 Thread Dave Kleikamp
btrfs can use generic_file_read_iter(). Base btrfs_file_write_iter() on btrfs_file_aio_write(), then have the latter call the former. Signed-off-by: Dave Kleikamp dave.kleik...@oracle.com Cc: Zach Brown z...@zabbo.net Cc: Chris Mason chris.ma...@oracle.com Cc: linux-btrfs@vger.kernel.org --- fs

Re: [RFC v3 00/13] vfs: hot data tracking

2012-10-17 Thread Dave Chinner
On Wed, Oct 17, 2012 at 04:57:14PM +0800, Zhi Yong Wu wrote: On Tue, Oct 16, 2012 at 4:42 AM, Dave Chinner da...@fromorbit.com wrote: On Wed, Oct 10, 2012 at 06:07:22PM +0800, zwu.ker...@gmail.com wrote: From: Zhi Yong Wu wu...@linux.vnet.ibm.com (*) Tested on an empty 17TB XFS

Re: [RFC v3 00/13] vfs: hot data tracking

2012-10-17 Thread Dave Chinner
On Thu, Oct 18, 2012 at 12:44:47PM +0800, Zhi Yong Wu wrote: On Thu, Oct 18, 2012 at 12:29 PM, Dave Chinner da...@fromorbit.com wrote: On Wed, Oct 17, 2012 at 04:57:14PM +0800, Zhi Yong Wu wrote: On Tue, Oct 16, 2012 at 4:42 AM, Dave Chinner da...@fromorbit.com wrote: On Wed, Oct 10, 2012

Re: [RFC v3 11/13] vfs: add 3 new ioctl interfaces

2012-10-15 Thread Dave Chinner
; + char filename[PATH_MAX]; Don't put the filename in the ioctl and open the file in the kernel. Have userspace open the file directly and issue the ioctl on the fd that is returned. Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line

Re: [RFC v3 12/13] vfs: add debugfs support

2012-10-15 Thread Dave Chinner
what files users are accessing from this information. Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFC v3 12/13] vfs: add debugfs support

2012-10-15 Thread Dave Chinner
/seq_operations constructs? Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFC v3 00/13] vfs: hot data tracking

2012-10-15 Thread Dave Chinner
update that slabtop got, so it is indicative of the impending OOM situation that occurred. Changelog from v2: 1.) Converted to Radix trees, not RB-tree [Zhiyong, Dave Chinner] 2.) Added memory shrinker [Dave Chinner] I haven't looked at the shrinker, but clearly it is not working, otherwise

[PATCH] xfs: add hot tracking support.

2012-10-15 Thread Dave Chinner
From: Dave Chinner dchin...@redhat.com Connect up the VFS hot tracking support so XFS filesystems can make use of it. Signed-off-by: Dave Chinner dchin...@redhat.com --- fs/xfs/xfs_mount.h |1 + fs/xfs/xfs_super.c |9 + 2 files changed, 10 insertions(+) diff --git a/fs/xfs

Re: [RFC v3 00/13] vfs: hot data tracking

2012-10-15 Thread Dave Chinner
[ 200.064574] [81b765c0] ? gs_change+0x13/0x13 Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFC v3 11/13] vfs: add 3 new ioctl interfaces

2012-10-15 Thread Dave Chinner
can't see how this is a manageable interface. It is not persistent, so after every filesystem mount you'd have to set the flag on all your inodes again. Hence, for the moment, I'd suggest that dropping per-inode tracking control until all the core issues are sorted out Cheers, Dave. -- Dave

Re: [RFC v2 05/10] vfs: introduce one hash table

2012-09-27 Thread Dave Chinner
On Thu, Sep 27, 2012 at 02:23:16PM +0800, Zhi Yong Wu wrote: On Thu, Sep 27, 2012 at 11:43 AM, Dave Chinner da...@fromorbit.com wrote: On Sun, Sep 23, 2012 at 08:56:30PM +0800, zwu.ker...@gmail.com wrote: From: Zhi Yong Wu wu...@linux.vnet.ibm.com Adds a hash table structure which

Re: [RFC v2 06/10] vfs: enable hot data tracking

2012-09-27 Thread Dave Chinner
On Thu, Sep 27, 2012 at 02:28:12PM +0800, Zhi Yong Wu wrote: On Thu, Sep 27, 2012 at 11:54 AM, Dave Chinner da...@fromorbit.com wrote: On Sun, Sep 23, 2012 at 08:56:31PM +0800, zwu.ker...@gmail.com wrote: From: Zhi Yong Wu wu...@linux.vnet.ibm.com Miscellaneous features that implement

Re: [RFC v2 07/10] vfs: fork one kthread to update data temperature

2012-09-27 Thread Dave Chinner
On Thu, Sep 27, 2012 at 02:54:22PM +0800, Zhi Yong Wu wrote: On Thu, Sep 27, 2012 at 12:03 PM, Dave Chinner da...@fromorbit.com wrote: On Sun, Sep 23, 2012 at 08:56:32PM +0800, zwu.ker...@gmail.com wrote: From: Zhi Yong Wu wu...@linux.vnet.ibm.com Fork and run one kernel kthread

Re: [RFC v2 03/10] vfs: add one new mount option '-o hottrack'

2012-09-27 Thread Dave Chinner
On Thu, Sep 27, 2012 at 01:25:34PM +0800, Zhi Yong Wu wrote: On Tue, Sep 25, 2012 at 5:28 PM, Dave Chinner da...@fromorbit.com wrote: On Sun, Sep 23, 2012 at 08:56:28PM +0800, zwu.ker...@gmail.com wrote: From: Zhi Yong Wu wu...@linux.vnet.ibm.com Introduce one new mount option '-o

Re: [RFC v2 03/10] vfs: add one new mount option '-o hottrack'

2012-09-26 Thread Dave Chinner
On Wed, Sep 26, 2012 at 10:56:08AM +0800, Zhi Yong Wu wrote: On Tue, Sep 25, 2012 at 5:28 PM, Dave Chinner da...@fromorbit.com wrote: On Sun, Sep 23, 2012 at 08:56:28PM +0800, zwu.ker...@gmail.com wrote: From: Zhi Yong Wu wu...@linux.vnet.ibm.com Introduce one new mount option '-o

Re: [RFC v2 02/10] vfs: add support for updating access frequency

2012-09-26 Thread Dave Chinner
On Wed, Sep 26, 2012 at 10:53:07AM +0800, Zhi Yong Wu wrote: On Tue, Sep 25, 2012 at 5:17 PM, Dave Chinner da...@fromorbit.com wrote: On Sun, Sep 23, 2012 at 08:56:27PM +0800, zwu.ker...@gmail.com wrote: I note that the code will always insert range items of a length RANGE_SIZE. This means

Re: [RFC v2 04/10] vfs: add init and exit support

2012-09-26 Thread Dave Chinner
); And call this in .fill_super() after parsing the hottrack argument. Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [RFC v2 05/10] vfs: introduce one hash table

2012-09-26 Thread Dave Chinner
. HEAT_MAP_SIZE, not HASH_SIZE. As it is, there aren't any users of the heat maps that are generated in this patch set - it's not even exported to userspace or to debugfs, so I'm not sure how it will be used yet. How are these heat maps going to be used by filesystems, Zhi? Cheers, Dave. -- Dave Chinner da

Re: [RFC v2 06/10] vfs: enable hot data tracking

2012-09-26 Thread Dave Chinner
writes or fsync-triggered writes, are are far more likely to be to hot ranges in a file... Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [RFC v2 07/10] vfs: fork one kthread to update data temperature

2012-09-26 Thread Dave Chinner
comments earlier in the series, there's not a lot of point in me spending time commenting on ethe code in detail here as it will change significantly as a result of all the earlier comments Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line

Re: [RFC v2 01/10] vfs: introduce private rb structures

2012-09-25 Thread Dave Chinner
that keeps track of fs-wide hot data */ + struct hot_inode_tree hot_inode_tree; +}; The comment is redundant... Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body of a message to majord...@vger.kernel.org

Re: [RFC v2 02/10] vfs: add support for updating access frequency

2012-09-25 Thread Dave Chinner
/hot_tracking.h, so you shouldn't need these forward declarations... Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [RFC v2 03/10] vfs: add one new mount option '-o hottrack'

2012-09-25 Thread Dave Chinner
or not. This then means the hot inode tracking for the superblock can be initialised by the filesystem as part of it's fill_super method, along with the filesystem specific code that will use the hot tracking information the VFS gathers Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from

Re: [PATCH 3/3] xfstests: fix wrong number of the required devices and add independent device check for case 265

2012-08-23 Thread Dave Chinner
to _require_scratch_dev_pool. Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Re: [PATCH 0/8] Set bi_rw when alloc bio before call bio_add_page.

2012-07-30 Thread Dave Chinner
On Tue, Jul 31, 2012 at 08:55:59AM +0800, majianpeng wrote: On 2012-07-31 05:42 Dave Chinner da...@fromorbit.com Wrote: On Mon, Jul 30, 2012 at 03:14:28PM +0800, majianpeng wrote: When exec bio_alloc, the bi_rw is zero.But after calling bio_add_page, it will use bi_rw. Fox example

Re: [PATCH] Xfstests/254: add more cases for testing btrfs snapshot in 254

2012-07-19 Thread Dave Chinner
it is easy to tell the difference between a new failure and regression. Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: BTRFS fsck apparent errors

2012-07-03 Thread Dave Chinner
stale metadata and bad things will happen. That's why it's called dangerous. ;) Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH 1/4] vfs: introduce try_to_writeback_inodes_sb(_nr)

2012-04-25 Thread Dave Chinner
]_sb_if_idle() with a trylock and use that. Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: btrfs io errors on 3.4rc1

2012-04-03 Thread Dave Jones
On Tue, Apr 03, 2012 at 04:26:07PM +0200, David Sterba wrote: On Mon, Apr 02, 2012 at 09:47:22PM -0400, Dave Jones wrote: 49b25e0540904be0bf558b84475c69d72e4de66e is the first bad commit btrfs: enhance transaction abort infrastructure Attached patch adds several debugging printks

Re: btrfs io errors on 3.4rc1

2012-04-03 Thread Dave Jones
On Tue, Apr 03, 2012 at 06:33:43PM +0200, David Sterba wrote: On Tue, Apr 03, 2012 at 12:20:23PM -0400, Dave Jones wrote: I see a lot of these .. btrfs: __btrfs_end_transaction -EIO abored=1802201963 (no super error) 1802201963 == 0x6b6b6b6b #define POISON_FREE 0x6b

Re: btrfs io errors on 3.4rc1

2012-04-03 Thread Dave Jones
On Tue, Apr 03, 2012 at 12:50:55PM -0400, Dave Jones wrote: On Tue, Apr 03, 2012 at 06:33:43PM +0200, David Sterba wrote: On Tue, Apr 03, 2012 at 12:20:23PM -0400, Dave Jones wrote: I see a lot of these .. btrfs: __btrfs_end_transaction -EIO abored=1802201963 (no super error

Re: btrfs io errors on 3.4rc1

2012-04-03 Thread Dave Jones
On Tue, Apr 03, 2012 at 01:07:50PM -0400, Dave Jones wrote: wait, what... 535 memset(trans, 0, sizeof(*trans)); 536 kmem_cache_free(btrfs_trans_handle_cachep, trans); 537 538 if (throttle) 539 btrfs_run_delayed_iputs(root

3.4rc1 btrfs IO problem ?

2012-04-02 Thread Dave Jones
? Dave -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

btrfs io errors on 3.4rc1

2012-04-02 Thread Dave Jones
Segmentation fault (core dumped) tried to send this email.. collect: Cannot write ./dfq32HpM1C010652 (fsync, uid=1000, gid=51): Input/output error Error writing control file ./qfq32HpM1C010652: Input/output error 3.3 is fine. Dave -- To unsubscribe from this list: send the line unsubscribe

Re: btrfs io errors on 3.4rc1

2012-04-02 Thread Dave Jones
On Mon, Apr 02, 2012 at 03:48:14PM -0400, Chris Mason wrote: On Mon, Apr 02, 2012 at 02:02:14PM -0400, Dave Jones wrote: Updated to rc1 this morning, and my machines with btrfs are all freaking out.. I got this from my cron email .. /etc/cron.daily/prelink: line 41: /var/lib

Re: btrfs io errors on 3.4rc1

2012-04-02 Thread Dave Jones
On Mon, Apr 02, 2012 at 05:26:08PM -0400, Chris Mason wrote: On Mon, Apr 02, 2012 at 05:16:22PM -0400, Dave Jones wrote: On Mon, Apr 02, 2012 at 03:48:14PM -0400, Chris Mason wrote: On Mon, Apr 02, 2012 at 02:02:14PM -0400, Dave Jones wrote: Updated to rc1 this morning, and my

Re: btrfs io errors on 3.4rc1

2012-04-02 Thread Dave Jones
if it'll potentially make things worse.. Dave -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: btrfs io errors on 3.4rc1

2012-04-02 Thread Dave Jones
On Mon, Apr 02, 2012 at 06:39:19PM -0400, Chris Mason wrote: On Mon, Apr 02, 2012 at 06:33:50PM -0400, Dave Jones wrote: On Mon, Apr 02, 2012 at 06:28:02PM -0400, Chris Mason wrote: x86-64. dmesg below. (ignore the rpc oops, reported elsewhere, it's unrelated

Re: btrfs io errors on 3.4rc1

2012-04-02 Thread Dave Jones
On Mon, Apr 02, 2012 at 07:50:50PM -0400, Chris Mason wrote: I'll start a bisect later to see if I can narrow it down at least. Ok, a directed bisect of the major suspects. Josef changed the extent buffer eio code in this commit (jump to the commit before it): I had already started

[RFC PATCH v2 09/21] dio: Convert direct_IO to use iov_iter

2012-03-30 Thread Dave Kleikamp
Change the direct_IO aop to take an iov_iter argument rather than an iovec. This will get passed down through most filesystems so that only the __blockdev_direct_IO helper need be aware of whether user or kernel memory is being passed to the function. Signed-off-by: Dave Kleikamp dave.kleik

[RFC PATCH v2 20/21] btrfs: add support for read_iter and write_iter

2012-03-30 Thread Dave Kleikamp
btrfs can use generic_file_read_iter(). Base btrfs_file_write_iter() on btrfs_file_aio_write(), then have the latter call the former. Signed-off-by: Dave Kleikamp dave.kleik...@oracle.com Cc: Zach Brown z...@zabbo.net Cc: Chris Mason chris.ma...@oracle.com Cc: linux-btrfs@vger.kernel.org --- fs

Re: [RFC PATCH 2/2] Btrfs: fix deadlock on umount by umount_prepare interface

2012-03-21 Thread Dave Chinner
has happened. Every time a deadlock involving writeback_inodes_sb...if_idle() comes up, I give the same response. If the s_umount is write locked, then the sb is not idle. IOWs, writeback_inodes_sb...if_idle() should be doing down_read_trylock(), not down_read(). Cheers, Dave. -- Dave Chinner

[RFC PATCH 21/22] btrfs: add support for read_iter, write_iter, and direct_IO_bvec

2012-02-27 Thread Dave Kleikamp
Some helpers were broken out of btrfs_direct_IO() in order to avoid code duplication in new bio_vec-based function. Signed-off-by: Dave Kleikamp dave.kleik...@oracle.com Cc: Zach Brown z...@zabbo.net Cc: Chris Mason chris.ma...@oracle.com Cc: linux-btrfs@vger.kernel.org --- fs/btrfs/file.c

Re: Please help me solving BTRFS failure

2012-02-13 Thread Dave
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On Mon, Feb 13, 2012 at 04:58:01PM +0300, Private Inf wrote: Hello Dave, According to this threadhttp://www.mail-archive.com/linux-btrfs@vger.kernel.org/msg11548.htmlyou were able to fix your faulty BTRFS. Looks like I have the same problem

Re: [PATCH] Btrfs: return EUCLEAN rather than ENXIO once internal error has occurred for SEEK_DATA/SEEK_HOLE inquiry

2012-02-08 Thread Dave Chinner
if btrfs_get_extent_fiemap() failed due to other issues. This will confuse the user applications to be expecting ENXIO when trying to find a specific data or hole location once it has occurred. Thanks Dave for pointing that out in XFS thread. This patch fix it to return EUCLEAN, or maybe

Re: [RFC PATCH v2 0/3] Btrfs: apply the Probabilistic Skiplist on btrfs

2012-01-12 Thread Dave Chinner
lookups in the XFS buffer cache, but I've got a long list of things to do before I get to it. If someone else implements the tree, that's most of the work done for me. :) Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-btrfs

Re: [3.2-rc7] slowdown, warning + oops creating lots of files

2012-01-05 Thread Dave Chinner
On Thu, Jan 05, 2012 at 02:11:31PM -0500, Liu Bo wrote: On 01/04/2012 09:26 PM, Dave Chinner wrote: On Wed, Jan 04, 2012 at 09:23:18PM -0500, Liu Bo wrote: On 01/04/2012 06:01 PM, Dave Chinner wrote: On Thu, Jan 05, 2012 at 09:23:52AM +1100, Chris Samuel wrote: On 05/01/12 09:11, Dave

Re: [3.2-rc7] slowdown, warning + oops creating lots of files

2012-01-05 Thread Dave Chinner
On Thu, Jan 05, 2012 at 02:45:00PM -0500, Chris Mason wrote: On Thu, Jan 05, 2012 at 01:46:57PM -0500, Chris Mason wrote: On Thu, Jan 05, 2012 at 10:01:22AM +1100, Dave Chinner wrote: On Thu, Jan 05, 2012 at 09:23:52AM +1100, Chris Samuel wrote: On 05/01/12 09:11, Dave Chinner wrote

Re: [3.2-rc7] slowdown, warning + oops creating lots of files

2012-01-04 Thread Dave Chinner
On Thu, Jan 05, 2012 at 08:44:45AM +1100, Dave Chinner wrote: Hi there buttery folks, I just hit this warning and oops running a parallel fs_mark create workload on a test VM using a 17TB btrfs filesystem (12 disk dm RAID0) using default mkfs and mount parmeters, mounted on /mnt/scratch

Re: [3.2-rc7] slowdown, warning + oops creating lots of files

2012-01-04 Thread Dave Chinner
On Thu, Jan 05, 2012 at 09:23:52AM +1100, Chris Samuel wrote: On 05/01/12 09:11, Dave Chinner wrote: Looks to be reproducable. Does this happen with rc6 ? I haven't tried. All I'm doing is running some benchmarks to get numbers for a talk I'm giving about improvements in XFS metadata

Re: [3.2-rc7] slowdown, warning + oops creating lots of files

2012-01-04 Thread Dave Chinner
On Wed, Jan 04, 2012 at 09:23:18PM -0500, Liu Bo wrote: On 01/04/2012 06:01 PM, Dave Chinner wrote: On Thu, Jan 05, 2012 at 09:23:52AM +1100, Chris Samuel wrote: On 05/01/12 09:11, Dave Chinner wrote: Looks to be reproducable. Does this happen with rc6 ? I haven't tried. All I'm

Re: Btrfs: blocked for more than 120 seconds, made worse by 3.2 rc7

2011-12-28 Thread Dave Chinner
, but also appear to be hung waiting on IO completion with MD stuck in make_request()-get_active_stripe(). That, to me, indicates an MD problem. Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body of a message

COW a file from snapshot

2011-12-20 Thread Dave
=always doesn't work (produces the error Invalid cross-device link). Is there a way to recover that file and benefit from COW? - -- - -=[dave]=- Entropy isn't what it used to be. -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) iF4EAREIAAYFAk7wpKUACgkQXM0u5ajNnCgMUQD/Uf0

Re: [PATCH] fs: push file_update_time into -page_mkwrite

2011-12-20 Thread Dave Chinner
, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Unable to mount (or, why not to work late at night).

2011-11-01 Thread Dave
had this happen to me on two occasions. The first time was after a hard reboot. The second was on a totally different machine at a different geographic location, which occurred after nothing more than a reboot. - -- - -=[dave]=- Entropy isn't what it used to be. -BEGIN PGP SIGNATURE

Re: A Plumber???s Wish List for Linux

2011-10-12 Thread Dave Chinner
for XFS filesytems. I.e. clone the filesytem using xfs_copy, then run xfs_admin -U generate clone to generate a new uuid in the cloned copy before you mount the clone Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-btrfs

Re: [PATCH 1/3] 263: Functional test case for the btrfs snapshot

2011-10-12 Thread Dave Chinner
please modify the _populate_fs function to do what you need. Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH 1/4] fs: add SEEK_HOLE and SEEK_DATA flags

2011-08-30 Thread Dave Chinner
clarified first, then the behaviour codified in a single test suite we can call the 'authoritive test'. Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH] xfstests 255: add a seek_data/seek_hole tester

2011-08-30 Thread Dave Chinner
On Tue, Aug 30, 2011 at 06:17:02PM -0700, Sunil Mushran wrote: On 08/25/2011 06:35 PM, Dave Chinner wrote: Agreed, that's the way I'd interpret it, too. So perhaps we need to ensure that this interpretation is actually tested by this test? How about some definitions to work by: Data

Re: [PATCH] xfstests 255: add a seek_data/seek_hole tester

2011-08-25 Thread Dave Chinner
or not and will adjust as necessary. Can you resend this with any updates that happened in the meantime? Dave also still had some comments about semantics, so it might be worth to incorporate that as well. The main questions I had when looking at this was how we should handle unwritten extents - the only answer

Re: [PATCH] xfstests 255: add a seek_data/seek_hole tester

2011-08-25 Thread Dave Chinner
On Thu, Aug 25, 2011 at 12:51:56AM -0600, Andreas Dilger wrote: On 2011-08-25, at 12:40 AM, Dave Chinner wrote: On Thu, Aug 25, 2011 at 02:06:32AM -0400, Christoph Hellwig wrote: On Tue, Jun 28, 2011 at 11:33:19AM -0400, Josef Bacik wrote: This is a test to make sure seek_data/seek_hole

Re: [RFC] btrfs auto snapshot

2011-08-17 Thread Dave
* * * * /usr/local/bin/snapshot hourly 6 0 0 * * * /usr/local/bin/snapshot daily 7 0 0 * * 0 /usr/local/bin/snapshot weekly 4 -- -=[dave]=- Entropy isn't what it used to be. pgp09202hq1TV.pgp Description: PGP signature

Re: Applications using fsync cause hangs for several seconds every few minutes

2011-08-17 Thread Dave
in particular). This behavior goes away after a reboot. I'm running kernel version 3.0. -- -=[dave]=- Entropy isn't what it used to be. pgpGtgOCW3Zae.pgp Description: PGP signature

Re: Honest timeline for btrfsck

2011-08-17 Thread Dave
in the btrfs ecosystem (lack of fsck being the most frequent reason for not trying btrfs). I know I've got two existing instances that I can test this tool on. -- -=[dave]=- Entropy isn't what it used to be. pgpwZXDAxQRKk.pgp Description: PGP signature

Re: [PATCH] snapshot, defragment and raid test cases for btrfs

2011-08-06 Thread Dave Chinner
to understand... Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: disk-io.c:416: find_and_setup_root: Assertion `!(!root-node)' failed.

2011-08-03 Thread Dave
OK so I have recovered all of my data. This was sort of a nerve wrecking experience. I'll share what I've done in case others are experiencing the same problem (I've seen other threads appear complaining of the same assertion which draw no response). So, I filled open_ctree_fd with printf

disk-io.c:416: find_and_setup_root: Assertion `!(!root-node)' failed.

2011-08-02 Thread Dave
A power failure has left me with a broken btrfs. Trying to mount the filesystem with Kernel 3.0 gives me an unrecognized superblock error. btrfs-debug-tree spits out the folowing: parent transid verify failed on 349129785344 wanted 120602 found 120627 parent transid verify failed on

Re: disk-io.c:416: find_and_setup_root: Assertion `!(!root-node)' failed.

2011-08-02 Thread Dave
OK so on further investigation, I can see that btrfs-debug-tree is failing on: ret = find_and_setup_root(tree_root, fs_info, BTRFS_CSUM_TREE_OBJECTID, csum_root); (line 750 or so) But the same call with extent_root and dev_root as arguments are successful. Would this indicate that some branch on

Re: [PATCH] xfstests 255: add a seek_data/seek_hole tester

2011-06-29 Thread Dave Chinner
regions of those states as well, right? Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 4/8] fs: kill i_alloc_sem

2011-06-20 Thread Dave Chinner
); Modification of inode-i_state is not safe outside the inode-i_lock. This probably needs to be implemented similar to the __I_NEW/__wait_on_freeing_inode() and __I_SYNC/inode_wait_for_writeback() pattern... Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list

[BUG 3.0-rc1] oops during file removal, severe lock contention

2011-06-01 Thread Dave Chinner
, performance on this create workload my test box is roughly 45k creates/s for btrfs, 75k creates/s for ext4 and 110k create/s for XFS. btrfs is without doubt being slowed down by the lock contention problems Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send

Re: [PATCH 1/2] fs: add a DCACHE_NEED_LOOKUP flag for d_flags

2011-05-20 Thread Dave Chinner
dentries. That way the sb generating them all would self-limit without greatly affecting the working set of dentries on other filesystems... Cheers, Dave. -- Dave Chinner da...@fromorbit.com -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body of a message to majord

<    1   2   3   4   5   6   7   >