On 2016-10-24 19:05 +0200, David Sterba wrote:
>
> Ok that's better, just the signed-off-by line is missing. I would add it
> myself on behalf of contributors I know, but as a matter of practice,
> fix it please and resend the patch. Using the "git commit -s" adds the
> line for you.
>
I added
-by: Domagoj Tršan <domagoj.tr...@gmail.com>
---
fs/btrfs/disk-io.c | 2 +-
fs/btrfs/disk-io.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c
index 50bed6c..95bd34f 100644
--- a/fs/btrfs/disk-io.c
+++ b/fs/btrfs/disk-io.c
@@ -273,7 +273,7
On 2016-10-12 16:43 +0200, David Sterba wrote:
> On Mon, Sep 19, 2016 at 07:22:28PM +0200, David Sterba wrote:
> > On Sun, Sep 18, 2016 at 12:10:34AM +0100, Domagoj Tršan wrote:
> > > csum member of struct btrfs_super_block has array type of u8. It makes
> > >
csum member of struct btrfs_super_block has array type of u8. It makes sense
that function btrfs_csum_final should be also declared to accept u8 *. I
changed the declaration of method void btrfs_csum_final(u32 crc, char *result);
to void btrfs_csum_final(u32 crc, u8 *result);
---
---
fs/btrfs/disk-io.c | 2 +-
fs/btrfs/disk-io.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c
index 50bed6c..95bd34f 100644
--- a/fs/btrfs/disk-io.c
+++ b/fs/btrfs/disk-io.c
@@ -273,7 +273,7 @@ u32 btrfs_csum_data(char *data, u32
csum member of struct btrfs_super_block has array type of u8. It makes sense
that function btrfs_csum_final should be also declared to accept u8 *. I
changed the declaration of method void btrfs_csum_final(u32 crc, char *result);
to void btrfs_csum_final(u32 crc, u8 *result);
Domagoj Tršan (1
Signed-off-by: Domagoj Tršan <domagoj.tr...@gmail.com>
---
btrfs-image.c | 2 +-
chunk-recover.c | 2 +-
cmds-check.c | 2 +-
cmds-inspect-dump-super.c | 2 +-
disk-io.c | 10 +-
disk-io.h | 2 +-
file-
definitions of various csum variables to be consistent with
kernel code. In kernel code they are defined as u8 result[BTRFS_CSUM_SIZE] but
here was as char result[BTRFS_CSUM_SIZE].
Domagoj Tršan (1):
btrfs-progs: change btrfs_csum_final result param type to u8
btrfs-image.c | 2
