Re: [PATCH 00/42] v7: separate operations from flags in the bio/request structs

2016-05-04 Thread Jeff Moyer
Mike Christie <mchri...@redhat.com> writes: > On 05/03/2016 03:44 PM, Jeff Moyer wrote: >> Hi, Mike, >> >> That git tree doesn't seem to exist. I did manage to apply your patch >> set on top of next-20160415, though. >> >> So... what testing did

Re: [PATCH 00/42] v7: separate operations from flags in the bio/request structs

2016-05-03 Thread Jeff Moyer
mchri...@redhat.com writes: > The following patches begin to cleanup the request->cmd_flags and > bio->bi_rw mess. We currently use cmd_flags to specify the operation, > attributes and state of the request. For bi_rw we use it for similar > info and also the priority but then also have another

Re: ext4 vs btrfs performance on SSD array

2014-09-05 Thread Jeff Moyer
Christoph Hellwig h...@infradead.org writes: On Wed, Sep 03, 2014 at 10:01:58AM +1000, NeilBrown wrote: Do we still need maximums at all? I don't think we do. At least on any system I work with I have to increase them to get good performance without any adverse effect on throttling. So

Re: [patch 05/10] vfs: pass data to alloc_inode super operation

2012-10-31 Thread Jeff Moyer
Al Viro v...@zeniv.linux.org.uk writes: On Tue, Oct 30, 2012 at 08:51:42PM +, Al Viro wrote: On Tue, Oct 30, 2012 at 04:14:39PM -0400, Jeff Moyer wrote: This patch passes a data pointer along to the alloc_inode super_operations function. The value will initially be used

[patch 05/10] vfs: pass data to alloc_inode super operation

2012-10-30 Thread Jeff Moyer
This patch passes a data pointer along to the alloc_inode super_operations function. The value will initially be used by bdev_alloc_inode to allocate the bdev_inode on the same numa node as the device to which it is tied. Signed-off-by: Jeff Moyer jmo...@redhat.com --- fs/afs/super.c

Re: [PATCH 0/4] Generic O_SYNC AIO DIO handling

2012-02-10 Thread Jeff Moyer
Jan Kara j...@suse.cz writes: Hi Jeff, these patches implement generic way of handling O_SYNC AIO DIO. They work for all filesystems except for ext4 and xfs. Thus together with your patches, all filesystems should handle O_SYNC AIO DIO correctly. I've tested ext3, btrfs, and xfs (to

Re: [PATCH v2 0/5] add new ioctls to do metadata readahead in btrfs

2011-01-04 Thread Jeff Moyer
Shaohua Li shaohua...@intel.com writes: Hi, We have file readahead to do asyn file read, but has no metadata readahead. For a list of files, their metadata is stored in fragmented disk space and metadata read is a sync operation, which impacts the efficiency of readahead much. The patches

Re: PATCH 3/6 - direct-io: do not merge logically non-contiguous requests

2010-08-11 Thread Jeff Moyer
Josef Bacik jo...@redhat.com writes: So say blocksize of 4k, we do dio to 12k, the first time around dio-block_in_file is 0, we set dio-cur_page, and move on to the next page, and bio-block_in_file is set to 1. We find that dio-cur_page is set, so we do dio_send_cur_page(). Since !dio-bio

Re: [PATCH] fs: make sure to invalidate pages if we fall back on buffered reads

2010-06-11 Thread Jeff Moyer
sake. Thanks, This looks right to me. You definitely don't want to fill up the page cache from direct I/O. Reviewed-by: Jeff Moyer jmo...@redhat.com Signed-off-by: Josef Bacik jo...@redhat.com --- mm/filemap.c |9 - 1 files changed, 8 insertions(+), 1 deletions(-) diff --git