Re: [PATCH] btrfs-progs: change mans to describe the third copy of superblock

At Thu, 19 Oct 2017 17:05:18 +0800, Qu Wenruo wrote: > > > > On 2017年10月19日 16:34, Misono, Tomohiro wrote: > > On 2017/10/19 16:45, Satoru Takeuchi wrote: > >> Some tools can select which superblock these commands use by "-s > >> " > >> o

Re: Unmountable fs - missing generation?

At Thu, 19 Oct 2017 12:03:08 +0900, satoru takeuchi wrote: > > Resend it since I forgot to CC linux-btrfs ML >Larkin > > On Oct 17, 2017, at 0:16, Larkin Lowrey <llow...@nuclearwinter.com> > wrote: > > I am unable to mount one my my filesystems. The supe

[PATCH] btrfs-progs: change mans to describe the third copy of superblock

Some tools can select which superblock these commands use by "-s " option. Although this option says the valid values are 0-2, we can set 3 if filesystem is very large. Signed-off-by: Satoru Takeuchi <satoru.takeu...@gmail.com> --- Documentation/btrfs-check.asciidoc| 2 +

Re: [PATCH v2] btrfs-progs: allow "none" to disable compression for convenience

At Tue, 19 Sep 2017 17:14:27 +0200, David Sterba wrote: > > On Mon, Sep 18, 2017 at 09:41:17AM +0900, Satoru Takeuchi wrote: > > At Sun, 17 Sep 2017 14:08:40 +0100, > > Mike Fleetwood wrote: > > > > > > On 17 September 2017 at 01:36, Satoru Takeuchi >

Re: [PATCH RESEND] btrfs-progs: allow "no" to disable compression for convenience

At Sat, 14 Oct 2017 18:19:14 +0200, Koen Kooi wrote: > > Op 14-10-17 om 14:54 schreef Satoru Takeuchi: > > It's messy to use "" to disable compression. Introduce the new value "no" > > which can also be used for this purpose. > > Wouldn't 'none'

Re: [PATCH] btrfs: use BLK_STS defines where needed

At Sat, 14 Oct 2017 08:35:56 +0800, Anand Jain wrote: > > At few places we could use BLK_STS_OK and BLK_STS_NOSUPP. > > Signed-off-by: Anand Jain Reviewed-by: Satoru Taekeuchi > --- > fs/btrfs/compression.c | 3 ++- > fs/btrfs/inode.c

[PATCH RESEND] btrfs-progs: allow "no" to disable compression for convenience

It's messy to use "" to disable compression. Introduce the new value "no" which can also be used for this purpose. Signed-off-by: Satoru Takeuchi <satoru.takeu...@gmail.com> --- Documentation/btrfs-property.asciidoc | 2 +- props.c | 6

Re: [PATCH] btrfs-progs: doc: update help/document of btrfs device remove

At Tue, 3 Oct 2017 17:12:39 +0900, Misono, Tomohiro wrote: > > This patch updates help/document of "btrfs device remove" in two points: > > 1. Add explanation of 'missing' for 'device remove'. This is only > written in wikipage currently. >

Re: USB upgrade fun

At Sun, 08 Oct 2017 17:58:10 +0800, Kai Hendry wrote: > > Hi there, > > My /mnt/raid1 suddenly became full somewhat expectedly, so I bought 2 > new USB 4TB hard drives (one WD, one Seagate) to upgrade to. > > After adding sde and sdd I started to see errors in dmesg [2]. >

Re: [PATCH] btrfs: Remove WARN_ON for unaligned device created before v4.13 and adds more user friendly output

At Sat, 23 Sep 2017 10:19:26 +0900, Satoru Takeuchi wrote: > > At Wed, 20 Sep 2017 15:18:43 +0900, > Qu Wenruo wrote: > > > > Commit 7dfb8be11b5d ("btrfs: Round down values which are written for > > total_bytes_size") is fixing the unaligned device size

Re: [PATCH] btrfs: Remove WARN_ON for unaligned device created before v4.13 and adds more user friendly output

At Wed, 20 Sep 2017 15:18:43 +0900, Qu Wenruo wrote: > > Commit 7dfb8be11b5d ("btrfs: Round down values which are written for > total_bytes_size") is fixing the unaligned device size caused by > adding/shrinking device. > > It added a new WARN_ON() when device size is unaligned. > This is fine

Re: [PATCH] Btrfs: use btrfs_op instead of bio_op in __btrfs_map_block

> Signed-off-by: Liu Bo <bo.li....@oracle.com> Reviewed-by: Satoru Takeuchi <satoru.takeu...@gmail.com> I checked all callers of the following functions and there is no leftover. - btrfs_map_block - btrfs_map_sblock - __btrfs_map_block Thanks, Satoru > --- > fs/btrfs/volumes.c

Re: [PATCH] btrfs-progs: subvolume: outputs message only when operation succeeds

ded or not. I tested this patch with injecting error on ioctl() for subvol creation/deletion. Reviewed-by: Satoru Takeuchi <satoru.takeu...@gmail.com> Tested-by: Satoru Takeuchi <satoru.takeu...@gmail.com> > --- > cmds-subvolume.c | 8 > 1 file changed, 4 ins

Re: [PATCH v2] btrfs-progs: allow "none" to disable compression for convenience

At Tue, 19 Sep 2017 17:14:27 +0200, David Sterba wrote: > > On Mon, Sep 18, 2017 at 09:41:17AM +0900, Satoru Takeuchi wrote: > > At Sun, 17 Sep 2017 14:08:40 +0100, > > Mike Fleetwood wrote: > > > > > > On 17 September 2017 at 01:36, Satoru Takeuchi >

Re: Btrfs Issues

At Wed, 13 Sep 2017 11:53:35 -0400, Ruoxin Jiang wrote: > > [1 ] > Hello, > > We are researchers from Columbia University, New York. As part of our > current research we have found some semantic discrepancies between > btrfs and other popular filesystems. > > We have attached two cases. The

Re: [PATCH v2] btrfs-progs: Output time elapsed for each major tree it checked

and lowmem mode, so we can have a clue what's going > wrong. > > Reported-by: Marc MERLIN <m...@merlins.org> > Signed-off-by: Qu Wenruo <quwenruo.bt...@gmx.com> > --- > v2: > Add prefix for each time report, as error message may make the output > hard to un

[PATCH v2] btrfs-progs: allow "none" to disable compression for convenience

At Sun, 17 Sep 2017 14:08:40 +0100, Mike Fleetwood wrote: > > On 17 September 2017 at 01:36, Satoru Takeuchi > <satoru.takeu...@gmail.com> wrote: > > It's messy to use "" to disable compression. Introduce the new value "no" > > which can also

Re: [PATCH] Btrfs: cleanup 'start' subtraction from try uncompressed inline extent

ranch, so it's > safe to remove that subtraction. > > Signed-off-by: Timofey Titovets <nefelim...@gmail.com> Reviewed-by: Satoru Takeuchi <satoru.takeu...@gmail.com> > --- > fs/btrfs/inode.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/

Re: [PATCH] btrfs-progs: Output time elapsed for each major tree it checked

At Mon, 11 Sep 2017 14:26:23 +0900, Qu Wenruo wrote: > > Marc reported that "btrfs check --repair" runs much faster than "btrfs > check", which is quite weird. > > This patch will add time elapsed for each major tree it checked, for > both original mode and lowmem mode, so we can have a clue

[PATCH] btrfs-progs: allow "no" to disable compression for convenience

It's messy to use "" to disable compression. Introduce the new value "no" which can also be used for this purpose. Signed-off-by: Satoru Takeuchi <satoru.takeu...@gmail.com> --- Documentation/btrfs-property.asciidoc | 2 +- props.c | 6

[PATCH] btrfs: prevent to set invalid default subvolid

`btrfs sub set-default` succeeds to set an ID which isn't corresponding to any fs/file tree. If such the bad ID is set to a filesystem, we can't mount this filesystem without specifying `subvol` or `subvolid` mount options. Signed-off-by: Satoru Takeuchi <satoru.takeu...@gmail.com> --- fs

[PATCH] btrfs: convert all mount option checking code to use btrfs_test_opt

Signed-off-by: Satoru Takeuchi <satoru.takeu...@gmail.com> --- fs/btrfs/extent-tree.c | 2 +- fs/btrfs/super.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c index e2d7e86..ea9b0d2 100644 --- a/fs/btrfs/extent-

Re: [PATCH] fix inconsistent device between /proc/pid/maps and stat

2017-03-24 20:58 GMT+09:00 David Sterba <dste...@suse.cz>: > On Tue, Mar 21, 2017 at 10:53:09AM +0900, Satoru Takeuchi wrote: >> There have been some discussions about inconsistent device between >> /proc/pid/maps and stat(2). >> >> http://thr3ads.net/btrfs-de

[PATCH] fix inconsistent device between /proc/pid/maps and stat

752 root txt REG 0,44 163224 263 /home/vagrant/mnt/lsof lsof 754 root txt REG 0,44 163224 263 /home/vagrant/mnt/lsof === Signed-off-by: Satoru Takeuchi <satoru.takeu...@gmail.com> CC: Signed-off-b

Re: [PATCH v12.1 01/15] btrfs: expand cow_file_range() to support in-band dedup and subpage-blocksize

On 2016/07/12 1:41, David Sterba wrote: > On Mon, Jul 11, 2016 at 11:05:29AM +0800, Qu Wenruo wrote: >> From: Wang Xiaoguang >> >> Extract cow_file_range() new parameters for both in-band dedupe and >> subpage sector size patchset. >> >> This should make conflict of

Re: [PATCH] btrfs-progs: add option to run balance as daemon

On 2016/06/22 0:16, Austin S. Hemmelgarn wrote: > Currently, balance operations are run synchronously in the foreground. > This is nice for interactive management, but is kind of crappy when you > start looking at automation and similar things. > > This patch adds an option to `btrfs balance

[PATCH] btrfs-progs: dedupe-inband enable/reconfigure: force option does not take argument

--- This patch can be applied to integration-20160704(2355a7e5dcdf122d1924) --- cmds-dedupe-ib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmds-dedupe-ib.c b/cmds-dedupe-ib.c index 342784c..dbb30ab 100644 --- a/cmds-dedupe-ib.c +++ b/cmds-dedupe-ib.c @@ -132,7 +132,7 @@

[PATCH] btrfs-progs: fi show: print error message if no valid Btrfs is specified

foo ERROR: foo is not a valid Btrfs # # echo $? 1 === Signed-off-by: Satoru Takeuchi <takeuchi_sat...@jp.fujitsu.com> --- cmds-filesystem.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/cmds-filesystem.c b/cmds-filesystem.c index

Re: [PATCH v11 00/13] Btrfs dedupe framework

d_io() to increase dedup >> rate. >> v5: >> Reuse compress routine for much simpler dedup function. >> Slightly improved performance due to above modification. >> Fix race between dedup enable/disable >> Fix for false ENOSPC report >> v6: >> Further

Re: Confusing output from fi us/df

On 2016/06/21 8:30, Marc Grondin wrote: > Hi everyone, > > > I have a btrfs filesystem ontop of a 4x1tb mdraid raid5 array and I've > been getting confusing output on metadata usage. Seems that even tho > both data and metadata are in single profile metadata is reporting > double the space(as if

Re: [PATCH] Btrfs-progs: Initialize stripesize to the value of sectorsize

On 2016/06/17 1:38, Chandan Rajendra wrote: > stripesize should ideally be set to the value of sectorsize. However > previous versions of btrfs-progs/mkfs.btrfs had set stripesize to a > value of 4096. On machines with PAGE_SIZE other than 4096, This could > lead to the following scenario, > > -

Re: [PATCH] btrfs-progs: doc: correct the destination of btrfs-receive

On 2016/06/14 18:16, Hugo Mills wrote: > On Tue, Jun 14, 2016 at 10:51:33AM +0200, David Sterba wrote: >> On Tue, Jun 14, 2016 at 02:50:19PM +0900, Satoru Takeuchi wrote: >>> We can set not only btrfs mount point but also any path belong to >>> btrfs mount point as

[PATCH] btrfs-progs: doc: correct the destination of btrfs-receive

We can set not only btrfs mount point but also any path belong to btrfs mount point as btrfs-receive's destination. Signed-off-by: Satoru Takeuchi <takeuchi_sat...@jp.fujitsu.com> --- Documentation/btrfs-receive.asciidoc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff

[PATCH 5/5] btrfs-progs: btrfs-crc: make argc check more strict

Signed-off-by: Satoru Takeuchi <takeuchi_sat...@jp.fujitsu.com> --- btrfs-crc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/btrfs-crc.c b/btrfs-crc.c index c2b5f00..d433ff3 100644 --- a/btrfs-crc.c +++ b/btrfs-crc.c @@ -69,12 +69,14 @@ int main(int argc, char

[PATCH 4/5] btrfs-progs: btrfs-crc: improve usage message

- If -c is set, filename argument is ignored. - Describe about -h option Signed-off-by: Satoru Takeuchi <takeuchi_sat...@jp.fujitsu.com> --- btrfs-crc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/btrfs-crc.c b/btrfs-crc.c index 55a4c61..c2b5f00 100644 --- a

[PATCH 3/5] btrfs-progs: btrfs-crc: print usage on receiving invalid arguments

Usage is only printed if -h option is set. However it's nice to do it when wrong option is set or the number of argument is wrong. Signed-off-by: Satoru Takeuchi <takeuchi_sat...@jp.fujitsu.com> --- btrfs-crc.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a

[PATCH 2/5] btrfs-progs: btrfs-crc should be ignored by git

It's a binary built from btrfs-crc.c Signed-off-by: Satoru Takeuchi <takeuchi_sat...@jp.fujitsu.com> --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index a27cb0d..aaf9702 100644 --- a/.gitignore +++ b/.gitignore @@ -33,6 +33,7 @@ btrfs-zero-log

[PATCH 1/5] btrfs-progs: btrfs-crc: fix build error

:125: first defined here collect2: error: ld returned 1 exit status Makefile:294: recipe for target 'btrfs-crc' failed make: *** [btrfs-crc] Error 1 = Signed-off-by: Satoru Takeuchi <takeuchi_sat...@jp.fujitsu.com> --- btrfs-crc.c | 4 ++--

Re: Very quick embarrassing q: /var/lib permissions.

On 2016/06/02 10:20, al wrote: Satoru Takeuchi jp.fujitsu.com> writes: Thank you, sir! I wonder if you would let me have the permissions (only) of any of the files you have inside your equivalent directory. Here it is. === # ls -l /var/lib/btrfs/ total 4 -rw---. 1 r

Re: Very quick embarrassing q: /var/lib permissions.

On 2016/06/01 6:53, al wrote: Please can someone run: # ls -l /var/lib/ | grep btrfs for me (and post to directly or via list as they think fit). $ ls -l /var/lib | grep btrfs drwxr-xr-x 1 root root 196 May 18 10:34 btrfs

Re: About in-band dedupe for v4.7

On 2016/05/11 10:40, Qu Wenruo wrote: Chris Mason wrote on 2016/05/10 20:37 -0400: On Tue, May 10, 2016 at 03:19:52PM +0800, Qu Wenruo wrote: Hi, Chris, Josef and David, As merge window for v4.7 is coming, it would be good to hear your ideas about the inband dedupe. We are addressing the

[PATCH 3/3] btrfs-progs: prop: remove conditions which never be satisfied

parse_args() always set at least one parameter, 'object', for {get,list} subcommands. In addition, it always set all three parameters, 'object', 'name', and 'value' for set subcommand. So the following conditions can be removed. Signed-off-by: Satoru Takeuchi <takeuchi_sat...@jp.fujitsu.

[PATCH 2/3] btrfs-progs: prop: simplify parse_args()

Since parameter is mandatory for all subcommands, 'object' is always set by parse_args()'s callers. In addition, on setting '*name' and '*value', if 'optind < argc' is satisfied here, they are always set by parse_args()'s callers. Signed-off-by: Satoru Takeuchi <takeuchi_sat...@jp.fujit

[PATCH 1/3] btrfs-progs: prop: convert error messages to use error()

props.c uses 'fprintf(stderr, "ERROR: ...")' as its error messages, however we have generic error() function. Signed-off-by: Satoru Takeuchi <takeuchi_sat...@jp.fujitsu.com> --- props.c | 21 + 1 file changed, 9 insertions(+), 12 deletions(-) diff --git a/p

Re: Question: raid1 behaviour on failure

On 2016/04/23 16:07, Matthias Bodenbinder wrote: Here is my newest test. The backports provide a 4.5 kernel: kernel: 4.5.0-0.bpo.1-amd64 btrfs-tools: 4.4-1~bpo8+1 This time the raid1 is automatically unmounted after I unplug the device and it can not be mounted while the device is

Re: Question: raid1 behaviour on failure

On 2016/04/22 14:32, Qu Wenruo wrote: Satoru Takeuchi wrote on 2016/04/22 11:21 +0900: On 2016/04/21 20:58, Qu Wenruo wrote: On 04/21/2016 03:45 PM, Satoru Takeuchi wrote: On 2016/04/21 15:23, Satoru Takeuchi wrote: On 2016/04/20 14:17, Matthias Bodenbinder wrote: Am 18.04.2016 um 09:22

Re: Question: raid1 behaviour on failure

On 2016/04/21 20:58, Qu Wenruo wrote: On 04/21/2016 03:45 PM, Satoru Takeuchi wrote: On 2016/04/21 15:23, Satoru Takeuchi wrote: On 2016/04/20 14:17, Matthias Bodenbinder wrote: Am 18.04.2016 um 09:22 schrieb Qu Wenruo: BTW, it would be better to post the dmesg for better debug. So here

Re: Question: raid1 behaviour on failure

On 2016/04/21 15:23, Satoru Takeuchi wrote: On 2016/04/20 14:17, Matthias Bodenbinder wrote: Am 18.04.2016 um 09:22 schrieb Qu Wenruo: BTW, it would be better to post the dmesg for better debug. So here we. I did the same test again. Here is a full log of what i did. It seems to be mean

Re: Question: raid1 behaviour on failure

On 2016/04/20 14:17, Matthias Bodenbinder wrote: Am 18.04.2016 um 09:22 schrieb Qu Wenruo: BTW, it would be better to post the dmesg for better debug. So here we. I did the same test again. Here is a full log of what i did. It seems to be mean like a bug in btrfs. Sequenz of events: 1. mount

[PATCH] btrfs-progs: prop: remove an unnecessary condition on parse_args

>From commit c742debab11f ('btrfs-progs: fix a regression that "property" with -t option doesn't work'), the number of arguments is checked strictly. So the following condition never be satisfied. Signed-off-by: Satoru Takeuchi <takeuchi_sat...@jp.fujitsu.com> --- cmds-prop

Re: [PATCH] btrfs: Test that qgroup counts are valid after snapshot creation

On 2016/04/20 7:25, Mark Fasheh wrote: This has been broken since Linux v4.1. We may have worked out a solution on the btrfs list but in the meantime sending a test to expose the issue seems like a good idea. Signed-off-by: Mark Fasheh --- tests/btrfs/122 | 88

Re: RFE: btrfs subvolume list -t, include marker for snapshots, and whether they are ro

On 2016/04/15 10:55, Chris Murphy wrote: Hi, I'm realizing instead of doing 'btrfs subvolume -t' and then 'btrfs subvolume -tr' and comparing, it would be better if -t just had a column for whether a subvolume is ro. And maybe it's useful to know if a subvolume is a snapshot or not (?). I'm not

[PATCH] btrfs-progs: mkfs: fix an error when using DUP on multidev fs

/dev/sdb2 == Signed-off-by: Satoru Takeuchi <takeuchi_sat...@jp.fujitsu.com> --- This patch can be applied to devel branch (commit: a35b7e6ee122) --- utils.c | 1 - 1 file changed, 1 deletion(-) diff --git a/utils.c b/utils.c index 75ce6ea..7e45702 100644 --- a/utils.c +++ b/utils.c @@

[PATCH 3/5] btrfs-progs: "inspect-internal subvolid-resolve" doesn't work

= * expected result == # btrfs inspect-internal subvolid-resolve 260 /btrfs snap ====== Signed-off-by: Satoru Takeuchi <takeuchi_sat...@jp.fujitsu.com> --- cmds-inspect.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmds-inspec

[PATCH 4/5] btrfs-progs: "qgroup assign" can't handle options

ed --no-rescan == * expected result == # ./btrfs qgroup assign --rescan 0/260 1/261 /btrfs # ====== Signed-off-by: Satoru Takeuchi <takeuchi_sat...@jp.fujitsu.com&g

[PATCH 1/5] btrfs-progs: "sub get-default" doesn't work

Get the default subvolume of a filesystem == * expected result == # btrfs sub get-default /btrfs ID 5 (FS_TREE) ====== Signed-off-by: Satoru Takeuchi &

[PATCH 5/5] btrfs-progs: qgroup assign can't handle --no-rescan option

-by: Satoru Takeuchi <takeuchi_sat...@jp.fujitsu.com> --- cmds-qgroup.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/cmds-qgroup.c b/cmds-qgroup.c index ebd66ef..4b4149d 100644 --- a/cmds-qgroup.c +++ b/cmds-qgroup.c @@ -44,9 +44,13 @@ static int _cmd_qgroup_

[PATCH 2/5] btrfs-progs: "qgroup create/destroy" don't work

estroy a quota group. == * expected result == # btrfs qgroup create 1 /btrfs/sub # btrfs qgroup destroy 1 /btrfs/sub/ ====== Signed-off-by: Satoru Ta

[PATCH 2/2 v2] btrfs-progs: Fix a regression that "property" with -t option doesn't work

Set/get label of device. ====== Signed-off-by: Satoru Takeuchi <takeuchi_sat...@jp.fujitsu.com --- v2: Reflect David's comment. - Check the number of non-option arguments --- cmds-property.c | 35 --- 1 file changed, 16 insertions(+), 19 deletions(-) diff --git a/

[PATCH 2/2 v2] fix a regression that "property" with -t option doesn't work

cts and object types. == * expected result == $ ./btrfs prop list -t f /btrfs label Set/get label of device. ====== Signed-off-by: Satoru Takeuchi <takeuch

[PATCH 1/2] btrfs-progs: Describe optarg of -m option in the manpage of receive

Signed-off-by: Satoru Takeuchi <takeuchi_sat...@jp.fujitsu.com> --- This patch can be applied to devel branch (commit: 4685a560811a) --- Documentation/btrfs-receive.asciidoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/btrfs-receive.asciidoc b/Documen

Re: [PATCH 2/4] btrfs-progs: fix a reression that "property" with -t option doesn't work

On 2016/03/14 21:23, David Sterba wrote: On Mon, Mar 14, 2016 at 09:12:36AM +0900, Satoru Takeuchi wrote: --- a/cmds-property.c +++ b/cmds-property.c @@ -379,9 +379,7 @@ static int cmd_property_get(int argc, char **argv) char *name = NULL; int types = 0

[PATCH] btrfs: Simplify conditions about compress while mapping btrfs flags to inode flags

Signed-off-by: Satoru Takeuchi <takeuchi_sat...@jp.fujitsu.com> --- This patch can be applied to 4.5 --- fs/btrfs/ioctl.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c index 48aee98..b474e32 100644 --- a/fs/btrfs/ioctl.c ++

[PATCH 4/4] btrfs-progs: "device ready" accepts just one device

: btrfs device ready Check device to see if it has all of its devices in cache for mounting # === Signed-off-by: Satoru Takeuchi <takeuchi_sat...@jp.fujitsu.com> --- cmds-device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 2/4] btrfs-progs: fix a reression that "property" with -t option doesn't work

cts and object types. == * expected result == # btrfs prop list -t f /btrfs label Set/get label of device ====== Signed-off-by: Satoru Takeuchi <takeuch

[PATCH 1/4] btrfs-progs: Avoid interpreting options after "--" when getting unit mode

: 91247.41MiB == * expected result == # ./btrfs device usage -- -m /btrfs ERROR: can't access '-m': No such file or directory == Signed-off-by: Satoru Takeuchi <takeuchi_

Re: How to move a btrfs volume to a smaller disk

On 2016/03/10 6:46, Hendrik Friedel wrote: Hello, I intend to move this subvolume to a new device. btrfs fi show /mnt2/Data_Store/ Label: 'Data_Store' uuid: 0ccc1e24-090d-42e2-9e61-d0a1b3101f93 Total devices 1 FS bytes used 47.93GiB devid1 size 102.94GiB used 76.03GiB

[PATCH] btrfs-progs: Fix device scan to interpret its argument properly

in '/dev/sdb' Signed-off-by: Satoru Takeuchi <takeuchi_sat...@jp.fujitsu.com> --- This patch can be applied to devel (commit: 5d038a7ed212) --- cmds-device.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/cmds-device.c b/cmds-device.c

Re: [PATCH 1/2] btrfs-progs: Remove unnecessary variable devstart from cmd_device_scan()

On 2016/03/10 22:27, David Sterba wrote: On Thu, Mar 10, 2016 at 08:04:59AM +0900, Satoru Takeuchi wrote: It's unnecessary since it's always 1. Signed-off-by: Satoru Takeuchi <takeuchi_sat...@jp.fujitsu.com> --- This patch can be applied to devel (commit b2bdd0da8969). --- cmds-device

[PATCH 2/2] btrfs-progs: Describe device scan -d is a deprecated option in manpage

It's already marked as deprecated in cmd_device_scan_usage(). commit 5444864e5605 ("btrfs-progs: remove BTRFS_SCAN_PROC scan method") Signed-off-by: Satoru Takeuchi <takeuchi_sat...@jp.fujitsu.com> --- Documentation/btrfs-device.asciidoc | 4 ++-- 1 file changed, 2 insertions

[PATCH 1/2] btrfs-progs: Remove unnecessary variable devstart from cmd_device_scan()

It's unnecessary since it's always 1. Signed-off-by: Satoru Takeuchi <takeuchi_sat...@jp.fujitsu.com> --- This patch can be applied to devel (commit b2bdd0da8969). --- cmds-device.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/cmds-device.c b/cmds-device.c index c

Re: [PATCH] Fix broken 'device scan' arguments parsing

On 2016/03/09 10:19, Yauhen Kharuzhy wrote: > commit 52179e4fea41e55f31c92cd033a0b53a5107b4f4 'btrfs-progs: unify argc > min/max checking' brokes 'btrfs device scan' command when no argument > was given. Fix this. > > Signed-off-by: Yauhen Kharuzhy > --- >

[PATCH v3] Btrfs: Show a warning message if one of objectid reaches its highest value

such problem. Signed-off-by: Satoru Takeuchi <takeuchi_sat...@jp.fujitsu.com> --- This patch can be applied to 4.5-rc7 V3: - Show this message every time when hitting this problem for simplicity (thanks to the comment from Goffredo). - Reflect Naota's comment - Keep the error code as is. V2: - R

Re: [PATCH v2] Btrfs: Show a warning message if one of objectid reaches its highest value

On 2016/03/09 11:32, Naohiro Aota wrote: 2016-03-07 12:05 GMT+09:00 Satoru Takeuchi <takeuchi_sat...@jp.fujitsu.com>: - It's better to show a warning message for the exceptional case that one of objectid (in most case, inode number) reaches its highest value. Show this message onl

Re: [PATCH v2] Btrfs: Show a warning message if one of objectid reaches its highest value

On 2016/03/09 4:24, Goffredo Baroncelli wrote: > On 2016-03-07 04:05, Satoru Takeuchi wrote: >> - It's better to show a warning message for the exceptional case >> that one of objectid (in most case, inode number) reaches its >> highest value. Show this message only

Re: [PATCH] Documentation: btrfs: remove usage specific information

On 2016/03/09 2:04, David Sterba wrote: > The document in the kernel sources is yet another palce where the > documentation would need to be updated, while it is not the primary > source. We actively maintain the wiki pages. > > Signed-off-by: David Sterba > --- >

Re: Btrfsck memory usage reduce idea

On 2016/03/08 17:46, Qu Wenruo wrote: Satoru Takeuchi wrote on 2016/03/08 17:28 +0900: Hi Qu, On 2016/03/07 14:42, Qu Wenruo wrote: Hi, As many have already known, "btrfs check" is a memory eater. The problem is, btrfsck checks extent tree in a very comprehensive method.

Re: Btrfsck memory usage reduce idea

Hi Qu, On 2016/03/07 14:42, Qu Wenruo wrote: Hi, As many have already known, "btrfs check" is a memory eater. The problem is, btrfsck checks extent tree in a very comprehensive method. 1) Create extent_ref for each extent item with backref 2) Iterate all other trees to add extent ref 3) If

Re: [PATCH v2] Btrfs: Show a warning message if one of objectid reaches its highest value

On 2016/03/07 12:05, Satoru Takeuchi wrote: > - It's better to show a warning message for the exceptional case >that one of objectid (in most case, inode number) reaches its >highest value. Show this message only once to avoid filling >dmesg with it. > - EOVERFLOW is mor

[PATCH v2] Btrfs: Show a warning message if one of objectid reaches its highest value

left on device" case and objectid isn't related to any device. Signed-off-by: Satoru Takeuchi <takeuchi_sat...@jp.fujitsu.com> --- This patch can be applied to 4.5-rc7 --- fs/btrfs/inode-map.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/fs/btrfs/inode-

Re: [PATCH] Show a warning message if one of highest objectid reaches its max value

Hi Filipe, On 2016/03/04 18:28, Filipe Manana wrote: On Fri, Mar 4, 2016 at 2:37 AM, Satoru Takeuchi <takeuchi_sat...@jp.fujitsu.com> wrote: - It's better to show a warning message for the exceptional case that one of highest objectid (in most case, inode number) reaches its max

[PATCH] Show a warning message if one of highest objectid reaches its max value

. ENOSPC is for "No space left on device" case and objectid isn't related to any device. Signed-off-by: Satoru Takeuchi <takeuchi_sat...@jp.fujitsu.com> --- This patch can be applied to v4.5-rc6 --- fs/btrfs/inode-map.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-)

Re: [PATCH] Btrfs: fix listxattrs not listing all xattrs packed in the same item

$GETFATTR_PROG --absolute-names --dump $SCRATCH_MNT/testfile | _filter_scratch status=0 exit Tested-by: Satoru Takeuchi <takeuchi_sat...@jp.fujitsu.com> * chris/integration-4.6(HEAD is 790dd8b) === # ./check generic/337 FSTYP -- btrfs

Re: [PATCH] btrfs: Avoid BUG_ON()s because of ENOMEM caused by kmalloc() failure

On 2016/02/18 0:11, David Sterba wrote: On Wed, Feb 17, 2016 at 02:54:23PM +0900, Satoru Takeuchi wrote: On 2016/02/16 2:53, David Sterba wrote: On Mon, Feb 15, 2016 at 02:38:09PM +0900, Satoru Takeuchi wrote: There are some BUG_ON()'s after kmalloc() as follows. = foo = kmalloc

Re: [PATCH] btrfs: Avoid BUG_ON()s because of ENOMEM caused by kmalloc() failure

On 2016/02/16 2:53, David Sterba wrote: On Mon, Feb 15, 2016 at 02:38:09PM +0900, Satoru Takeuchi wrote: There are some BUG_ON()'s after kmalloc() as follows. = foo = kmalloc(); BUG_ON(!foo); /* -ENOMEM case */ = A Docker + memory cgroup user hit these BUG_ON()s. https

[PATCH] btrfs: Avoid BUG_ON()s because of ENOMEM caused by kmalloc() failure

these kmalloc() failures to avoid these BUG_ON()s for now, are a bit better than the current implementation anyway. Signed-off-by: Satoru Takeuchi <takeuchi_sat...@jp.fujitsu.com> --- fs/btrfs/extent_io.c | 6 ++ fs/btrfs/inode.c | 6 ++ fs/btrfs/relocation.c | 3 +-- 3 files chan

[PATCH] btrfs-progs: write down the meaning of BTRFS_ARG_BLKDEV

Although BTRFS_ARG_BLKDEV can be returned from check_arg_type(), it's not explained the meaning. Signed-off-by: Satoru Takeuchi <takeuchi_sat...@jp.fujitsu.com> --- utils.c | 1 + 1 file changed, 1 insertion(+) diff --git a/utils.c b/utils.c index 3df8b42..eabc36d 100644 --- a/utils.c

[PATCH] btrfs-progs: Fix self-reference of man btrfs-subvolume

btrfs-subvolume(8) is mentioned at "SEE ALSO" section of itself. Signed-off-by: Satoru Takeuchi <takeuchi_sat...@jp.fujitsu.com> --- Documentation/btrfs-subvolume.asciidoc | 1 - 1 file changed, 1 deletion(-) diff --git a/Documentation/btrfs-subvolume.asciidoc b/Doc

[PATCH] btrfs-progs: describe btrfs-send requires read-only subvolume

Both man btrfs-send(8) and usage message don't describe btrfs-send needs read-only snapshot as its argument. Signed-off-by: Satoru Takeuchi <takeuchi_sat...@jp.fujitsu.com> --- Documentation/btrfs-send.asciidoc | 1 + cmds-send.c | 1 + 2 files changed, 2 inse

Re: Kernel bug in 3.19-rc4

Hi, On 2015/01/16 10:05, Tomasz Chmielewski wrote: I just started some btrfs stress testing on latest linux kernel 3.19-rc4: A few hours later, filesystem stopped working - the kernel bug report can be found below. Hi, your kernel BUG at fs/btrfs/inode.c:3142! from 3.19-rc4 corresponds to

Re: Kernel bug in 3.19-rc4

Hi Marcel, On 2015/01/16 4:46, Marcel Ritter wrote: Hi, I just started some btrfs stress testing on latest linux kernel 3.19-rc4: A few hours later, filesystem stopped working - the kernel bug report can be found below. The test consists of one massive IO thread (writing 100GB files with dd),

Re: [PATCH] btrfs: get the accurate value of used_bytes in btrfs_get_block_group_info().

Hi Dongsheng, On 2015/01/05 20:19, Dongsheng Yang wrote: Ping. IOCTL of BTRFS_IOC_SPACE_INFO currently does not report the data used but not synced to user. Then btrfs fi df will give user a wrong numbers before sync. This patch solve this problem. On 10/27/2014 08:38 PM, Dongsheng Yang

Re: [PATCH] btrfs-progs: Fix a copy-n-paste bug in btrfs_read_fs_root().

On 2015/01/07 18:23, Qu Wenruo wrote: Signed-off-by: Qu Wenruo quwen...@cn.fujitsu.com Reviewed-by: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com --- disk-io.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/disk-io.c b/disk-io.c index 2bf8586..b853f66 100644

Re: [PATCH v3 0/3] Btrfs: Enhancment for qgroup.

Hi Yang, On 2015/01/05 15:16, Dongsheng Yang wrote: Hi Josef and others, This patch set is about enhancing qgroup. [1/3]: fix a bug about qgroup leak when we exceed quota limit, It is reviewd by Josef. [2/3]: introduce a new accounter in qgroup to close a window where user

Re: [PATCH] btrfs: clear bio reference after submit_one_bio()

ENOMEM case with the following script (need CONFIG_FAIL_PAGE_ALLOC, and CONFIG_FAULT_INJECTION_DEBUG_FS). I confirmed that this problem reproduce with 3.19-rc3 and not reproduce with 3.19-rc3 with your patch. Tested-by: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com Thank you for reporting

Re: [PATCH] btrfs: qgroup: move WARN_ON() to the correct location.

it normally. This patch move this WARN_ON() before freeing qg-excl. Signed-off-by: Dongsheng Yang yangds.f...@cn.fujitsu.com Reviewed-by: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com --- fs/btrfs/qgroup.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/btrfs

Re: kernel BUG at /home/apw/COD/linux/fs/btrfs/inode.c:3123!

Hi Tomasz, On 2014/12/20 8:28, Tomasz Chmielewski wrote: Get this BUG with 3.18.1 (pasted at the bottom of the email). Below all actions from creating the fs to BUG. I did not attempt to reproduce. I tried to reproduce this problem and have some questions. # mkfs.btrfs /dev/vdb Btrfs

Re: [PATCH] btrfs: suppress a build warning on building 32bit kernel

Hi David, On 2014/12/30 0:09, David Sterba wrote: On Thu, Dec 25, 2014 at 06:21:41PM +0900, Satoru Takeuchi wrote: From: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com --- a/fs/btrfs/extent_io.c +++ b/fs/btrfs/extent_io.c @@ -2190,7 +2190,7 @@ void btrfs_free_io_failure_record(struct inode

Re: [PATCH] btrfs-progs: Fix a extent buffer leak in count_csum_range().

Wenruo quwen...@cn.fujitsu.com Reviewed-by: Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com --- cmds-check.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmds-check.c b/cmds-check.c index d2d218a..5b644cf 100644 --- a/cmds-check.c +++ b/cmds-check.c @@ -1186,9

Re: Debian/Jessie 3.16.7-ckt2-1 kernel error

Hi Petr, On 2014/12/28 0:36, Petr Janecek wrote: Hello Satoru and all, that Oct. report was the only time I've experienced the error, so I don't have much to add. I can try to answer your questions: Here are my questions. 1. Is your system btrfs scrub clean? yes, 2. Is this

  1   2   3   >