Re: [PATCH v14.8 12/14] btrfs: dedupe: Add ioctl for inband deduplication

On 2018/07/12 10:25, Lu Fengqi wrote: > From: Wang Xiaoguang > > Add ioctl interface for inband deduplication, which includes: > 1) enable > 2) disable > 3) status > > And a pseudo RO compat flag, to imply that btrfs now supports inband > dedup. > However we don't add any ondisk format change,

Re: [PATCH] Remove unused dedupe argument btrfs_set_extent_delalloc()

On 2017/10/11 11:29, Goldwyn Rodrigues wrote: > From: Goldwyn Rodrigues > 'int dedupe' was added to prepare for support of subpage sector size and in-band dedupe. commit ba8b04c1d4ad ("btrfs: extend btrfs_set_extent_delalloc and its friends to support in-band dedupe and

[PATCH v2] Btrfs: fix overlap of fs_info->flags values

to enable quota override for CAP_SYS_RESOURCE") CC: sta...@vger.kernel.org # 4.13+ Signed-off-by: Tsutomu Itoh <t-i...@jp.fujitsu.com> --- v2: changed the value of BTRFS_FS_QUOTA_OVERRIDE instead of BTRFS_FS_EXCL_OP to 16. fs/btrfs/ctree.h | 7 +++ 1 file changed, 3 insertions(+), 4 deletio

[PATCH] Btrfs: fix fs_info->flags value

Because the values of BTRFS_FS_QUOTA_OVERRIDE and BTRFS_FS_EXCL_OP overlap, we should change the value. Signed-off-by: Tsutomu Itoh <t-i...@jp.fujitsu.com> --- fs/btrfs/ctree.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/btrfs/ctree.h b/fs/btrfs/ctree.h

Re: [PATCH] btrfs: send: fix error code if an unknown inode type is found

similar patch, you said "I'd rather make it EINVAL". https://marc.info/?l=linux-btrfs=145342170820262=2 But I think that EOPNOTSUPP is also good. So, anyway, Reviewed-by: Tsutomu Itoh <t-i...@jp.fujitsu.com> > > The unknown type seems to be the block device (S_IFBLK)(

Re: status of inline deduplication in btrfs

On 2017/08/23 23:52, shally verma wrote: > HI > > Through btrfs wiki, I got to know about inline patch and this git > location https://github.com/adam900710/linux but I am not sure what's > progress and status on this. Could any one please confirm what is the > status of inline deduplication

Re: [PATCH] btrfs-progs: mkfs: Replace number with a macro

On 2017/06/26 17:23, Gu Jinxiang wrote: > For code maintainability and scalability, > replace number with a macro of member blocks in btrfs_mkfs_config. > > Signed-off-by: Gu Jinxiang > --- > mkfs/common.c | 2 +- > mkfs/common.h | 5 - > 2 files changed, 5

Re: btrfs-progs 4.11 broke snap-sync

On 2017/05/29 12:41, Wael M. Nasreddine wrote: > Hello, > > I use Arch, the system is entirely on btrfs (on a LUKS partition). I > use snap-sync[0] to sync snapshots to an external drive. When 4.11 > came out, snap-sync errors out with the message: ERROR: unable to > resolve -c. > > Reverting

Re: Btrfs progs release 4.11

Hi David, Could you please apply the following patch? [PATCH] btrfs-progs: tests: remove variable quotation from convert-tests http://marc.info/?l=linux-btrfs=149490441323349=2 Thanks, Tsutomu On 2017/05/18 23:35, David Sterba wrote: > Hi, > > btrfs-progs version 4.11 have been released.

[PATCH] btrfs-progs: tests: remove variable quotation from convert-tests

: recipe for target 'test-convert' failed make: *** [test-convert] Error 1 So, remove quotes from $default_mke2fs. Signed-off-by: Tsutomu Itoh <t-i...@jp.fujitsu.com> --- tests/convert-tests/008-readonly-image/test.sh | 2 +- tests/convert-tests/009-common-inode-flags/test.sh | 2 +- 2

Re: Btrfs progs pre-release 4.10-rc1

On 2017/03/07 20:54, David Sterba wrote: > On Tue, Mar 07, 2017 at 11:03:33AM +0900, Tsutomu Itoh wrote: >> Hi David, >> >> On 2017/03/02 23:59, David Sterba wrote: >>> Hi, >>> >>> a pre-release has been tagged. There are patches that have qu

Re: Btrfs progs pre-release 4.10-rc1

eck: Output verbose error when fsck found a bug in any > tree > btrfs-progs: check: lowmem: Fix false alert in checking data extent > csums > btrfs-progs: check: lowmem: Fix extent item size false alert > btrfs-progs: check: lowmem: Fix false alert on inline compress

Re: [PATCH v2] btrfs-progs: Fix NULL pointer when receive clone operation

return int case, convert NULL pointer to -ENOENT. This patch also passed xfstests btrfs/{108,109,117}. Thanks for your work. Thanks, Tsutomu > > Reported-by: Tsutomu Itoh <t-i...@jp.fujitsu.com> > Signed-off-by: Qu Wenruo <quwen...@cn.fujitsu.com>

Re: Btrfs progs pre-release 4.9-rc1

On 2016/12/15 15:45, Tsutomu Itoh wrote: > On 2016/12/14 23:42, David Sterba wrote: >> Hi, >> >> a pre-release has been tagged. Contains almost the entire devel branch from >> today. There are small fixes, the lowmem mode of check gets more updates but >> still d

Re: [PATCH] btrfs-progs: Fix NULL pointer when receive clone operation

On 2016/12/15 16:28, Qu Wenruo wrote: > The subvol_info returned from subvol_uuid_search() can be NULL. > So the branch checking IS_ERR(si) should also check if it's NULL. > > Reported-by: Tsutomu Itoh <t-i...@jp.fujitsu.com> > Signed-off-by: Qu Wenruo <quwen...@cn.fu

Re: Btrfs progs pre-release 4.9-rc1

On 2016/12/14 23:42, David Sterba wrote: > Hi, > > a pre-release has been tagged. Contains almost the entire devel branch from > today. There are small fixes, the lowmem mode of check gets more updates but > still does not work in the --repair mode and is considered experimental. > > ETA for 4.9

[PATCH v2] btrfs-progs: tests: add test for --sync option of qgroup show

Simple test script for the following patch. btrfs-progs: qgroup: add sync option to 'qgroup show' Signed-off-by: Tsutomu Itoh <t-i...@jp.fujitsu.com> --- v2: dropped the test of --no-sync --- tests/cli-tests/005-qgroup-show-sync/test.sh | 30 1 file chang

[PATCH v3 2/2] btrfs-progs: qgroup: change the value of sort option

The value of sort option ('S') is not used for option letter. Therefore, I'll change the single letter to non-character. Signed-off-by: Tsutomu Itoh <t-i...@jp.fujitsu.com> --- This patch is separated from patch of --sync option. --- cmds-qgroup.c | 7 --- 1 file changed, 4 insertions

[PATCH v3 1/2] btrfs-progs: qgroup: add sync option to 'qgroup show'

-by: Tsutomu Itoh <t-i...@jp.fujitsu.com> --- v2: use getopt_long with enum instead of single letter (suggested by Qu) v3: dropped the --no-sync option and separated the patch of sort option (suggested by David) --- Documentation/btrfs-qgroup.asciidoc | 4 cmds-qg

Re: [PATCH v2] btrfs-progs: qgroup: add sync option to 'qgroup show'

Hi David, Thanks for the review. On 2016/12/14 19:54, David Sterba wrote: > On Wed, Dec 07, 2016 at 04:55:15PM +0900, Tsutomu Itoh wrote: >> The 'qgroup show' command does not synchronize filesystem. >> Therefore, 'qgroup show' may not display the correct value unless

Re: [PATCH 3/3] btrfs-progs: convert-test: trigger chunk allocation after convert

On 2016/12/13 18:44, Qu Wenruo wrote: > Populate fs after convert so we can trigger data chunk allocation. > This can expose too restrict old rollback condition > > Reported-by: Chandan Rajendra > Signed-off-by: Qu Wenruo > --- >

[PATCH] btrfs-progs: tests: add test for --sync option of qgroup show

Simple test script for the following patch. btrfs-progs: qgroup: add sync option to 'qgroup show' Signed-off-by: Tsutomu Itoh <t-i...@jp.fujitsu.com> --- tests/cli-tests/005-qgroup-show-sync/test.sh | 30 1 file changed, 30 insertions(+) create mode 100755

[PATCH v2] btrfs-progs: qgroup: add sync option to 'qgroup show'

. Signed-off-by: Tsutomu Itoh <t-i...@jp.fujitsu.com> --- v2: use getopt_long with enum instead of single letter (suggested by Qu) --- Documentation/btrfs-qgroup.asciidoc | 6 ++ cmds-qgroup.c | 33 + 2 files changed, 35 insertions

Re: [PATCH] btrfs-progs: qgroup: add sync option to 'qgroup show'

On 2016/12/07 13:59, Qu Wenruo wrote: > > > At 12/07/2016 12:31 PM, Tsutomu Itoh wrote: >> Hi Qu, >> >> Thanks for the review. >> >> On 2016/12/07 12:24, Qu Wenruo wrote: >>> >>> >>> At 12/07/2016 11:07 AM, Tsutomu Itoh wro

Re: [PATCH] btrfs-progs: qgroup: add sync option to 'qgroup show'

Hi Qu, Thanks for the review. On 2016/12/07 12:24, Qu Wenruo wrote: > > > At 12/07/2016 11:07 AM, Tsutomu Itoh wrote: >> The 'qgroup show' command does not synchronize filesystem. >> Therefore, 'qgroup show' may not display the correct value unless >> synchro

[PATCH] btrfs-progs: qgroup: add sync option to 'qgroup show'

. Signed-off-by: Tsutomu Itoh <t-i...@jp.fujitsu.com> --- Documentation/btrfs-qgroup.asciidoc | 5 + cmds-qgroup.c | 24 ++-- 2 files changed, 27 insertions(+), 2 deletions(-) diff --git a/Documentation/btrfs-qgroup.asciidoc b/Documentation

Re: [bug] btrfs-progs-v4.8.4: test of 'btrfs receive' in xfstests fails

Hi David, On 2016/11/30 0:34, David Sterba wrote: > On Mon, Nov 28, 2016 at 04:27:06PM +0900, Tsutomu Itoh wrote: >> Many test of xfstests such as btrfs/007, btrfs/008 and btrfs/016 failed >> with the following patch. >> >> fefbab75 btrfs-progs: send-stream: chec

[bug] btrfs-progs-v4.8.4: test of 'btrfs receive' in xfstests fails

Hi, David, Many test of xfstests such as btrfs/007, btrfs/008 and btrfs/016 failed with the following patch. fefbab75 btrfs-progs: send-stream: check number of read bytes from stream This is because cmds-receive.c:do_receive() make a judgement of the end of stream by returning 1 from

[PATCH v2 2/3] btrfs-progs: test: fix how to make test files in fsck-tests 013

' to 'common'. Signed-off-by: Tsutomu Itoh <t-i...@jp.fujitsu.com> --- v2: change how to make test files --- tests/common | 89 tests/common.convert | 89 tests/fsck-tests/013-exten

Re: [PATCH 2/3] btrfs-progs: test: expand size of test device of fsck-tests 013

Hi, Qu and David, On 2016/11/19 3:28, David Sterba wrote: > On Fri, Nov 18, 2016 at 02:36:28PM +0800, Qu Wenruo wrote: >> >> >> On 11/18/2016 01:47 PM, Tsutomu Itoh wrote: >>> In my test environment, size of /lib/modules/`uname -r`/* is >>> larger than 1G

[PATCH 3/3] btrfs-progs: test: fix convert-tests 004 failure

convert-tests 004 failed because the argument to check_all_images is not specified. # make test-convert [TEST] convert-tests.sh [TEST/conv] 004-ext2-backup-superblock-ranges find: '': No such file or directory # Signed-off-by: Tsutomu Itoh <t-i...@jp.fujitsu.com> --- tests/c

[PATCH 2/3] btrfs-progs: test: expand size of test device of fsck-tests 013

/btrfs-progs/tests/mnt test failed for case 013-extent-tree-rebuild Makefile:272: recipe for target 'test-fsck' failed make: *** [test-fsck] Error 1 # Signed-off-by: Tsutomu Itoh <t-i...@jp.fujitsu.com> --- tests/fsck-tests/013-extent-tree-rebuild/test.sh | 2 +- 1 file changed, 1 insertion

[PATCH 1/3] btrfs-progs: test: fix error of test target of Makefile

Add test-cli to test target of Makefile. Signed-off-by: Tsutomu Itoh <t-i...@jp.fujitsu.com> --- Makefile.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.in b/Makefile.in index 4bd3e63..6c78841 100644 --- a/Makefile.in +++ b/Makefile.in @@ -298,7 +298,7 @

[PATCH] btrfs-progs: qgroup: fix error in ASSERT condition expression

Option -f, -F and --sort don't work because a conditional expression of ASSERT is wrong. Signed-off-by: Tsutomu Itoh <t-i...@jp.fujitsu.com> --- qgroup.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qgroup.c b/qgroup.c index 9d10cb8..071d15e 100644 --- a/qgroup.c

Re: [PATCH 2/3] btrfs-progs: send: fix handling of multiple snapshots (-p option)

xfstests btrfs/038 fails when this patch is applied. Sorry for my fault. I posted the patch that corrected this problem. [PATCH] btrfs-progs: send: fix failure of xfstests btrfs/038 Thanks, Tsutomu On 2016/10/19 11:35, Tsutomu Itoh wrote: > We cannot send multiple snapshots at once by

[PATCH] btrfs-progs: send: fix failure of xfstests btrfs/038

-- btrfs | PLATFORM -- Linux/x86_64 luna 4.9.0-rc5 | MKFS_OPTIONS -- /dev/sdb3 | MOUNT_OPTIONS -- /dev/sdb3 /test6 | | btrfs/038 1s ... 1s | Ran: btrfs/038 | Passed all 1 tests Signed-off-by: Tsutomu Itoh <t-i...@jp.fujitsu.com> --- cmds-send.c | 4 ++-- 1 file changed, 2 inse

[PATCH v3] btrfs-progs: send-test: add checking of clone-src option

Sending stream size of clone-src(-c) option is checked. Fixed by "btrfs-progs: send: fix handling of -c option". Signed-off-by: Tsutomu Itoh <t-i...@jp.fujitsu.com> --- V2: old sending stream image is used V3: image file has been compressed by gzip --- .../016-send-clone-src/se

Re: [PATCH v2] btrfs-progs: send-test: add checking of clone-src option

On 2016/11/09 10:39, Qu Wenruo wrote: > > > At 11/09/2016 09:25 AM, Tsutomu Itoh wrote: >> Sending stream size of clone-src(-c) option is checked. >> Fixed by "btrfs-progs: send: fix handling of -c option". >> >> Signed-off-by: Tsutomu Itoh <t-

[PATCH v2] btrfs-progs: send-test: add checking of clone-src option

Sending stream size of clone-src(-c) option is checked. Fixed by "btrfs-progs: send: fix handling of -c option". Signed-off-by: Tsutomu Itoh <t-i...@jp.fujitsu.com> --- V2: old sending stream image is used --- .../016-send-clone-src/send-stream-v4.8.2.img | Bin 0 -> 6

Re: [PATCH] btrfs-progs: send-test: add checking of clone-src option

On 2016/11/08 21:47, David Sterba wrote: > On Tue, Nov 08, 2016 at 08:53:04AM +0900, Tsutomu Itoh wrote: >> On 2016/11/08 0:16, David Sterba wrote: >>> On Fri, Nov 04, 2016 at 05:35:18PM +0900, Tsutomu Itoh wrote: >>>> +before_size=`ls -l "$here&q

Re: [PATCH] btrfs-progs: send-test: add checking of clone-src option

On 2016/11/08 0:16, David Sterba wrote: > On Fri, Nov 04, 2016 at 05:35:18PM +0900, Tsutomu Itoh wrote: >> +before_size=`ls -l "$here"/send.stream.before | awk '{print $5}'` >> +after_size=`ls -l "$here"/send.stream.after | awk '{print $5}'` > > Thanks for

[PATCH] btrfs-progs: send-test: add checking of clone-src option

Sending stream size of clone-src(-c) option is checked. Signed-off-by: Tsutomu Itoh <t-i...@jp.fujitsu.com> --- tests/misc-tests/016-send-clone-src/test.sh | 54 + 1 file changed, 54 insertions(+) create mode 100755 tests/misc-tests/016-send-clone-src/test.sh

[PATCH v2 3/3] btrfs-progs: send: fix handling of -c option

19 10:37 /tmp/data1 # [after] # btrfs send -f /tmp/data1 -c Snap0 -c ../SnapX Snap[12] ../SnapY At subvol Snap1 At subvol Snap2 At subvol ../SnapY # ls -l /tmp/data1 -rw--- 1 root root 1492 Oct 19 10:39 /tmp/data1 # Signed-off-by: Tsutomu Itoh <t-i...@jp.fujitsu.com> --- v2: make

Re: [PATCH 3/3] btrfs-progs: send: fix handling of -c option

On 2016/11/02 21:22, David Sterba wrote: > On Wed, Oct 19, 2016 at 11:35:40AM +0900, Tsutomu Itoh wrote: >> When two or more -c options are specified, cannot find a suitable >> parent. So, output stream is bigger than correct one. >> >> [before] >> # btrfs send -

Re: [PATCH 2/3] btrfs-progs: send: fix handling of multiple snapshots (-p option)

Sorry for the late reply. On 2016/10/29 0:10, David Sterba wrote: > On Wed, Oct 19, 2016 at 11:35:03AM +0900, Tsutomu Itoh wrote: >> We cannot send multiple snapshots at once by -p option. > > We cannot like that it's broken, or we cannot because it's not supposed > to work

[PATCH v2 1/3] btrfs-progs: send: remove unnecessary code

Some unnecessary codes are deleted. - the setting of subvol is double. - read only check was already done by previous loop. Signed-off-by: Tsutomu Itoh <t-i...@jp.fujitsu.com> --- v2: description was changed --- cmds-send.c | 11 --- 1 file changed, 11 deletions(-) diff --git

[PATCH 2/3] btrfs-progs: send: fix handling of multiple snapshots (-p option)

-by: Tsutomu Itoh <t-i...@jp.fujitsu.com> --- cmds-send.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/cmds-send.c b/cmds-send.c index dfdfe01..2a8a697 100644 --- a/cmds-send.c +++ b/cmds-send.c @@ -650,7 +650,7 @@ int cmd_send(int argc, char **argv)

[PATCH 3/3] btrfs-progs: send: fix handling of -c option

19 10:37 /tmp/data1 # [after] # btrfs send -f /tmp/data1 -c Snap0 -c ../SnapX Snap[12] ../SnapY At subvol Snap1 At subvol Snap2 At subvol ../SnapY # ls -l /tmp/data1 -rw--- 1 root root 1492 Oct 19 10:39 /tmp/data1 # Signed-off-by: Tsutomu Itoh <t-i...@jp.fujitsu.com> --- cmds-send.

[PATCH 1/3] btrfs-progs: send: remove unnecessary code

Some unnecessary codes is deleted. Signed-off-by: Tsutomu Itoh <t-i...@jp.fujitsu.com> --- cmds-send.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/cmds-send.c b/cmds-send.c index 74d0128..dfdfe01 100644 --- a/cmds-send.c +++ b/cmds-send.c @@ -564,8 +564,6 @@ int cmd_se

[PATCH] btrfs-progs: image: fix compiler warning

art); ^ btrfs-image.c:927:6: note: 'start' was declared here u64 start; ^ Signed-off-by: Tsutomu Itoh <t-i...@jp.fujitsu.com> --- btrfs-image.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/btrfs-image.c b/btrfs-image.c index 0d410f8..47f36b9 100644 --- a/btrfs-imag

Re: [PATCH] btrfs-progs: add the error message when open fails

Hi, David, On 2016/06/09 22:13, David Sterba wrote: On Thu, Jun 09, 2016 at 10:23:15AM +0900, Tsutomu Itoh wrote: When open in btrfs_open_devices failed, only the following message is displayed. Therefore the user doesn't understand the reason why open failed. # btrfs check /dev/sdb8

[PATCH] btrfs-progs: add the error message when open fails

When open in btrfs_open_devices failed, only the following message is displayed. Therefore the user doesn't understand the reason why open failed. # btrfs check /dev/sdb8 Couldn't open file system This patch adds the error message when open fails. Signed-off-by: Tsutomu Itoh <

Re: [PATCH v2] btrfs: use dynamic allocation for root item in create_subvol

, iscsi, etc). > > Signed-off-by: David Sterba <dste...@suse.com> Looks good to me. Reviewed-by: Tsutomu Itoh <t-i...@jp.fujitsu.com> > --- > fs/btrfs/ioctl.c | 65 > > 1 file changed, 37 insertions(+),

Re: [PATCH 1/2] btrfs: use dynamic allocation for root item in create_subvol

On 2016/04/12 3:04, David Sterba wrote: > The size of root item is more than 400 bytes, which is quite a lot of > stack space. As we do IO from inside the subvolume ioctls, we should > keep the stack usage low in case the filesystem is on top of other > layers (NFS, device mapper, iscsi, etc). >

Re: [PATCH] Btrfs: fix missing s_id setting

On 2016/04/05 17:52, Tsutomu Itoh wrote: On 2016/04/05 16:56, Anand Jain wrote: On 04/05/2016 08:08 AM, Tsutomu Itoh wrote: When fs_devices->latest_bdev is deleted or is replaced, sb->s_id has not been updated. As a result, the deleted device name is displayed by btrfs_printk. [befo

Re: [PATCH] Btrfs: fix missing s_id setting

On 2016/04/05 16:56, Anand Jain wrote: On 04/05/2016 08:08 AM, Tsutomu Itoh wrote: When fs_devices->latest_bdev is deleted or is replaced, sb->s_id has not been updated. As a result, the deleted device name is displayed by btrfs_printk. [before fix] # btrfs dev del /dev/sdc4 /mnt2 #

[PATCH] Btrfs: fix missing s_id setting

e sdc3): disk deleted /dev/sdc4 [ 84.401951] BTRFS info (device sdc3): disk added /dev/sdb6 Signed-off-by: Tsutomu Itoh <t-i...@jp.fujitsu.com> --- fs/btrfs/dev-replace.c | 5 - fs/btrfs/volumes.c | 11 +-- 2 files changed, 13 insertions(+), 3 deletions(-) diff --git a/

[PATCH] btrfs-progs: send: fix handling of multiple snapshots

We cannot send multiple snapshots at once. [before fix] # btrfs send ./snap[12] > snap12.data At subvol ./snap1 At subvol ./snap2 ERROR: parent determination failed for 0 # [after fix] # btrfs send ./snap[12] > snap12.data At subvol ./snap1 At subvol ./snap2 # Signed-off-by: Tsutomu Ito

[PATCH V2] Btrfs: fix output of compression message in btrfs_parse_options()

,space_cache,subvolid=5,subvol=/) Signed-off-by: Tsutomu Itoh <t-i...@jp.fujitsu.com> --- V1->V2: It is corrected that API doesn't change. fs/btrfs/super.c | 29 ++--- 1 file changed, 22 insertions(+), 7 deletions(-) diff --git a/fs/btrfs/super.c b/fs/btrfs/super.c inde

Re: [PATCH] Btrfs: fix output of compression message in btrfs_parse_options()

Hi, David, On 2016/01/05 23:12, David Sterba wrote: On Wed, Dec 16, 2015 at 11:57:38AM +0900, Tsutomu Itoh wrote: diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c index 974be09..dcc1f15 100644 --- a/fs/btrfs/disk-io.c +++ b/fs/btrfs/disk-io.c @@ -2709,7 +2709,7 @@ int open_ctree(struct

[PATCH] Btrfs: fix output of compression message in btrfs_parse_options()

,relatime,compress=zlib,space_cache,subvolid=5,subvol=/) Signed-off-by: Tsutomu Itoh <t-i...@jp.fujitsu.com> --- fs/btrfs/disk-io.c | 2 +- fs/btrfs/super.c | 21 ++--- 2 files changed, 15 insertions(+), 8 deletions(-) diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c index 9

[PATCH] Btrfs: change the initialization point of fs_root in open_ctree()

a5 CS: 0033 SS: 002b Therefore, the initialization point of fs_info->fs_root is changed before btrfs_recover_relocation(). Signed-off-by: Tsutomu Itoh <t-i...@jp.fujitsu.com> --- fs/btrfs/disk-io.c | 25 - 1 file changed, 12 insertions(+), 13 deletions(-)

Re: [PATCH] Btrfs: add a check of whether fs_info->fs_root is NULL in btrfs_async_reclaim_metadata_space()

On 2015/10/21 20:27, David Sterba wrote: On Wed, Oct 21, 2015 at 04:20:00PM +0900, Tsutomu Itoh wrote: Kernel panic occurred due to NULL pointer reference in can_overcommit(). Because btrfs_async_reclaim_metadata_space() passed NULL pointer to btrfs_calc_reclaim_metadata_size(). fs_info

[PATCH] Btrfs: add a check of whether fs_info->fs_root is NULL in btrfs_async_reclaim_metadata_space()

a5 CS: 0033 SS: 002b Therefore, check of whether fs_info->fs_root is NULL is added to btrfs_async_reclaim_metadata_space(). Signed-off-by: Tsutomu Itoh <t-i...@jp.fujitsu.com> --- fs/btrfs/extent-tree.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/fs/btrfs/extent-tree.c

Re: [PATCH v2] fstests: generic: Check if a bull fallocate will change extent number

On 2015/09/30 10:05, Qu Wenruo wrote: Dave Chinner wrote on 2015/09/30 07:51 +1000: On Tue, Sep 29, 2015 at 05:34:24PM +0800, Qu Wenruo wrote: Normally, a bull fallocate call on a fully written and synced file should not add an extent. Why not? Filesystems can do whatever they want with

Re: [PATCH 01/19] btrfs: qgroup: New function declaration for new reserve implement

Hi, Qu, On 2015/09/08 17:56, Qu Wenruo wrote: > Add new structures and functions for new qgroup reserve implement dirty > phase. > Which will focus on avoiding over-reserve as in that case, which means > for already reserved dirty space range, we won't reserve space again. > > This patch adds

Re: [PATCH 08/19] btrfs: qgroup: Introduce function to release/free reserved data range

Hi, Qu, On 2015/09/08 18:08, Qu Wenruo wrote: > Introduce functions btrfs_qgroup_release/free_data() to release/free > reserved data range. > > Release means, just remove the data range from data rsv map, but doesn't > free the reserved space. > This is for normal buffered write case, when data

Re: [PATCH 10/19] btrfs: delayed_ref: release and free qgroup reserved at proper timing

Hi, Qu, On 2015/09/08 18:08, Qu Wenruo wrote: > Qgroup reserved space needs to be released from inode dirty map and get > freed at different timing: > > 1) Release when the metadata is written into tree > After corresponding metadata is written into tree, any newer write will > be COWed(don't

Re: [PATCH 04/19] btrfs: qgroup: Introduce function to insert non-overlap reserve range

Hi, Qu, On 2015/09/08 18:01, Qu Wenruo wrote: > New function insert_data_ranges() will insert non-overlap reserve ranges > into reserve map. > > It provides the basis for later qgroup reserve map implement. > > Signed-off-by: Qu Wenruo > --- > fs/btrfs/qgroup.c | 124

Re: [PATCH 13/19] btrfs: extent-tree: Add new verions of btrfs_check_data_free_space

Hi, Qu, On 2015/09/08 18:22, Qu Wenruo wrote: > Add new function __btrfs_check_data_free_space() to do precious space > reservation. > > The new function will replace old btrfs_check_data_free_space(), but > until all the change is done, let's just use the new name. > > Also, export internal

Re: [PATCH 18/19] btrfs: qgroup: Cleanup old inaccurate facilities

Hi, Qu, On 2015/09/08 18:25, Qu Wenruo wrote: > Cleanup the old facilities which use old btrfs_qgroup_reserve() function > call, replace them with the newer version, and remove the "__" prefix in > them. > > Also, make btrfs_qgroup_reserve/free() functions private, as they are > now only used

Re: [PATCH] Btrfs: cleanup: remove unnecessary check before btrfs_free_path is called

On 2015/08/19 16:34, Qu Wenruo wrote: Tsutomu Itoh wrote on 2015/08/19 14:55 +0900: We need not check path before btrfs_free_path() is called because path is checked in btrfs_free_path(). Signed-off-by: Tsutomu Itoh t-i...@jp.fujitsu.com Reviewed-by: Qu Wenruo quwen...@cn.fujitsu.com

[PATCH] btrfs-progs: cleanup: remove unnecessary check before btrfs_free_path is called

We need not check path before btrfs_free_path() is called because path is checked in btrfs_free_path(). Signed-off-by: Tsutomu Itoh t-i...@jp.fujitsu.com --- cmds-check.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/cmds-check.c b/cmds-check.c index 4fa8709..8019fb0

[PATCH] Btrfs: cleanup: remove unnecessary check before btrfs_free_path is called

We need not check path before btrfs_free_path() is called because path is checked in btrfs_free_path(). Signed-off-by: Tsutomu Itoh t-i...@jp.fujitsu.com --- fs/btrfs/dev-replace.c | 3 +-- fs/btrfs/inode.c | 3 +-- fs/btrfs/tree-defrag.c | 3 +-- 3 files changed, 3 insertions(+), 6

[PATCH V2] btrfs-progs: add newline to some error messages

Added a missing newline to some error messages. Also printf() was changed to fprintf(stderr) for error message. Signed-off-by: Tsutomu Itoh t-i...@jp.fujitsu.com --- btrfs-corrupt-block.c | 2 +- cmds-check.c | 4 ++-- cmds-send.c | 4 ++-- dir-item.c| 6

Re: [PATCH] btrfs-progs: add newline to some error messages

On 2015/08/06 15:07, Zhao Lei wrote: Hi, Itho-san -Original Message- From: Tsutomu Itoh [mailto:t-i...@jp.fujitsu.com] Sent: Thursday, August 06, 2015 12:01 PM To: Zhao Lei; linux-btrfs@vger.kernel.org Subject: Re: [PATCH] btrfs-progs: add newline to some error messages On 2015/08/06

Re: [PATCH] btrfs-progs: add newline to some error messages

On 2015/08/06 12:51, Zhao Lei wrote: Hi, Itoh -Original Message- From: linux-btrfs-ow...@vger.kernel.org [mailto:linux-btrfs-ow...@vger.kernel.org] On Behalf Of Tsutomu Itoh Sent: Thursday, August 06, 2015 11:06 AM To: linux-btrfs@vger.kernel.org Subject: [PATCH] btrfs-progs: add

[PATCH] btrfs-progs: add newline to some error messages

Added a missing newline to some error messages. Signed-off-by: Tsutomu Itoh t-i...@jp.fujitsu.com --- btrfs-corrupt-block.c | 2 +- cmds-check.c | 4 ++-- cmds-send.c | 4 ++-- dir-item.c| 6 +++--- mkfs.c| 2 +- 5 files changed, 9 insertions(+), 9

Re: [PATCH v2] fstests: btrfs: Add regression test for reserved space leak.

On 2015/08/05 10:08, Qu Wenruo wrote: The regression is introduced in v4.2-rc1, with the big btrfs qgroup change. The problem is, qgroup reserved space is never freed, causing even we increase the limit, we can still hit the EDQUOT much faster than it should. Reported-by: Tsutomu Itoh t-i

Re: [PATCH v2] fstests: btrfs: Add regression test for reserved space leak.

On 2015/08/05 12:10, Dave Chinner wrote: On Wed, Aug 05, 2015 at 11:52:36AM +0900, Tsutomu Itoh wrote: On 2015/08/05 10:57, Dave Chinner wrote: On Wed, Aug 05, 2015 at 09:39:35AM +0800, Qu Wenruo wrote: Tsutomu Itoh wrote on 2015/08/05 10:26 +0900: On 2015/08/05 10:08, Qu Wenruo wrote

Re: [PATCH v2] fstests: btrfs: Add regression test for reserved space leak.

On 2015/08/05 10:57, Dave Chinner wrote: On Wed, Aug 05, 2015 at 09:39:35AM +0800, Qu Wenruo wrote: Tsutomu Itoh wrote on 2015/08/05 10:26 +0900: On 2015/08/05 10:08, Qu Wenruo wrote: +# As the reserved space freeing happens at commit_transaction time, +# without a transaction commit

[PATCH] btrfs-progs: doc: fix short explanation of restore in btrfs

Short explanation of restore is wrong. Fix it. Signed-off-by: Tsutomu Itoh t-i...@jp.fujitsu.com --- Documentation/btrfs.asciidoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/btrfs.asciidoc b/Documentation/btrfs.asciidoc index 1b3aa29..72d0e0a 100644

Re: qgroup limit clearing, was Re: Btrfs progs release 4.1

On 2015/06/23 3:18, Christian Robottom Reis wrote: On Mon, Jun 22, 2015 at 05:00:23PM +0200, David Sterba wrote: - qgroup: - show: distinguish no limits and 0 limit value - limit: ability to clear the limit I'm using kernel 4.1-rc7 as per:

Re: [PATCH] btrfs: qgroup: allow user to clear the limitation on qgroup

On 2015/06/03 15:57, Dongsheng Yang wrote: Currently, we can only set a limitation on a qgroup, but we can not clear it. This patch provide a choice to user to clear a limitation on qgroup by passing a value of CLEAR_VALUE(-1) to kernel. Reported-by: Tsutomu Itoh t-i...@jp.fujitsu.com

Re: [PATCH 2/2] btrfs-progs: qgroup: allow user to clear some limitation on qgroup.

0/5 2.19GiB 2.19GiB none none 0/257 100.02MiB100.02MiB none none Reported-by: Tsutomu Itoh t-i...@jp.fujitsu.com Signed-off-by: Dongsheng Yang yangds.f...@cn.fujitsu.com --- cmds-qgroup.c

Re: [PATCH 1/2] btrfs-progs: qgroup: show 'none' when we did not limit it on this qgroup

--- Signed-off-by: Dongsheng Yang yangds.f...@cn.fujitsu.com Tested-by: Tsutomu Itoh t-i...@jp.fujitsu.com --- qgroup.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/qgroup.c b/qgroup.c index 53815b5..dc04b03 100644 --- a/qgroup.c +++ b/qgroup.c @@ -237,10

Re: 3.18.11 - no space left on device and 'fi usage' shows lots

On 2015/04/20 5:15, Joel Best wrote: Hi all, We have recently had major issues with our large btrfs volume crashing and remounting read-only because it thinks it's out of space. The volume is 55TB on h/w raid 6 with 44TB free and the server is running Ubuntu 14.04 server x64. The problem

Re: 3.18.11 - no space left on device and 'fi usage' shows lots

On 2015/04/20 13:08, Tsutomu Itoh wrote: On 2015/04/20 5:15, Joel Best wrote: Hi all, We have recently had major issues with our large btrfs volume crashing and remounting read-only because it thinks it's out of space. The volume is 55TB on h/w raid 6 with 44TB free and the server is running

Re: [PATCH] btrfs: wait for delayed iputs on no space

to 'fix_no_space' branch. - Btrfs: fix find_free_dev_extent() malfunction in case device tree has hole It works fine to me. Thanks. Tested-by: Tsutomu Itoh t-i...@jp.fujitsu.com Any suggestions are welcome. Zhao Lei (1): btrfs: wait for delayed iputs on no space fs/btrfs/extent-tree.c

[PATCH] Btrfs: fix typo of variable in scrub_stripe

The address that should be freed is not 'ppath' but 'path'. Signed-off-by: Tsutomu Itoh t-i...@jp.fujitsu.com --- fs/btrfs/scrub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/btrfs/scrub.c b/fs/btrfs/scrub.c index f2bb13a..403fbdb 100644 --- a/fs/btrfs/scrub.c +++ b

[PATCH] btrfs-progs: doc: fix format of btrfs-replace

. ... ... The format of 'B' option is wrong. So, fix it. Signed-off-by: Tsutomu Itoh t-i...@jp.fujitsu.com --- NOTE: This patch based on v3.18.x branch. Documentation/btrfs-replace.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/btrfs-replace.txt b/Documentation

[PATCH] btrfs-progs: doc: fix incorrect format of 'l' option in mkfs.btrfs

1 got 65536 [XMLTO] mkfs.btrfs.8 [GZ] mkfs.btrfs.8.gz rm mkfs.btrfs.8 mkfs.btrfs.xml So, fix it. Signed-off-by: Tsutomu Itoh t-i...@jp.fujitsu.com --- Documentation/mkfs.btrfs.txt | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/Documentation

[PATCH] btrfs-progs: doc: fix incorrect subvol name

Subvolume name is wrong. Fix it. Signed-off-by: Tsutomu Itoh t-i...@jp.fujitsu.com --- Documentation/btrfs-convert.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/btrfs-convert.txt b/Documentation/btrfs-convert.txt index ed61d14..1eff0bf 100644

Re: Lockups with btrfs on 3.16-rc1 - bisected

On 2014/06/20 8:21, Waiman Long wrote: On 06/19/2014 05:50 PM, Chris Mason wrote: I would like to take back my comments. I took out the read_lock, but the process still hang while doing file activities on btrfs filesystem. So the problem is trickier than I thought. Below are the stack

[3.16-rc1] BUG: soft lockup - CPU#0 stuck for 23s! [kworker/u25:4:5189]

I encountered soft lockup when executing 'xfstests btrfs/042' on 3.16-rc1. [ 1121.983975] BTRFS: device fsid 8cc641f9-563a-4d62-9157-9503156ce62c devid 1 transid 4 /dev/sdc5 [ 1121.987994] BTRFS info (device sdc5): disk space caching is enabled [ 1121.987999] BTRFS: flagging fs

Re: [3.16-rc1] BUG: soft lockup - CPU#0 stuck for 23s! [kworker/u25:4:5189]

Hi Chris, On 2014/06/17 2:56, Chris Mason wrote: On 06/16/2014 02:35 AM, Tsutomu Itoh wrote: I encountered soft lockup when executing 'xfstests btrfs/042' on 3.16-rc1. Did we recover, or was it stuck forever? The following messages are repeatedly output. And stuck forever. [ 1147.942181

Re: [3.16-rc1] BUG: soft lockup - CPU#0 stuck for 23s! [kworker/u25:4:5189]

On 2014/06/17 8:52, Chris Mason wrote: On 06/16/2014 07:28 PM, Tsutomu Itoh wrote: Hi Chris, On 2014/06/17 2:56, Chris Mason wrote: On 06/16/2014 02:35 AM, Tsutomu Itoh wrote: I encountered soft lockup when executing 'xfstests btrfs/042' on 3.16-rc1. Did we recover, or was it stuck

Re: [3.16-rc1] BUG: soft lockup - CPU#0 stuck for 23s! [kworker/u25:4:5189]

On 2014/06/17 10:11, Chris Mason wrote: On 06/16/2014 07:57 PM, Tsutomu Itoh wrote: On 2014/06/17 8:52, Chris Mason wrote: On 06/16/2014 07:28 PM, Tsutomu Itoh wrote: Hi Chris, On 2014/06/17 2:56, Chris Mason wrote: On 06/16/2014 02:35 AM, Tsutomu Itoh wrote: I encountered soft lockup

Re: [3.16-rc1] BUG: soft lockup - CPU#0 stuck for 23s! [kworker/u25:4:5189]

On 2014/06/17 9:47, Chris Mason wrote: On 06/16/2014 07:57 PM, Tsutomu Itoh wrote: On 2014/06/17 8:52, Chris Mason wrote: On 06/16/2014 07:28 PM, Tsutomu Itoh wrote: Hi Chris, On 2014/06/17 2:56, Chris Mason wrote: On 06/16/2014 02:35 AM, Tsutomu Itoh wrote: I encountered soft lockup when

Re: [3.16-rc1] BUG: soft lockup - CPU#0 stuck for 23s! [kworker/u25:4:5189]

On 2014/06/17 11:10, Tsutomu Itoh wrote: On 2014/06/17 9:47, Chris Mason wrote: On 06/16/2014 07:57 PM, Tsutomu Itoh wrote: On 2014/06/17 8:52, Chris Mason wrote: On 06/16/2014 07:28 PM, Tsutomu Itoh wrote: Hi Chris, On 2014/06/17 2:56, Chris Mason wrote: On 06/16/2014 02:35 AM, Tsutomu

  1   2   3   >