Hi, Chris,
(2011/07/08 5:26), Chris Mason wrote:
Excerpts from Tsutomu Itoh's message of 2011-07-01 04:11:28 -0400:
Hi, Miao,
(2011/06/30 15:32), Miao Xie wrote:
Hi, Itoh-san
Could you test the following patch to check whether it can fix the bug or
not?
I have tested it on my x86_64
Hi, Chris,
(2011/07/08 5:26), Chris Mason wrote:
Excerpts from Tsutomu Itoh's message of 2011-07-01 04:11:28 -0400:
Hi, Miao,
(2011/06/30 15:32), Miao Xie wrote:
Hi, Itoh-san
Could you test the following patch to check whether it can fix the bug or
not?
I have tested it on my x86_64
Hi, Miao,
(2011/06/30 15:32), Miao Xie wrote:
Hi, Itoh-san
Could you test the following patch to check whether it can fix the bug or not?
I have tested it on my x86_64 machine by your test script for two days, it
worked well.
I ran my test script about a day, I was not able to reproduce
(2011/06/28 23:22), Josef Bacik wrote:
On 06/27/2011 11:34 PM, Tsutomu Itoh wrote:
The return value of btrfs_lookup_dentry is checked so that
the panic such as illegal address reference should not occur.
Signed-off-by: Tsutomu Itoh t-i...@jp.fujitsu.com
Nack, please fix btrfs_lookup_dentry
The return value of btrfs_lookup_dentry is checked so that
the panic such as illegal address reference should not occur.
Signed-off-by: Tsutomu Itoh t-i...@jp.fujitsu.com
---
V1-V2: unnecessary BUG_ON was deleted
V2-V3: to return -ENOENT instead of NULL when no entry was found,
return
The return value of btrfs_lookup_dentry is checked so that
the panic such as illegal address reference should not occur.
Signed-off-by: Tsutomu Itoh t-i...@jp.fujitsu.com
---
fs/btrfs/inode.c |1 +
fs/btrfs/ioctl.c | 10 +-
2 files changed, 10 insertions(+), 1 deletions(-)
diff
The return value of btrfs_lookup_dentry is checked so that
the panic such as illegal address reference should not occur.
Signed-off-by: Tsutomu Itoh t-i...@jp.fujitsu.com
---
V1 - V2: unnecessary BUG_ON was deleted
fs/btrfs/ioctl.c | 10 +-
1 files changed, 9 insertions(+), 1
The following functions always return 0.
- add_delayed_ref_head()
- add_delayed_tree_ref()
- add_delayed_data_ref()
- add_excluded_extent()
Therefore, check by BUG_ON() is unnecessary at the caller of these
functions.
Signed-off-by: Tsutomu Itoh t-i...@jp.fujitsu.com
---
fs/btrfs
(2011/06/21 9:40), Chris Mason wrote:
Excerpts from David Sterba's message of 2011-06-20 20:24:35 -0400:
On Mon, Jun 20, 2011 at 08:41:39AM +0900, Tsutomu Itoh wrote:
(2011/06/19 13:34), Tsutomu Itoh wrote:
I've fixed this up by moving the delayed metadata run down into the
snapshot creation
(2011/06/19 13:34), Tsutomu Itoh wrote:
Hi, Chris,
(2011/06/18 6:12), Chris Mason wrote:
Hi everyone,
I think I tracked down the oops we were seeing Tsutomu Itoh's balance
test. The delayed metadata insertion code was allowing delayed updates
to queue up and be process after the snapshot
Hi, Chris,
(2011/06/18 6:12), Chris Mason wrote:
Hi everyone,
I think I tracked down the oops we were seeing Tsutomu Itoh's balance
test. The delayed metadata insertion code was allowing delayed updates
to queue up and be process after the snapshot was created.
I've fixed this up by moving
When btrfs_join_transaction()/btrfs_join_transaction_nolock() fails,
we should call btrfs_std_error() properly for filesystem to readonly.
Signed-off-by: Tsutomu Itoh t-i...@jp.fujitsu.com
---
This patch is dependent on
http://marc.info/?l=linux-btrfsm=130761239706076w=2
(it is necessary
When btrfs_start_ioctl_transaction() fails, we should call
btrfs_std_error() properly for filesystem to readonly.
Signed-off-by: Tsutomu Itoh t-i...@jp.fujitsu.com
---
This patch needs btrfs_abort_transaction function.
fs/btrfs/ioctl.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions
When btrfs_start_transaction() fails, we should call btrfs_std_error()
properly for filesystem to readonly.
(in this patch, forced readonly framework is used)
Signed-off-by: Tsutomu Itoh t-i...@jp.fujitsu.com
---
fs/btrfs/file.c|1 +
fs/btrfs/inode.c | 34
(2011/06/10 0:51), David Sterba wrote:
On Thu, Jun 09, 2011 at 06:38:52PM +0900, Tsutomu Itoh wrote:
When btrfs_start_transaction() fails, we should call btrfs_std_error()
properly for filesystem to readonly.
(in this patch, forced readonly framework is used)
Signed-off-by: Tsutomu Itoh t-i
Hi liubo,
(2011/06/07 14:31), liubo wrote:
On 06/06/2011 04:33 PM, Tsutomu Itoh wrote:
Hi,
I encountered following panic using 'btrfs-unstable + for-linus'
kernel.
I ran btrfs fi bal /test5 command, and mount option of /test5
is as follows:
/dev/sdc3 on /test5 type btrfs (rw
(2011/06/07 14:59), Tsutomu Itoh wrote:
Hi liubo,
(2011/06/07 14:31), liubo wrote:
On 06/06/2011 04:33 PM, Tsutomu Itoh wrote:
Hi,
I encountered following panic using 'btrfs-unstable + for-linus'
kernel.
I ran btrfs fi bal /test5 command, and mount option of /test5
is as follows
(2011/06/07 15:17), Tsutomu Itoh wrote:
(2011/06/07 14:59), Tsutomu Itoh wrote:
Hi liubo,
(2011/06/07 14:31), liubo wrote:
On 06/06/2011 04:33 PM, Tsutomu Itoh wrote:
Hi,
I encountered following panic using 'btrfs-unstable + for-linus'
kernel.
I ran btrfs fi bal /test5 command
(2011/06/08 0:46), Chris Mason wrote:
Excerpts from liubo's message of 2011-06-07 04:36:56 -0400:
On 06/07/2011 04:24 PM, Tsutomu Itoh wrote:
(2011/06/07 15:17), Tsutomu Itoh wrote:
(2011/06/07 14:59), Tsutomu Itoh wrote:
Hi liubo,
(2011/06/07 14:31), liubo wrote:
On 06/06/2011 04:33 PM
Hi,
I encountered following panic using 'btrfs-unstable + for-linus'
kernel.
I ran btrfs fi bal /test5 command, and mount option of /test5
is as follows:
/dev/sdc3 on /test5 type btrfs (rw,space_cache,compress=lzo,inode_cache)
Thanks,
Tsutomu
Hi liubo,
(2011/06/01 19:44), Tsutomu Itoh wrote:
Hi, liubo,
(2011/06/01 18:42), liubo wrote:
On 06/01/2011 04:12 PM, liubo wrote:
On 06/01/2011 03:44 PM, liubo wrote:
On 05/31/2011 08:27 AM, Tsutomu Itoh wrote:
The panic occurred when 'btrfs fi bal /test5' was executed.
/test5
Hi, liubo,
(2011/06/01 18:42), liubo wrote:
On 06/01/2011 04:12 PM, liubo wrote:
On 06/01/2011 03:44 PM, liubo wrote:
On 05/31/2011 08:27 AM, Tsutomu Itoh wrote:
The panic occurred when 'btrfs fi bal /test5' was executed.
/test5 is as follows:
# mount -o space_cache,compress=lzo /dev/sdc3
(2011/05/31 15:13), liubo wrote:
On 05/31/2011 12:31 PM, Tsutomu Itoh wrote:
(2011/05/31 10:13), Chris Mason wrote:
Excerpts from Tsutomu Itoh's message of 2011-05-30 20:27:51 -0400:
The panic occurred when 'btrfs fi bal /test5' was executed.
/test5 is as follows:
# mount -o space_cache
Hi,
(2011/05/31 19:16), Arne Jansen wrote:
The following functions had a struct btrfs_root * parameter which went
unused:
btrfs_set_block_group_rw
btrfs_destroy_delayed_refs
btrfs_csum_data
extent_data_ref_count
copy_to_sk
Signed-off-by: Arne Jansen sensi...@gmx.net
---
The panic occurred when 'btrfs fi bal /test5' was executed.
/test5 is as follows:
# mount -o space_cache,compress=lzo /dev/sdc3 /test5
#
# btrfs fi sh /dev/sdc3
Label: none uuid: 38ec48b2-a64b-4225-8cc6-5eb08024dc64
Total devices 5 FS bytes used 7.87MB
devid1 size 10.00GB
(2011/05/31 10:13), Chris Mason wrote:
Excerpts from Tsutomu Itoh's message of 2011-05-30 20:27:51 -0400:
The panic occurred when 'btrfs fi bal /test5' was executed.
/test5 is as follows:
# mount -o space_cache,compress=lzo /dev/sdc3 /test5
#
# btrfs fi sh /dev/sdc3
Label: none uuid:
The error code is returned instead of calling BUG_ON when
btrfs_previous_item returns the error.
Signed-off-by: Tsutomu Itoh t-i...@jp.fujitsu.com
---
fs/btrfs/volumes.c |5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
index
The error code is returned instead of calling BUG_ON when
btrfs_del_item returns the error.
Signed-off-by: Tsutomu Itoh t-i...@jp.fujitsu.com
---
fs/btrfs/file-item.c | 10 ++
fs/btrfs/root-tree.c |6 +-
fs/btrfs/tree-log.c | 10 +++---
fs/btrfs/volumes.c |4
Currently, btrfs_truncate_item and btrfs_extend_item returns only 0.
So, the check by BUG_ON in the caller is unnecessary.
Signed-off-by: Tsutomu Itoh t-i...@jp.fujitsu.com
---
fs/btrfs/ctree.c |8 ++--
fs/btrfs/dir-item.c|1 -
fs/btrfs/extent-tree.c |3 ---
fs/btrfs
When read_one_inode() fails, error code is returned to caller instead
of BUG_ON().
Signed-off-by: Tsutomu Itoh t-i...@jp.fujitsu.com
---
fs/btrfs/tree-log.c | 24 ++--
1 files changed, 18 insertions(+), 6 deletions(-)
diff --git a/fs/btrfs/tree-log.c b/fs/btrfs/tree-log.c
If return value of btrfs_inc_extent_ref() is not 0, BUG() is called.
Signed-off-by: Tsutomu Itoh t-i...@jp.fujitsu.com
---
fs/btrfs/tree-log.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/fs/btrfs/tree-log.c b/fs/btrfs/tree-log.c
index f997ec0..23fb42d 100644
--- a/fs
(2011/04/22 18:41), David Sterba wrote:
Signed-off-by: David Sterba dste...@suse.cz
---
fs/btrfs/extent-tree.c |6 --
1 files changed, 0 insertions(+), 6 deletions(-)
diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c
index 31f33ba..c97ceab 100644
---
(2011/04/22 21:45), David Sterba wrote:
Hi,
On Fri, Apr 22, 2011 at 06:05:40PM +0900, Tsutomu Itoh wrote:
It is necessary to unlock mutex_lock before it return an error when
btrfs_alloc_path() fails.
good catch! however I suggest to move the mutex_lock after the
allocation and check
It is necessary to unlock mutex_lock before it return an error when
btrfs_alloc_path() fails.
Signed-off-by: Tsutomu Itoh t-i...@jp.fujitsu.com
---
fs/btrfs/tree-log.c |7 +--
1 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/fs/btrfs/tree-log.c b/fs/btrfs/tree-log.c
index
'trans' and 'root' argument not used in fixup_low_keys() are deleted.
And, the argument that became unnecessary is deleted about the caller
of fixup_low_keys().
Signed-off-by: Tsutomu Itoh t-i...@jp.fujitsu.com
---
fs/btrfs/ctree.c | 49 ---
fs
(2011/04/21 19:59), David Sterba wrote:
Hi,
On Thu, Apr 21, 2011 at 06:54:45PM +0900, Tsutomu Itoh wrote:
'trans' and 'root' argument not used in fixup_low_keys() are deleted.
And, the argument that became unnecessary is deleted about the caller
of fixup_low_keys().
heh, coincidence
The check on the return value of kmalloc() is added to some places.
Signed-off-by: Tsutomu Itoh t-i...@jp.fujitsu.com
---
V1-V2: adding check code to relocate_one_extent() for the readability,
which is suggested by David Sterba.
fs/btrfs/extent-tree.c |4
fs/btrfs/inode.c
The error processing of several places is changed like setting the
error number only at the error.
Signed-off-by: Tsutomu Itoh t-i...@jp.fujitsu.com
---
fs/btrfs/inode.c | 15 +--
1 files changed, 9 insertions(+), 6 deletions(-)
diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c
The check on the return value of kmalloc() in inode.c is added.
Signed-off-by: Tsutomu Itoh t-i...@jp.fujitsu.com
---
fs/btrfs/inode.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c
index a4157cf..c718d27 100644
--- a/fs/btrfs
(2011/04/12 7:46), Yoshinori Sano wrote:
Thank you for your review.
I modified the previous patch.
Other points still existed. I'm sorry not to point it out at a time.
Specifically, all the callers that calls the following are modified
because of the lack of return value check:
-
(2011/04/09 11:23), Yoshinori Sano wrote:
This patch checks return value of btrfs_alloc_path() and removes BUG_ON().
Signed-off-by: Yoshinori Sano yoshinori.s...@gmail.com
---
fs/btrfs/dir-item.c|2 ++
fs/btrfs/extent-tree.c | 12
fs/btrfs/file-item.c |6
Free btrfs_trans_handle if btrfs_commit_transaction_async() fails.
Signed-off-by: Tsutomu Itoh t-i...@jp.fujitsu.com
---
fs/btrfs/ioctl.c |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff -urNp linux-2.6.39-rc1/fs/btrfs/ioctl.c
linux-2.6.39-rc1.new/fs/btrfs/ioctl.c
--- linux
Sorry. Ignore previous patch.
New patch is as follows.
Thanks,
Tsutomu
(2011/04/04 10:09), Tsutomu Itoh wrote:
Free btrfs_trans_handle if btrfs_commit_transaction_async() fails.
Signed-off-by: Tsutomu Itoh t-i...@jp.fujitsu.com
---
fs/btrfs/ioctl.c |4 +++-
1 file changed, 3
,relatime,compress 0 0
[after]
$ mount | grep sdc2
/dev/sdc2 on /test12 type btrfs (rw,space_cache,compress=lzo)
$ cat /proc/mounts | grep sdc2
/dev/sdc2 /test12 btrfs rw,relatime,compress=lzo,space_cache 0 0
Signed-off-by: Tsutomu Itoh t-i...@jp.fujitsu.com
---
fs/btrfs/super.c
-by: Tsutomu Itoh t-i...@jp.fujitsu.com
---
fs/btrfs/file.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -urNp linux-2.6.39-rc1/fs/btrfs/file.c linux-2.6.39-rc1.new/fs/btrfs/file.c
--- linux-2.6.39-rc1/fs/btrfs/file.c2011-03-30 04:09:47.0 +0900
+++ linux-2.6.39-rc1.new/fs
This patch is checking return value of read_tree_block(),
and if it is NULL, error processing.
Signed-off-by: Tsutomu Itoh t-i...@jp.fujitsu.com
---
fs/btrfs/ctree.c |3 +++
fs/btrfs/extent-tree.c |6 ++
fs/btrfs/relocation.c |6 ++
3 files changed, 15 insertions
This patch changes some BUG_ON() to the error return.
(but, most callers still use BUG_ON())
Signed-off-by: Tsutomu Itoh t-i...@jp.fujitsu.com
---
fs/btrfs/ctree.c |3 ++-
fs/btrfs/disk-io.c |5 -
fs/btrfs/extent-tree.c | 25 ++---
fs/btrfs/file-item.c
(2011/03/05 16:01), Itaru Kitayama wrote:
Hi Miao,
The V3 patch on top of the next-rc fails to pass an xfstests test 13.
In the btrfs link path, we need to reserve one more metadata in the
trans_block_rsv for the delayed inode update (if needed) to complete.
Miao's patch
Adding the check on the return value of btrfs_alloc_path() to several places.
And, some of callers are modified by this change.
Signed-off-by: Tsutomu Itoh t-i...@jp.fujitsu.com
---
fs/btrfs/compression.c | 11 +++
fs/btrfs/dir-item.c| 13 +
fs/btrfs/file-item.c
Sano-san,
(2011/02/14 22:57), Yoshinori Sano wrote:
2011年2月14日8:57 Tsutomu Itoh t-i...@jp.fujitsu.com:
(2011/02/12 20:17), Yoshinori Sano wrote:
To make Btrfs code more robust, several return value checks where memory
allocation can fail are introduced. I use BUG_ON where I don't know how
(2011/02/12 20:17), Yoshinori Sano wrote:
To make Btrfs code more robust, several return value checks where memory
allocation can fail are introduced. I use BUG_ON where I don't know how
to handle the error properly, which increases the number of using the
notorious BUG_ON, though.
I add the check on the return value of alloc_extent_map() to several places.
In addition, alloc_extent_map() returns only the address or NULL.
Therefore, check by IS_ERR() is unnecessary. So, I remove IS_ERR() checking.
Signed-off-by: Tsutomu Itoh t-i...@jp.fujitsu.com
---
fs/btrfs/extent-tree.c
)
- The error code is returned in the place where the error can be
easily returned.
Signed-off-by: Tsutomu Itoh t-i...@jp.fujitsu.com
---
V1-V2:
- In btrfs_init_new_device(), if btrfs_start_transaction() failed,
it is necessary to free device-name.
fs/btrfs/extent-tree.c |7 +--
fs/btrfs
When btrfs_alloc_path() fails, btrfs_free_path() need not be called.
Therefore, it changes the branch ahead.
Signed-off-by: Tsutomu Itoh t-i...@jp.fujitsu.com
---
fs/btrfs/inode.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -urNp linux-2.6.38-rc3/fs/btrfs/inode.c
linux-2.6.38
returned.
As a long-term plan:
- BUG_ON() is reduced by using the forced-readonly framework, etc.
Signed-off-by: Tsutomu Itoh t-i...@jp.fujitsu.com
---
fs/btrfs/disk-io.c |5 +
fs/btrfs/extent-tree.c |2 +-
fs/btrfs/inode.c | 24
fs/btrfs/ioctl.c
btrfs_start_ioctl_transaction() returns ERR_PTR(), not NULL.
So, it is necessary to use IS_ERR() to check the return value.
Signed-off-by: Tsutomu Itoh t-i...@jp.fujitsu.com
---
fs/btrfs/ioctl.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -urNp linux-2.6.38-rc1/fs/btrfs
(2011/01/21 1:09), Josef Bacik wrote:
I'd rather we go through and have these things return an error than do a
BUG_ON(). We're moving towards a more stable BTRFS, not one that panics more
often :).
Yes, I also think so.
This patch is my first step.
My modification policy is as follows:
1.
(2011/01/21 8:47), Tsutomu Itoh wrote:
(2011/01/21 1:09), Josef Bacik wrote:
I'd rather we go through and have these things return an error than do a
BUG_ON(). We're moving towards a more stable BTRFS, not one that panics more
often :).
Yes, I also think so.
This patch is my first step
Should check if functions returns NULL or not.
Signed-off-by: Tsutomu Itoh t-i...@jp.fujitsu.com
---
fs/btrfs/ctree.c |6 ++
fs/btrfs/disk-io.c |8
fs/btrfs/extent_io.c |2 ++
3 files changed, 16 insertions(+), 0 deletions(-)
diff --git a/fs/btrfs/ctree.c b/fs
In btrfs_read_fs_root_no_radix(), 'root' is not freed if
btrfs_search_slot() returns error.
Signed-off-by: Tsutomu Itoh t-i...@jp.fujitsu.com
---
disk-io.c |1 +
1 file changed, 1 insertion(+)
diff -urNp linux-2.6.37-rc7/fs/btrfs/disk-io.c
linux-2.6.37-rc7.new/fs/btrfs/disk-io.c
--- linux
(2010/12/16 17:44), Tsutomu Itoh wrote:
Hi,
In btrfs, inode number is increased each time a new file or directory
is made.
Therefore, if the making deletion of the file is repeated, value of
'i_ino' increases rapidly.
For example, inode number changes as follows.
$ touch foo
(2010/12/08 19:01), liubo wrote:
While compiling btrfs, I got belows:
CC [M] fs/btrfs/inode.o
fs/btrfs/inode.c: In function ‘btrfs_end_dio_bio’:
fs/btrfs/inode.c:5720: warning: format ‘%lu’ expects type ‘long unsigned
int’, but argument 4 has type ‘sector_t’
LD [M] fs/btrfs/btrfs.o
Hi,
I think that the disk allocation size of each file becomes a monotone increase
when the file is made.
But, it sometimes return to 0. Is it correct?
The result of the test at 2.6.37-rc4 is shown below.
(see inode no. 291)
# df -T /test14
FilesystemType 1K-blocks Used
(2010/12/08 5:15), Chris Mason wrote:
Excerpts from Mike Fedyk's message of 2010-12-07 15:07:08 -0500:
On Tue, Dec 7, 2010 at 11:29 AM, Chris Mason chris.ma...@oracle.com wrote:
Excerpts from Mike Fedyk's message of 2010-12-07 14:16:55 -0500:
On Tue, Dec 7, 2010 at 10:44 AM, Chris Mason
Hi,
I found 1 typo.
(2010/12/01 19:21), liubo wrote:
Since there is a filesystem state, we should deal with it carefully at mount,
umount and remount.
- At mount, the FS state should be checked if there is error on these FS.
If it does have, btrfsck is recommended.
- At umount, the FS
1970 /test1
[after]
# date
Tue Nov 16 18:06:05 JST 2010
# mkfs.btrfs /dev/sdd10
# mount /dev/sdd10 /test1
# ls -ld /test1
dr-xr-xr-x 1 root root 0 Nov 16 18:06 /test1
Thanks,
Tsutomu
Signed-off-by: Tsutomu Itoh t-i...@jp.fujitsu.com
---
utils.c |9 +
1 file changed, 9
Hi.
(2010/11/11 16:48), Helmut Hullen wrote:
Hallo, Hugo,
Du meintest am 10.11.10:
findfs LABEL=MM2
shows /dev/sdd2 (the first partition)
file -s /dev/sdd2
file -s /dev/sdc3
shows LABEL=MM2 for both partitions
mount LABEL=MM2 /srv/MM
doesn't work
201 - 267 of 267 matches
Mail list logo
