Re: [RFC PATCH 2/3] fs: add RWF_ENCODED for writing compressed data

2019-09-25 Thread Theodore Y. Ts'o
On Wed, Sep 25, 2019 at 08:07:12AM -0400, Colin Walters wrote: > > > On Wed, Sep 25, 2019, at 3:11 AM, Dave Chinner wrote: > > > > We're talking about user data read/write access here, not some > > special security capability. Access to the data has already been > > permission checked, so why sho

Re: [PATCH 2/3] ext4: fix inode rwsem regression

2019-09-23 Thread Theodore Y. Ts'o
On Mon, Sep 23, 2019 at 12:10:42PM +0200, Jan Kara wrote: > On Wed 11-09-19 11:45:16, Goldwyn Rodrigues wrote: > > From: Goldwyn Rodrigues > > > > This is similar to 942491c9e6d6 ("xfs: fix AIM7 regression") > > Apparently our current rwsem code doesn't like doing the trylock, then > > lock for r

Re: inline extents

2018-09-20 Thread Theodore Y. Ts'o
On Wed, Sep 19, 2018 at 09:18:16PM -0600, Chris Murphy wrote: > > ext4 has inline data, too, so there's every chance grub will corrupt > > ext4 filesystems with tit's wonderful new feature. I'm not sure if > > the ext4 metadata cksums cover the entire inode and inline data, but > > if they do it's

Re: [RFC v2 3/4] ext4: add verifier check for symlink with append/immutable flags

2018-05-13 Thread Theodore Y. Ts'o
On Fri, May 11, 2018 at 11:12:18PM +0200, Jan Kara wrote: > On Thu 10-05-18 16:13:58, Luis R. Rodriguez wrote: > > The Linux VFS does not allow a way to set append/immuttable > > attributes to symlinks, this is just not possible. If this is > > detected inform the user as the filesystem must be cor

Re: Inconsistent behavior of fsync in btrfs

2018-04-29 Thread Theodore Y. Ts'o
On Sun, Apr 29, 2018 at 03:55:39PM -0500, Vijay Chidambaram wrote: > In the spirit of clarifying fsync behavior, we have one more case > where we'd like to find out what should be expected. > > Consider this: > > Mkdir A > Creat A/bar > Fsync A/bar > Rename A to B > Fsync B/bar > -- Crash -- > >

Re: Inconsistent behavior of fsync in btrfs

2018-04-27 Thread Theodore Y. Ts'o
On Fri, Apr 27, 2018 at 11:33:29AM -0600, Chris Mason wrote: > My goal for the fsync tree log was to make it just do the right thing most > of the time. We mostly got there, thanks to a ton of fixes and test cases > from Filipe. > > fsync(some file) -- all the names for this file will exist, with

Re: Symlink not persisted even after fsync

2018-04-15 Thread Theodore Y. Ts'o
On Sun, Apr 15, 2018 at 07:10:52PM -0500, Vijay Chidambaram wrote: > > I don't think this is what the paper's ext3-fast does. All the paper > says is if you have a file system where the fsync of a file persisted > only data related to that file, it would increase performance. > ext3-fast is the na

Re: Symlink not persisted even after fsync

2018-04-15 Thread Theodore Y. Ts'o
On Sat, Apr 14, 2018 at 08:35:45PM -0500, Vijaychidambaram Velayudhan Pillai wrote: > I was one of the authors on that paper, and I didn't know until today you > didn't like that work :) The paper did *not* suggest we support invented > guarantees without considering the performance impact. I had

Re: Symlink not persisted even after fsync

2018-04-14 Thread Theodore Y. Ts'o
On Sat, Apr 14, 2018 at 08:13:28PM -0500, Vijay Chidambaram wrote: > > We are *not* saying an fsync on a symlink file has to result in any > action on the original file. We understand the lack of ordering > constraints here. The problem is you're not being precise here. The fsync(2) system call

Re: Symlink not persisted even after fsync

2018-04-14 Thread Theodore Y. Ts'o
The only thing I would add to Dave's comments is that a lot of these formal semantics are de facto, and not de jure. If you take a look at POSIX or the Single Unix Specification, they are remarkably silent about how fsync works. In fact POSIX/SUS doesn't even define "fsync on a directory". In th

RE: How to get the default subvolume?

2011-07-08 Thread Yang, Yi Y
equent changes of btrfs superblock and >other metadata. -Original Message- From: linux-btrfs-ow...@vger.kernel.org [mailto:linux-btrfs-ow...@vger.kernel.org] On Behalf Of Hugo Mills Sent: Friday, July 08, 2011 6:13 PM To: Yang, Yi Y Cc: linux-btrfs@vger.kernel.org Subject: Re: Ho

RE: How to get the default subvolume?

2011-07-08 Thread Yang, Yi Y
That's great, can you share your source code with me? I'm very eager to get this now :-) -Original Message- From: Hugo Mills [mailto:h...@carfax.org.uk] Sent: Friday, July 08, 2011 5:58 PM To: Yang, Yi Y Cc: linux-btrfs@vger.kernel.org Subject: Re: How to get the default subv

[PATCH v2 3/3] btrfs: fix typo 'testeing' -> 'testing'

2011-05-10 Thread y
From: Sergei Trofimovich Signed-off-by: Sergei Trofimovich --- fs/btrfs/inode.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c index 7cd8ab0..72650ce 100644 --- a/fs/btrfs/inode.c +++ b/fs/btrfs/inode.c @@ -1310,7 +1310,7 @@ stati

[PATCH v2 2/3] btrfs: typo: 'btrfS' -> 'btrfs'

2011-05-10 Thread y
From: Sergei Trofimovich Signed-off-by: Sergei Trofimovich --- fs/btrfs/dir-item.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/btrfs/dir-item.c b/fs/btrfs/dir-item.c index c62f02f..dec9348 100644 --- a/fs/btrfs/dir-item.c +++ b/fs/btrfs/dir-item.c @@ -452,7 +452

[PATCH v2 1/3] btrfs: don't spin in shrink_delalloc if there is nothing to free

2011-05-10 Thread y
From: Sergei Trofimovich Observed as a large delay when --mixed filesystem is filled up. Test example: 1. create tiny --mixed FS: $ dd if=/dev/zero of=2G.img seek=$((2048 * 1024 * 1024 - 1)) count=1 bs=1 $ mkfs.btrfs --mixed 2G.img $ mount -oloop 2G.img /mnt/ut/ 2. Try to fill it up:

[PATCH v2 0/3] btrfs: don't spin in shrink_delalloc if there is nothing to free

2011-05-10 Thread y
From: Sergei Trofimovich The really interesting commit is [PATCH 1/3] btrfs: don't spin in shrink_delalloc if there is nothing to free which fixes hogs on ENOSPC for me. The rest of patches are cleanup. Change since v1: - Added Josef's Reviewed-by - Fixed my MTA and patch numbering Thanks!