Re: [Cluster-devel] [PATCH 16/18] gfs2: use generic posix ACL infrastructure

2013-12-11 Thread Steven Whitehouse
Hi, On Wed, 2013-12-11 at 02:42 -0800, Christoph Hellwig wrote: plain text document attachment (0016-gfs2-use-generic-posix-ACL-infrastructure.patch) This contains some major refactoring for the create path so that inodes are created with the right mode to start with instead of fixing it up

Re: [Cluster-devel] [PATCH 16/18] gfs2: use generic posix ACL infrastructure

2013-12-06 Thread Christoph Hellwig
On Wed, Dec 04, 2013 at 12:12:37PM +, Steven Whitehouse wrote: error = posix_acl_equiv_mode(acl, mode); + if (error 0) Andy Price has pointed out a missing return error; here - if (error = 0) { - posix_acl_release(acl); +

Re: [Cluster-devel] [PATCH 16/18] gfs2: use generic posix ACL infrastructure

2013-12-04 Thread Steven Whitehouse
Hi, On Sun, 2013-12-01 at 03:59 -0800, Christoph Hellwig wrote: plain text document attachment (0016-gfs2-use-generic-posix-ACL-infrastructure.patch) This contains some major refactoring for the create path so that inodes are created with the right mode to start with instead of fixing it up