Re: [PATCH, RFC] btrfs-progs: require mkfs -f force option to overwrite filesystem or partition table

2013-02-28 Thread mpbtr
Hi, writing from a user perspective : The -f option would be highly appreciated. I agree with Dave Chinner and I guess most people who operate maschines do as well. Cheers, Markus On Tue, 26 Feb 2013, Dave Chinner wrote: On Tue, Feb 26, 2013 at 01:25:11PM +0900, Tsutomu Itoh wrote: On

Re: [PATCH, RFC] btrfs-progs: require mkfs -f force option to overwrite filesystem or partition table

2013-02-26 Thread Tsutomu Itoh
On 2013/02/26 16:05, Dave Chinner wrote: On Tue, Feb 26, 2013 at 01:25:11PM +0900, Tsutomu Itoh wrote: On 2013/02/26 13:06, Eric Sandeen wrote: On 2/25/13 9:55 PM, Tsutomu Itoh wrote: EXPERIMENTAL... It's certainly so. However, I think that we should not add the option that it troubles a lot

Re: [PATCH, RFC] btrfs-progs: require mkfs -f force option to overwrite filesystem or partition table

2013-02-26 Thread Martin Steigerwald
Am Dienstag, 26. Februar 2013 schrieb Tsutomu Itoh: Therefore I want you to revert commit:2a2d8e1962e8b6cda7b0a7584f6d2fb95d442cb6. btrfs-progs: require mkfs -f force option to overwrite filesystem or partition table How do you think about it? What if you submit a patch to

Re: [PATCH, RFC] btrfs-progs: require mkfs -f force option to overwrite filesystem or partition table

2013-02-26 Thread David Sterba
On Tue, Feb 26, 2013 at 08:39:52AM +0900, Tsutomu Itoh wrote: This means that it is now required to change all occurrences of mkfs.btrfs to mkfs.btrfs -f everywhere. Can't we first establish a I also think so. It means -f is not significant to me, I think. (Most of my test scripts fails

Re: [PATCH, RFC] btrfs-progs: require mkfs -f force option to overwrite filesystem or partition table

2013-02-26 Thread Goffredo Baroncelli
On 02/26/2013 11:37 AM, Martin Steigerwald wrote: Am Dienstag, 26. Februar 2013 schrieb Tsutomu Itoh: Therefore I want you to revert commit:2a2d8e1962e8b6cda7b0a7584f6d2fb95d442cb6. btrfs-progs: require mkfs -f force option to overwrite filesystem or partition table How do you think

Re: [PATCH, RFC] btrfs-progs: require mkfs -f force option to overwrite filesystem or partition table

2013-02-26 Thread Eric Sandeen
On 2/20/13 9:37 AM, Stefan Behrens wrote: ... This means that it is now required to change all occurrences of mkfs.btrfs to mkfs.btrfs -f everywhere. Can't we first establish a time period of 100 years where the -f option is tolerated and ignored, and then in 2113 we require that the users

Re: [PATCH, RFC] btrfs-progs: require mkfs -f force option to overwrite filesystem or partition table

2013-02-26 Thread Martin Steigerwald
Am Dienstag, 26. Februar 2013 schrieb Goffredo Baroncelli: And I teach not to in my trainings as well. Everyone who uses rm -rf by default even just for deleting a single file does it as long as he or she deleted his / her home directory or something. Unfortunately the rm -rf is

Re: [PATCH, RFC] btrfs-progs: require mkfs -f force option to overwrite filesystem or partition table

2013-02-25 Thread Tsutomu Itoh
On 2013/02/21 0:37, Stefan Behrens wrote: On Thu, 14 Feb 2013 12:30:03 -0600, Eric Sandeen wrote: The core of this is shamelessly stolen from xfsprogs. Use blkid to detect an existing filesystem or partition table on any of the target devices. If something is found, require the '-f' option to

Re: [PATCH, RFC] btrfs-progs: require mkfs -f force option to overwrite filesystem or partition table

2013-02-25 Thread Eric Sandeen
On 2/25/13 5:39 PM, Tsutomu Itoh wrote: On 2013/02/21 0:37, Stefan Behrens wrote: On Thu, 14 Feb 2013 12:30:03 -0600, Eric Sandeen wrote: The core of this is shamelessly stolen from xfsprogs. Use blkid to detect an existing filesystem or partition table on any of the target devices. If

Re: [PATCH, RFC] btrfs-progs: require mkfs -f force option to overwrite filesystem or partition table

2013-02-25 Thread Tsutomu Itoh
On 2013/02/26 9:07, Eric Sandeen wrote: On 2/25/13 5:39 PM, Tsutomu Itoh wrote: On 2013/02/21 0:37, Stefan Behrens wrote: On Thu, 14 Feb 2013 12:30:03 -0600, Eric Sandeen wrote: The core of this is shamelessly stolen from xfsprogs. Use blkid to detect an existing filesystem or partition

Re: [PATCH, RFC] btrfs-progs: require mkfs -f force option to overwrite filesystem or partition table

2013-02-25 Thread Eric Sandeen
On 2/25/13 9:55 PM, Tsutomu Itoh wrote: On 2013/02/26 9:07, Eric Sandeen wrote: On 2/25/13 5:39 PM, Tsutomu Itoh wrote: On 2013/02/21 0:37, Stefan Behrens wrote: On Thu, 14 Feb 2013 12:30:03 -0600, Eric Sandeen wrote: The core of this is shamelessly stolen from xfsprogs. Use blkid to detect

Re: [PATCH, RFC] btrfs-progs: require mkfs -f force option to overwrite filesystem or partition table

2013-02-25 Thread Tsutomu Itoh
On 2013/02/26 13:06, Eric Sandeen wrote: On 2/25/13 9:55 PM, Tsutomu Itoh wrote: On 2013/02/26 9:07, Eric Sandeen wrote: On 2/25/13 5:39 PM, Tsutomu Itoh wrote: On 2013/02/21 0:37, Stefan Behrens wrote: On Thu, 14 Feb 2013 12:30:03 -0600, Eric Sandeen wrote: The core of this is shamelessly

Re: [PATCH, RFC] btrfs-progs: require mkfs -f force option to overwrite filesystem or partition table

2013-02-25 Thread Dave Chinner
On Tue, Feb 26, 2013 at 01:25:11PM +0900, Tsutomu Itoh wrote: On 2013/02/26 13:06, Eric Sandeen wrote: On 2/25/13 9:55 PM, Tsutomu Itoh wrote: EXPERIMENTAL... It's certainly so. However, I think that we should not add the option that it troubles a lot of people. Well, I sent it as an RFC.

Re: [PATCH, RFC] btrfs-progs: require mkfs -f force option to overwrite filesystem or partition table

2013-02-20 Thread Stefan Behrens
On Thu, 14 Feb 2013 12:30:03 -0600, Eric Sandeen wrote: The core of this is shamelessly stolen from xfsprogs. Use blkid to detect an existing filesystem or partition table on any of the target devices. If something is found, require the '-f' option to overwrite it, hopefully avoiding

[PATCH, RFC] btrfs-progs: require mkfs -f force option to overwrite filesystem or partition table

2013-02-14 Thread Eric Sandeen
The core of this is shamelessly stolen from xfsprogs. Use blkid to detect an existing filesystem or partition table on any of the target devices. If something is found, require the '-f' option to overwrite it, hopefully avoiding disaster due to mistyped devicenames, etc. # mkfs.btrfs /dev/sda1

Re: [PATCH, RFC] btrfs-progs: require mkfs -f force option to overwrite filesystem or partition table

2013-02-14 Thread Chris Mason
On Thu, Feb 14, 2013 at 11:30:03AM -0700, Eric Sandeen wrote: The core of this is shamelessly stolen from xfsprogs. Use blkid to detect an existing filesystem or partition table on any of the target devices. If something is found, require the '-f' option to overwrite it, hopefully avoiding

Re: [PATCH, RFC] btrfs-progs: require mkfs -f force option to overwrite filesystem or partition table

2013-02-14 Thread Eric Sandeen
On 2/14/13 2:23 PM, Chris Mason wrote: On Thu, Feb 14, 2013 at 11:30:03AM -0700, Eric Sandeen wrote: The core of this is shamelessly stolen from xfsprogs. Use blkid to detect an existing filesystem or partition table on any of the target devices. If something is found, require the '-f'