Re: [PATCH] Btrfs: Add get/set label ioctl

2012-08-30 Thread Jie Liu
On 08/30/12 14:28, Anand Jain wrote: > >> The original patch could be revised with this support easily. >> How about using one structure and one ioctl number for both of them? >> i.e, >> >> #define BTRFS_IOC_FSLABEL_CTL_IOW(BTRFS_IOCTL_MAGIC, 50, struct >> btrfs_ioctl_fslabel_ctl_args) >> >> #d

Re: [PATCH] Btrfs: Add get/set label ioctl

2012-08-29 Thread Anand Jain
The original patch could be revised with this support easily. How about using one structure and one ioctl number for both of them? i.e, #define BTRFS_IOC_FSLABEL_CTL_IOW(BTRFS_IOCTL_MAGIC, 50, struct btrfs_ioctl_fslabel_ctl_args) #define BTRFS_FSLABEL_CTL_GET0 #define BTRFS_FSLABEL_CTL

Re: [PATCH] Btrfs: Add get/set label ioctl

2012-08-29 Thread Jie Liu
On 08/30/12 13:55, Jie Liu wrote: > On 08/30/12 13:44, Anand Jain wrote: >> Jeff, >> >> I don't find the get label ioctl part unless I am missing something. >> Any idea? Sorry, I took for granted that this patch has already been merged last year. :( To honor your efforts, I'd like to re-send a r

Re: [PATCH] Btrfs: Add get/set label ioctl

2012-08-29 Thread Jie Liu
On 08/30/12 13:44, Anand Jain wrote: > > Jeff, > > I don't find the get label ioctl part unless I am missing something. > Any idea? Yes, you're right, I have not post the get label at that time. The original patch could be revised with this support easily. How about using one structure and one i

Re: [PATCH] Btrfs: Add get/set label ioctl

2012-08-29 Thread Anand Jain
Jeff, I don't find the get label ioctl part unless I am missing something. Any idea? Thxs, -Anand On 30/08/12 09:54, Anand Jain wrote: Ah. I missed that. Thanks. So should use your original patch. -Anand On 29/08/12 17:00, Jie Liu wrote: Hi Anand, I have posted a patch for set label b

Re: [PATCH] Btrfs: Add get/set label ioctl

2012-08-29 Thread Anand Jain
Ah. I missed that. Thanks. So should use your original patch. -Anand On 29/08/12 17:00, Jie Liu wrote: Hi Anand, I have posted a patch for set label back to last year, which can be found at: https://patchwork.kernel.org/patch/1124642/ Besides that, we have discussed to use 50 as the ioctl

Re: [PATCH] Btrfs: Add get/set label ioctl

2012-08-29 Thread Jie Liu
Hi Anand, I have posted a patch for set label back to last year, which can be found at: https://patchwork.kernel.org/patch/1124642/ Besides that, we have discussed to use 50 as the ioctl(2) number at that time. task assignment in our wiki page: https://btrfs.wiki.kernel.org/index.php/Project_id

[PATCH] Btrfs: Add get/set label ioctl

2012-08-29 Thread Anand jain
From: Anand Jain Signed-off-by: Anand Jain --- fs/btrfs/ctree.h | 10 ++ fs/btrfs/ioctl.c | 30 ++ fs/btrfs/ioctl.h |2 ++ 3 files changed, 42 insertions(+), 0 deletions(-) diff --git a/fs/btrfs/ctree.h b/fs/btrfs/ctree.h index 4bab807..eff506f 10064