Re: [PATCH] Btrfs: add support for mixed data+metadata block groups V3

2010-10-21 Thread David Nicol
Does this mixing constitute a forbidden change of on-disk format, and if not how not? On Wed, Oct 20, 2010 at 11:21 PM, Mitch Harder mitch.har...@sabayonlinux.org wrote: Other than that, it seemed to perform well.  I did not encounter any stability issues as long as I was using a patched

Re: [PATCH] Btrfs: add support for mixed data+metadata block groups V3

2010-10-21 Thread Mitch Harder
On Thu, Oct 21, 2010 at 5:09 PM, Diego Calleja dieg...@gmail.com wrote: On Jueves, 21 de Octubre de 2010 17:46:58 David Nicol escribió: Does this mixing constitute a forbidden change of on-disk format, and if not how not? It doesn't need a format change. The difference between a data and a

Re: [PATCH] Btrfs: add support for mixed data+metadata block groups V3

2010-10-21 Thread Josef Bacik
On Thu, Oct 21, 2010 at 05:21:06PM -0500, Mitch Harder wrote: On Thu, Oct 21, 2010 at 5:09 PM, Diego Calleja dieg...@gmail.com wrote: On Jueves, 21 de Octubre de 2010 17:46:58 David Nicol escribió: Does this mixing constitute a forbidden change of on-disk format, and if not how not? It

Re: [PATCH] Btrfs: add support for mixed data+metadata block groups V3

2010-10-21 Thread C Anthony Risinger
On Thu, Oct 21, 2010 at 8:05 PM, Josef Bacik jo...@redhat.com wrote: On Thu, Oct 21, 2010 at 05:21:06PM -0500, Mitch Harder wrote: On Thu, Oct 21, 2010 at 5:09 PM, Diego Calleja dieg...@gmail.com wrote: On Jueves, 21 de Octubre de 2010 17:46:58 David Nicol escribió: Does this mixing

Re: [PATCH] Btrfs: add support for mixed data+metadata block groups V3

2010-10-21 Thread Josef Bacik
On Thu, Oct 21, 2010 at 08:32:12PM -0500, C Anthony Risinger wrote: On Thu, Oct 21, 2010 at 8:05 PM, Josef Bacik jo...@redhat.com wrote: On Thu, Oct 21, 2010 at 05:21:06PM -0500, Mitch Harder wrote: On Thu, Oct 21, 2010 at 5:09 PM, Diego Calleja dieg...@gmail.com wrote: On Jueves, 21 de

Re: [PATCH] Btrfs: add support for mixed data+metadata block groups V3

2010-10-21 Thread C Anthony Risinger
On Thu, Oct 21, 2010 at 8:37 PM, Josef Bacik jo...@redhat.com wrote: On Thu, Oct 21, 2010 at 08:32:12PM -0500, C Anthony Risinger wrote: On Thu, Oct 21, 2010 at 8:05 PM, Josef Bacik jo...@redhat.com wrote: On Thu, Oct 21, 2010 at 05:21:06PM -0500, Mitch Harder wrote: On Thu, Oct 21, 2010 at

Re: [PATCH] Btrfs: add support for mixed data+metadata block groups V3

2010-10-20 Thread Mitch Harder
I've been testing this patch (as well as the accompanying patch to btrfs-progs). It seems to save a decent amount of space (maybe 10-20% according to df in my testing, YMMV), but I was also noticing a performance penalty of maybe 5-15%, depending on the application (in my case, I was timing the

[PATCH] Btrfs: add support for mixed data+metadata block groups V3

2010-10-07 Thread Josef Bacik
There are just a few things that need to be fixed in the kernel to support mixed data+metadata block groups. Mostly we just need to make sure that if we are using mixed block groups that we continue to allocate mixed block groups as we need them. Also we need to make sure __find_space_info will