Re: [PATCH] Btrfs: clear received_uuid field for new writable snapshots

2013-05-23 Thread Stefan Behrens
On Wed, 22 May 2013 13:37:15 +0300, Alex Lyakas wrote: > Hi Stephan, > I fully understand the first part of your fix, and I believe it's > quite critical. Indeed, a writable snapshot should have no evidence > that it has an ancestor that was once "received". > > Can you pls let me know that I unde

Re: [PATCH] Btrfs: clear received_uuid field for new writable snapshots

2013-05-22 Thread Alex Lyakas
Hi Stephan, I fully understand the first part of your fix, and I believe it's quite critical. Indeed, a writable snapshot should have no evidence that it has an ancestor that was once "received". Can you pls let me know that I understand the second part of your fix. In btrfs-progs the following co

[PATCH] Btrfs: clear received_uuid field for new writable snapshots

2013-04-17 Thread Stefan Behrens
For created snapshots, the full root_item is copied from the source root and afterwards selectively modified. The current code forgets to clear the field received_uuid. The only problem is that it is confusing when you look at it with 'btrfs subv list', since for writable snapshots, the contents of