Re: [PATCH] Btrfs: do not abort transaction when failing to insert hole extent

2018-04-11 Thread Liu Bo
On Tue, Apr 10, 2018 at 5:12 AM, David Sterba wrote: > On Mon, Apr 09, 2018 at 06:23:14PM -0700, Liu Bo wrote: >> >>> As maybe_insert_hole is only called by btrfs_cont_expand here, which >> >>> means it's a really hole, I don't expect drop_extents would drop >> >>> anything, we

Re: [PATCH] Btrfs: do not abort transaction when failing to insert hole extent

2018-04-10 Thread David Sterba
On Mon, Apr 09, 2018 at 06:23:14PM -0700, Liu Bo wrote: > >>> As maybe_insert_hole is only called by btrfs_cont_expand here, which > >>> means it's a really hole, I don't expect drop_extents would drop > >>> anything, we can remove this drop_extents and put an assert after > >>>

Re: [PATCH] Btrfs: do not abort transaction when failing to insert hole extent

2018-04-09 Thread Liu Bo
On Fri, Apr 6, 2018 at 10:43 AM, Liu Bo wrote: > On Fri, Apr 6, 2018 at 6:21 AM, David Sterba wrote: >> On Thu, Apr 05, 2018 at 11:58:16AM -0700, Liu Bo wrote: >>> On Thu, Apr 5, 2018 at 9:48 AM, David Sterba wrote: >>> > On Sat, Mar 31,

Re: [PATCH] Btrfs: do not abort transaction when failing to insert hole extent

2018-04-06 Thread Liu Bo
On Fri, Apr 6, 2018 at 6:21 AM, David Sterba wrote: > On Thu, Apr 05, 2018 at 11:58:16AM -0700, Liu Bo wrote: >> On Thu, Apr 5, 2018 at 9:48 AM, David Sterba wrote: >> > On Sat, Mar 31, 2018 at 06:11:55AM +0800, Liu Bo wrote: >> >> This is running in a typical

Re: [PATCH] Btrfs: do not abort transaction when failing to insert hole extent

2018-04-06 Thread David Sterba
On Thu, Apr 05, 2018 at 11:58:16AM -0700, Liu Bo wrote: > On Thu, Apr 5, 2018 at 9:48 AM, David Sterba wrote: > > On Sat, Mar 31, 2018 at 06:11:55AM +0800, Liu Bo wrote: > >> This is running in a typical write path, not inside a critical path > >> where we have to abort the

Re: [PATCH] Btrfs: do not abort transaction when failing to insert hole extent

2018-04-05 Thread Liu Bo
On Thu, Apr 5, 2018 at 9:48 AM, David Sterba wrote: > On Sat, Mar 31, 2018 at 06:11:55AM +0800, Liu Bo wrote: >> This is running in a typical write path, not inside a critical path >> where we have to abort the running transaction, so it's OK to return >> errors to callers and

Re: [PATCH] Btrfs: do not abort transaction when failing to insert hole extent

2018-04-05 Thread David Sterba
On Sat, Mar 31, 2018 at 06:11:55AM +0800, Liu Bo wrote: > This is running in a typical write path, not inside a critical path > where we have to abort the running transaction, so it's OK to return > errors to callers and eventually to userspace. I'm not sure this is entierly correct, several