Re: [PATCH] Btrfs: fix crash of compressed writes

2013-10-01 Thread Liu Bo
On Tue, Oct 01, 2013 at 08:38:30AM -0400, Josef Bacik wrote: > No we needed his other addition below which is important, for when the > delalloc > range starts before but still encompasses our page. The other part is not > needed, we should be returning 0 if delalloc_end lands before or on our st

Re: [PATCH] Btrfs: fix crash of compressed writes

2013-10-01 Thread Josef Bacik
On Tue, Oct 01, 2013 at 11:37:22AM +0800, Liu Bo wrote: > On Mon, Sep 30, 2013 at 01:02:49PM -0400, Josef Bacik wrote: > > On Mon, Sep 30, 2013 at 08:39:57PM +0800, Liu Bo wrote: > > > The crash[1] is found by xfstests/generic/208 with "-o compress", > > > it's not reproduced everytime, but it does

Re: [PATCH] Btrfs: fix crash of compressed writes

2013-09-30 Thread Liu Bo
On Mon, Sep 30, 2013 at 01:02:49PM -0400, Josef Bacik wrote: > On Mon, Sep 30, 2013 at 08:39:57PM +0800, Liu Bo wrote: > > The crash[1] is found by xfstests/generic/208 with "-o compress", > > it's not reproduced everytime, but it does panic. > > > > The bug is quite interesting, it's actually int

Re: [PATCH] Btrfs: fix crash of compressed writes

2013-09-30 Thread Josef Bacik
On Mon, Sep 30, 2013 at 08:39:57PM +0800, Liu Bo wrote: > The crash[1] is found by xfstests/generic/208 with "-o compress", > it's not reproduced everytime, but it does panic. > > The bug is quite interesting, it's actually introduced by a recent commit > (573aecafca1cf7a974231b759197a1aebcf39c2a,

[PATCH] Btrfs: fix crash of compressed writes

2013-09-30 Thread Liu Bo
The crash[1] is found by xfstests/generic/208 with "-o compress", it's not reproduced everytime, but it does panic. The bug is quite interesting, it's actually introduced by a recent commit (573aecafca1cf7a974231b759197a1aebcf39c2a, Btrfs: actually limit the size of delalloc range). Btrfs impleme