Re: [PATCH] Improve support for exporting btrfs subvolumes.

2010-06-23 Thread J. Bruce Fields
On Thu, Jun 24, 2010 at 07:31:57AM +1000, Neil Brown wrote: > On Wed, 23 Jun 2010 14:28:38 -0400 > "J. Bruce Fields" wrote: > > > On Thu, Jun 17, 2010 at 02:54:01PM +1000, Neil Brown wrote: > > > > > > If you export two subvolumes of a btrfs filesystem, they will both be > > > given the same uui

Re: [PATCH] Improve support for exporting btrfs subvolumes.

2010-06-23 Thread Neil Brown
On Wed, 23 Jun 2010 14:28:38 -0400 "J. Bruce Fields" wrote: > On Thu, Jun 17, 2010 at 02:54:01PM +1000, Neil Brown wrote: > > > > If you export two subvolumes of a btrfs filesystem, they will both be > > given the same uuid so lookups will be confused. > > blkid cannot differentiate the two, so

Re: [PATCH] Improve support for exporting btrfs subvolumes.

2010-06-23 Thread J. Bruce Fields
On Thu, Jun 17, 2010 at 02:54:01PM +1000, Neil Brown wrote: > > If you export two subvolumes of a btrfs filesystem, they will both be > given the same uuid so lookups will be confused. > blkid cannot differentiate the two, so we must use the fsid from > statfs64 to identify the filesystem. > > We

Re: [PATCH] Improve support for exporting btrfs subvolumes.

2010-06-22 Thread Steve Dickson
On 06/17/2010 12:54 AM, Neil Brown wrote: > > If you export two subvolumes of a btrfs filesystem, they will both be > given the same uuid so lookups will be confused. > blkid cannot differentiate the two, so we must use the fsid from > statfs64 to identify the filesystem. > > We cannot tell if

[PATCH] Improve support for exporting btrfs subvolumes.

2010-06-16 Thread Neil Brown
If you export two subvolumes of a btrfs filesystem, they will both be given the same uuid so lookups will be confused. blkid cannot differentiate the two, so we must use the fsid from statfs64 to identify the filesystem. We cannot tell if blkid or statfs is best without knowing internal details o