Re: [PATCH] btrfs: change max_inline default to 2048

2016-02-15 Thread Chris Mason
On Thu, Feb 11, 2016 at 05:55:30PM +0100, David Sterba wrote: > The current practical default is ~4k on x86_64 (the logic is more complex, > simplified for brevity), the inlined files land in the metadata group and > thus consume space that could be needed for the real metadata. > > The inlining

Re: [PATCH] btrfs: change max_inline default to 2048

2016-02-15 Thread David Sterba
On Fri, Feb 12, 2016 at 07:10:29AM +, Duncan wrote: > Default? > > For those who want to keep the current inline, what's the mkfs.btrfs or > mount-option recipe to do so? I don't see any code added for that, nor > am I aware of any current options to change it, yet "default" indicates >

Re: [PATCH] btrfs: change max_inline default to 2048

2016-02-11 Thread Duncan
David Sterba posted on Thu, 11 Feb 2016 17:55:30 +0100 as excerpted: > The current practical default is ~4k on x86_64 (the logic is more > complex, simplified for brevity) > Proposed fix: set the default to 2048 > Signed-off-by: David Sterba > --- > fs/btrfs/ctree.h | 2 +- >

[PATCH] btrfs: change max_inline default to 2048

2016-02-11 Thread David Sterba
The current practical default is ~4k on x86_64 (the logic is more complex, simplified for brevity), the inlined files land in the metadata group and thus consume space that could be needed for the real metadata. The inlining brings some usability surprises: 1) total space consumption measured on