Re: [PATCH] btrfs: fix error handling in btrfs_dev_replace_start

2018-09-14 Thread David Sterba
On Mon, Sep 10, 2018 at 07:47:29PM +0200, David Sterba wrote: > On Thu, Sep 06, 2018 at 03:52:17PM -0400, je...@suse.com wrote: > > From: Jeff Mahoney > > > > When we fail to start a transaction in btrfs_dev_replace_start, > > we leave dev_replace->replace_start set to STARTED but clear > >

Re: [PATCH] btrfs: fix error handling in btrfs_dev_replace_start

2018-09-10 Thread David Sterba
On Thu, Sep 06, 2018 at 03:52:17PM -0400, je...@suse.com wrote: > From: Jeff Mahoney > > When we fail to start a transaction in btrfs_dev_replace_start, > we leave dev_replace->replace_start set to STARTED but clear > ->srcdev and ->tgtdev. Later, that can result in an Oops in >

[PATCH] btrfs: fix error handling in btrfs_dev_replace_start

2018-09-06 Thread jeffm
From: Jeff Mahoney When we fail to start a transaction in btrfs_dev_replace_start, we leave dev_replace->replace_start set to STARTED but clear ->srcdev and ->tgtdev. Later, that can result in an Oops in btrfs_dev_replace_progress when having state set to STARTED or SUSPENDED implies that