Re: [PATCH] btrfs: fix return value check of btrfs_start_transaction()

2011-02-01 Thread Chris Mason
Excerpts from Tsutomu Itoh's message of 2011-01-31 21:15:32 -0500: > Hi Chris, > > (2011/01/29 6:53), Chris Mason wrote: > > Excerpts from Tsutomu Itoh's message of 2011-01-21 01:06:29 -0500: > >> (2011/01/21 8:47), Tsutomu Itoh wrote: > >>> (2011/01/21 1:09), Josef Bacik wrote: > I'd rather

Re: [PATCH] btrfs: fix return value check of btrfs_start_transaction()

2011-01-31 Thread Tsutomu Itoh
Hi Chris, (2011/01/29 6:53), Chris Mason wrote: > Excerpts from Tsutomu Itoh's message of 2011-01-21 01:06:29 -0500: >> (2011/01/21 8:47), Tsutomu Itoh wrote: >>> (2011/01/21 1:09), Josef Bacik wrote: I'd rather we go through and have these things return an error than do a BUG_ON(). We'

Re: [PATCH] btrfs: fix return value check of btrfs_start_transaction()

2011-01-30 Thread Tsutomu Itoh
Hi, Chris, (2011/01/29 6:53), Chris Mason wrote: > Excerpts from Tsutomu Itoh's message of 2011-01-21 01:06:29 -0500: >> (2011/01/21 8:47), Tsutomu Itoh wrote: >>> (2011/01/21 1:09), Josef Bacik wrote: I'd rather we go through and have these things return an error than do a BUG_ON(). We

Re: [PATCH] btrfs: fix return value check of btrfs_start_transaction()

2011-01-28 Thread Chris Mason
Excerpts from Tsutomu Itoh's message of 2011-01-21 01:06:29 -0500: > (2011/01/21 8:47), Tsutomu Itoh wrote: > > (2011/01/21 1:09), Josef Bacik wrote: > >> I'd rather we go through and have these things return an error than do a > >> BUG_ON(). We're moving towards a more stable BTRFS, not one that

Re: [PATCH] btrfs: fix return value check of btrfs_start_transaction()

2011-01-20 Thread Tsutomu Itoh
(2011/01/21 8:47), Tsutomu Itoh wrote: > (2011/01/21 1:09), Josef Bacik wrote: >> I'd rather we go through and have these things return an error than do a >> BUG_ON(). We're moving towards a more stable BTRFS, not one that panics more >> often :). > > Yes, I also think so. > This patch is my firs

Re: [PATCH] btrfs: fix return value check of btrfs_start_transaction()

2011-01-20 Thread liubo
On 01/21/2011 12:09 AM, Josef Bacik wrote: > On Thu, Jan 20, 2011 at 03:19:37PM +0900, Tsutomu Itoh wrote: >> The error check of btrfs_start_transaction() is added, and the mistake >> of the error check on several places is corrected. >> > > I'd rather we go through and have these things return a

Re: [PATCH] btrfs: fix return value check of btrfs_start_transaction()

2011-01-20 Thread Tsutomu Itoh
(2011/01/21 1:09), Josef Bacik wrote: > I'd rather we go through and have these things return an error than do a > BUG_ON(). We're moving towards a more stable BTRFS, not one that panics more > often :). Yes, I also think so. This patch is my first step. My modification policy is as follows: 1.

Re: [PATCH] btrfs: fix return value check of btrfs_start_transaction()

2011-01-20 Thread Josef Bacik
On Thu, Jan 20, 2011 at 03:19:37PM +0900, Tsutomu Itoh wrote: > The error check of btrfs_start_transaction() is added, and the mistake > of the error check on several places is corrected. > I'd rather we go through and have these things return an error than do a BUG_ON(). We're moving towards a

[PATCH] btrfs: fix return value check of btrfs_start_transaction()

2011-01-19 Thread Tsutomu Itoh
The error check of btrfs_start_transaction() is added, and the mistake of the error check on several places is corrected. Signed-off-by: Tsutomu Itoh --- fs/btrfs/extent-tree.c |7 +-- fs/btrfs/inode.c |1 + fs/btrfs/ioctl.c | 10 -- fs/btrfs/relocation.c |