Re: [PATCH] btrfs: make static code static & remove dead code

2013-04-24 Thread David Sterba
On Mon, Apr 22, 2013 at 11:01:09AM -0500, Eric Sandeen wrote: > >> Maybe one for Arne to answer? Yeah, I don't see it in the manpage > >> or in userspace, so *shrug* where is the design? > > > > Scrub can be started on one device, cancel is just part of the command set. > > > > $ ./btrfs scrub c

Re: [PATCH] btrfs: make static code static & remove dead code

2013-04-22 Thread Eric Sandeen
On 4/22/13 10:55 AM, David Sterba wrote: > On Mon, Apr 22, 2013 at 10:24:12AM -0500, Eric Sandeen wrote: btrfs_reada_detach() >>> >>> That's an API for readahead, thhugh maybe not used now as RA is not used >>> and at all scenarios where it could. >> >> Ok, if it's useful to keep it around jus

Re: [PATCH] btrfs: make static code static & remove dead code

2013-04-22 Thread David Sterba
On Mon, Apr 22, 2013 at 10:24:12AM -0500, Eric Sandeen wrote: > >> btrfs_reada_detach() > > > > That's an API for readahead, thhugh maybe not used now as RA is not used > > and at all scenarios where it could. > > Ok, if it's useful to keep it around just for symmetry I could > understand that.

Re: [PATCH] btrfs: make static code static & remove dead code

2013-04-22 Thread Eric Sandeen
On 4/22/13 10:05 AM, David Sterba wrote: > On Fri, Apr 19, 2013 at 12:21:22PM -0700, Eric Sandeen wrote: >> Big patch, but all it does is add statics to functions which >> are in fact static, then remove the associated dead-code fallout. > > I support removing dead code, though nearly all of the f

Re: [PATCH] btrfs: make static code static & remove dead code

2013-04-22 Thread David Sterba
On Fri, Apr 19, 2013 at 12:21:22PM -0700, Eric Sandeen wrote: > Big patch, but all it does is add statics to functions which > are in fact static, then remove the associated dead-code fallout. I support removing dead code, though nearly all of the functions make me wonder why they're not used. A f

Re: [PATCH] btrfs: make static code static & remove dead code

2013-04-20 Thread Arne Jansen
On 04/19/13 21:21, Eric Sandeen wrote: > Big patch, but all it does is add statics to functions which > are in fact static, then remove the associated dead-code fallout. > > removed functions: > > btrfs_iref_to_path() > __btrfs_lookup_delayed_deletion_item() > __btrfs_search_delayed_insertion_ite

Re: [PATCH] btrfs: make static code static & remove dead code

2013-04-20 Thread Wang Shilong
Hello Eric, > Big patch, but all it does is add statics to functions which > are in fact static, then remove the associated dead-code fallout. > > removed functions: > > btrfs_iref_to_path() > __btrfs_lookup_delayed_deletion_item() > __btrfs_search_delayed_insertion_item() > __btrfs_search_delay

Re: [PATCH] btrfs: make static code static & remove dead code

2013-04-19 Thread Wang Shilong
Hello Eric, > Big patch, but all it does is add statics to functions which > are in fact static, then remove the associated dead-code fallout. > > removed functions: > > btrfs_iref_to_path() > __btrfs_lookup_delayed_deletion_item() > __btrfs_search_delayed_insertion_item() > __btrfs_search_delay

[PATCH] btrfs: make static code static & remove dead code

2013-04-19 Thread Eric Sandeen
Big patch, but all it does is add statics to functions which are in fact static, then remove the associated dead-code fallout. removed functions: btrfs_iref_to_path() __btrfs_lookup_delayed_deletion_item() __btrfs_search_delayed_insertion_item() __btrfs_search_delayed_deletion_item() find_eb_for_