Re: [PATCH] btrfs: quasi-round-robin for chunk allocation

2011-05-13 Thread David Sterba
Hi, On Mon, Apr 11, 2011 at 01:46:33PM -0400, Chris Mason wrote: My big complaint about this patch is that it is a feature fix mixed in with a huge cleanup. It's hard to differentiate between the two. Could you please separate it out so we can review them independently? I agree that changes

Re: [PATCH] btrfs: quasi-round-robin for chunk allocation

2011-04-11 Thread Arne Jansen
On 08.02.2011 19:03, Arne Jansen wrote: In a multi device setup, the chunk allocator currently always allocates chunks on the devices in the same order. This leads to a very uneven distribution, especially with RAID1 or RAID10 and an uneven number of devices. This patch always sorts the device

Re: [PATCH] btrfs: quasi-round-robin for chunk allocation

2011-04-11 Thread Chris Mason
Excerpts from Arne Jansen's message of 2011-04-11 13:42:49 -0400: On 08.02.2011 19:03, Arne Jansen wrote: In a multi device setup, the chunk allocator currently always allocates chunks on the devices in the same order. This leads to a very uneven distribution, especially with RAID1 or

Re: [PATCH] btrfs: quasi-round-robin for chunk allocation

2011-03-18 Thread Chris Mason
Excerpts from Arne Jansen's message of 2011-03-17 11:58:46 -0400: On 09.02.2011 04:03, Miao Xie wrote: On tue, 8 Feb 2011 19:03:32 +0100, Arne Jansen wrote: In a multi device setup, the chunk allocator currently always allocates chunks on the devices in the same order. This leads to a

Re: [PATCH] btrfs: quasi-round-robin for chunk allocation

2011-03-18 Thread cwillu
On Fri, Mar 18, 2011 at 8:40 AM, Chris Mason chris.ma...@oracle.com wrote: I think that filling all the devices fully is more important than the initial spread.  Miao is correct that the administrator will probably complain if all the devices aren't used for the initial stripes. But, over the

Re: [PATCH] btrfs: quasi-round-robin for chunk allocation

2011-03-18 Thread Arne Jansen
On 18.03.2011 17:25, cwillu wrote: On Fri, Mar 18, 2011 at 8:40 AM, Chris Masonchris.ma...@oracle.com wrote: I think that filling all the devices fully is more important than the initial spread. Miao is correct that the administrator will probably complain if all the devices aren't used for

Re: [PATCH] btrfs: quasi-round-robin for chunk allocation

2011-03-17 Thread Arne Jansen
On 09.02.2011 04:03, Miao Xie wrote: On tue, 8 Feb 2011 19:03:32 +0100, Arne Jansen wrote: In a multi device setup, the chunk allocator currently always allocates chunks on the devices in the same order. This leads to a very uneven distribution, especially with RAID1 or RAID10 and an uneven