Re: [PATCH] btrfs: use enum instead of constant value

2017-12-05 Thread David Sterba
On Tue, Dec 05, 2017 at 06:35:30PM +0800, Gu Jinxiang wrote: > Use enum READA_BACK instead of value 1 to keep source robust. Are you sure that READA_BACK is the right one? It corresponds to the value 1, but the actual readahead direction semantics should be considered. It is not obvious and needs

[PATCH] btrfs: use enum instead of constant value

2017-12-05 Thread Gu Jinxiang
Use enum READA_BACK instead of value 1 to keep source robust. Signed-off-by: Gu Jinxiang --- fs/btrfs/free-space-tree.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/btrfs/free-space-tree.c b/fs/btrfs/free-space-tree.c index a5e34de..a105629