[PATCH] btrfs: use list_for_each_entry_safe() when delete items

2013-09-01 Thread Azat Khuzhin
Replace list_for_each_entry() by list_for_each_entry_safe() in __btrfs_close_devices() list_for_each_entry() { list_replace_rcu(); call_rcu(); --We may free the device, if we get next device by the current one, the page fault

Re: [PATCH] btrfs: use list_for_each_entry_safe() when delete items

2013-08-31 Thread Azat Khuzhin
On Tue, Jul 30, 2013 at 7:40 AM, Miao Xie mi...@cn.fujitsu.com wrote: On mon, 29 Jul 2013 11:48:32 +0400, Azat Khuzhin wrote: On Sat, Jul 27, 2013 at 2:12 PM, Azat Khuzhin a3at.m...@gmail.com wrote: Replace list_for_each_entry() by list_for_each_entry_safe() in __btrfs_close_devices() There

Re: [PATCH] btrfs: use list_for_each_entry_safe() when delete items

2013-07-29 Thread Azat Khuzhin
On Sat, Jul 27, 2013 at 2:12 PM, Azat Khuzhin a3at.m...@gmail.com wrote: Replace list_for_each_entry() by list_for_each_entry_safe() in __btrfs_close_devices() There is another place that delete items lock_stripe_add(), but there we don't need safe version, because after deleting we exit from

Re: [PATCH] btrfs: use list_for_each_entry_safe() when delete items

2013-07-29 Thread Miao Xie
On mon, 29 Jul 2013 11:48:32 +0400, Azat Khuzhin wrote: On Sat, Jul 27, 2013 at 2:12 PM, Azat Khuzhin a3at.m...@gmail.com wrote: Replace list_for_each_entry() by list_for_each_entry_safe() in __btrfs_close_devices() There is another place that delete items lock_stripe_add(), but there we

[PATCH] btrfs: use list_for_each_entry_safe() when delete items

2013-07-27 Thread Azat Khuzhin
Replace list_for_each_entry() by list_for_each_entry_safe() in __btrfs_close_devices() There is another place that delete items lock_stripe_add(), but there we don't need safe version, because after deleting we exit from loop. Signed-off-by: Azat Khuzhin a3at.m...@gmail.com ---

[PATCH] btrfs: use list_for_each_entry_safe() when delete items

2013-07-26 Thread Azat Khuzhin
Replace list_for_each_entry() by list_for_each_entry_safe() in next functions: - lock_stripe_add() - __btrfs_close_devices() Signed-off-by: Azat Khuzhin a3at.m...@gmail.com --- fs/btrfs/raid56.c |4 ++-- fs/btrfs/volumes.c |4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff