Re: [PATCH] btrfs-progs: dump-tree: Introduce --breadth-first option

2018-09-11 Thread Qu Wenruo
On 2018/9/11 下午11:52, David Sterba wrote: > On Tue, Sep 04, 2018 at 08:39:55PM +0800, Qu Wenruo wrote: >> >> >> On 2018/8/23 下午3:45, Qu Wenruo wrote: >>> >>> >>> On 2018/8/23 下午3:36, Nikolay Borisov wrote: On 23.08.2018 10:31, Qu Wenruo wrote: > Introduce --breadth-first

Re: [PATCH] btrfs-progs: dump-tree: Introduce --breadth-first option

2018-09-11 Thread David Sterba
On Tue, Sep 04, 2018 at 08:39:55PM +0800, Qu Wenruo wrote: > > > On 2018/8/23 下午3:45, Qu Wenruo wrote: > > > > > > On 2018/8/23 下午3:36, Nikolay Borisov wrote: > >> > >> > >> On 23.08.2018 10:31, Qu Wenruo wrote: > >>> Introduce --breadth-first option to do breadth-first tree dump. > >>> This

Re: [PATCH] btrfs-progs: dump-tree: Introduce --breadth-first option

2018-09-04 Thread Qu Wenruo
On 2018/8/23 下午3:45, Qu Wenruo wrote: > > > On 2018/8/23 下午3:36, Nikolay Borisov wrote: >> >> >> On 23.08.2018 10:31, Qu Wenruo wrote: >>> Introduce --breadth-first option to do breadth-first tree dump. >>> This is especially handy to inspect high level trees, e.g. comparing >>> tree reloc

Re: [PATCH] btrfs-progs: dump-tree: Introduce --breadth-first option

2018-08-23 Thread Qu Wenruo
On 2018/8/23 下午3:36, Nikolay Borisov wrote: > > > On 23.08.2018 10:31, Qu Wenruo wrote: >> Introduce --breadth-first option to do breadth-first tree dump. >> This is especially handy to inspect high level trees, e.g. comparing >> tree reloc tree with its source tree. > > Will it make sense

Re: [PATCH] btrfs-progs: dump-tree: Introduce --breadth-first option

2018-08-23 Thread Su Yue
On 08/23/2018 03:31 PM, Qu Wenruo wrote: By default dump-tree does depth-first search. For 2 level trees it's completely OK, but for 3 level trees, it would be pretty hard to locate output of middle level tree nodes. Introduce --breadth-first option to do breadth-first tree dump. This is

Re: [PATCH] btrfs-progs: dump-tree: Introduce --breadth-first option

2018-08-23 Thread Nikolay Borisov
On 23.08.2018 10:31, Qu Wenruo wrote: > Introduce --breadth-first option to do breadth-first tree dump. > This is especially handy to inspect high level trees, e.g. comparing > tree reloc tree with its source tree. Will it make sense instead of exposing another option to just have a heuristics

[PATCH] btrfs-progs: dump-tree: Introduce --breadth-first option

2018-08-23 Thread Qu Wenruo
By default dump-tree does depth-first search. For 2 level trees it's completely OK, but for 3 level trees, it would be pretty hard to locate output of middle level tree nodes. Introduce --breadth-first option to do breadth-first tree dump. This is especially handy to inspect high level trees,