Re: [PATCH] btrfs-progs: tests: run rollback after conversion

2016-05-30 Thread Qu Wenruo
Problem located. may_rollback() is still the old codes, while for new convert's metadata, it's complete OK if it's physical position is different from its logical space. Unlike the strict old condition. I'll add more check to ensure new convert can pass may_rollback() check. Thanks, Qu Qu

Re: [PATCH] btrfs-progs: tests: run rollback after conversion

2016-05-30 Thread Qu Wenruo
David Sterba wrote on 2016/05/30 17:56 +0200: Hi Qu, the convert patchset does not pass a rollback test, fails in the case of 32k nodesize. Thre's not much info why, just 'rollback failed'. The branch that passes is 'test-rollback', it's current devel without the convert and low-mem fsck

Re: [PATCH] btrfs-progs: tests: run rollback after conversion

2016-05-30 Thread Qu Wenruo
Thanks for the report. We will check it and fix it soon. Thanks, Qu David Sterba wrote on 2016/05/30 17:56 +0200: Hi Qu, the convert patchset does not pass a rollback test, fails in the case of 32k nodesize. Thre's not much info why, just 'rollback failed'. The branch that passes is

Re: [PATCH] btrfs-progs: tests: run rollback after conversion

2016-05-30 Thread David Sterba
Hi Qu, the convert patchset does not pass a rollback test, fails in the case of 32k nodesize. Thre's not much info why, just 'rollback failed'. The branch that passes is 'test-rollback', it's current devel without the convert and low-mem fsck patchsets. -- To unsubscribe from this list: send the

[PATCH] btrfs-progs: tests: run rollback after conversion

2016-05-30 Thread David Sterba
Signed-off-by: David Sterba --- tests/convert-tests.sh | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/convert-tests.sh b/tests/convert-tests.sh index 3fce8915f94a..2806b921544b 100755 --- a/tests/convert-tests.sh +++ b/tests/convert-tests.sh @@ -138,6 +138,9 @@