On 08/31/2011 05:43 AM, Sunil Mushran wrote:
On 8/30/2011 8:29 PM, Dave Chinner wrote:
And that's -exactly- the ambiguous, vague definition that has raised
all these questions in the first place. I was in doubt about whether
unwritten extents can be considered a hole, and by your definition
On 08/27/2011 01:30 AM, Marco Stornelli wrote:
Il 26/08/2011 16:41, Zach Brown ha scritto:
Hole: a range of the file that contains no data or is made up
entirely of NULL (zero) data. Holes include preallocated ranges of
files that have not had actual data written to them.
No for me. A hole
On 08/25/2011 06:35 PM, Dave Chinner wrote:
Agreed, that's the way I'd interpret it, too. So perhaps we need to
ensure that this interpretation is actually tested by this test?
How about some definitions to work by:
Data: a range of the file that contains valid data, regardless of
whether it
On Tue, Aug 30, 2011 at 06:17:02PM -0700, Sunil Mushran wrote:
On 08/25/2011 06:35 PM, Dave Chinner wrote:
Agreed, that's the way I'd interpret it, too. So perhaps we need to
ensure that this interpretation is actually tested by this test?
How about some definitions to work by:
Data: a
On Wed, 31 Aug 2011, Dave Chinner wrote:
On Tue, Aug 30, 2011 at 06:17:02PM -0700, Sunil Mushran wrote:
On 08/25/2011 06:35 PM, Dave Chinner wrote:
Agreed, that's the way I'd interpret it, too. So perhaps we need to
ensure that this interpretation is actually tested by this test?
How about
On 8/30/2011 8:29 PM, Dave Chinner wrote:
And that's -exactly- the ambiguous, vague definition that has raised
all these questions in the first place. I was in doubt about whether
unwritten extents can be considered a hole, and by your definition
that means it should be data. But Andreas seems
On Tue, Aug 30, 2011 at 11:29 PM, Dave Chinner da...@fromorbit.com wrote:
On Tue, Aug 30, 2011 at 06:17:02PM -0700, Sunil Mushran wrote:
Instead
we should let the fs weigh the cost of providing accurate information
with the possible gain in performance.
Data:
A range in a file that could
Il 26/08/2011 16:41, Zach Brown ha scritto:
Hole: a range of the file that contains no data or is made up
entirely of NULL (zero) data. Holes include preallocated ranges of
files that have not had actual data written to them.
No for me. A hole is made up of zero data? It's a strange
2011/8/26 Dave Chinner da...@fromorbit.com:
On Thu, Aug 25, 2011 at 12:51:56AM -0600, Andreas Dilger wrote:
On 2011-08-25, at 12:40 AM, Dave Chinner wrote:
On Thu, Aug 25, 2011 at 02:06:32AM -0400, Christoph Hellwig wrote:
On Tue, Jun 28, 2011 at 11:33:19AM -0400, Josef Bacik wrote:
This
Hole: a range of the file that contains no data or is made up
entirely of NULL (zero) data. Holes include preallocated ranges of
files that have not had actual data written to them.
No for me. A hole is made up of zero data? It's a strange definition
for me.
It's a very natural
On Tue, Jun 28, 2011 at 11:33:19AM -0400, Josef Bacik wrote:
This is a test to make sure seek_data/seek_hole is acting like it does on
Solaris. It will check to see if the fs supports finding a hole or not and
will
adjust as necessary.
Can you resend this with any updates that happened in
On Thu, Aug 25, 2011 at 02:06:32AM -0400, Christoph Hellwig wrote:
On Tue, Jun 28, 2011 at 11:33:19AM -0400, Josef Bacik wrote:
This is a test to make sure seek_data/seek_hole is acting like it does on
Solaris. It will check to see if the fs supports finding a hole or not and
will
On 2011-08-25, at 12:40 AM, Dave Chinner wrote:
On Thu, Aug 25, 2011 at 02:06:32AM -0400, Christoph Hellwig wrote:
On Tue, Jun 28, 2011 at 11:33:19AM -0400, Josef Bacik wrote:
This is a test to make sure seek_data/seek_hole is acting like it does on
Solaris. It will check to see if the fs
On Thu, Aug 25, 2011 at 12:51:56AM -0600, Andreas Dilger wrote:
On 2011-08-25, at 12:40 AM, Dave Chinner wrote:
On Thu, Aug 25, 2011 at 02:06:32AM -0400, Christoph Hellwig wrote:
On Tue, Jun 28, 2011 at 11:33:19AM -0400, Josef Bacik wrote:
This is a test to make sure seek_data/seek_hole is
On Wed, Jun 29, 2011 at 11:42:38AM +0100, P?draig Brady wrote:
There is the argument, that if this interface can distinguish
these dirty unwritten extents, then why can't the fiemap interface too?
The advantage of the fiemap interface is that it can distinguish
empty extents vs holes. Empty
On Tue, Jun 28, 2011 at 11:33:19AM -0400, Josef Bacik wrote:
This is a test to make sure seek_data/seek_hole is acting like it does on
Solaris. It will check to see if the fs supports finding a hole or not and
will
adjust as necessary.
So I just looked at this with an eye to validating an
On Wed, Jun 29, 2011 at 04:53:07PM +1000, Dave Chinner wrote:
On Tue, Jun 28, 2011 at 11:33:19AM -0400, Josef Bacik wrote:
This is a test to make sure seek_data/seek_hole is acting like it does on
Solaris. It will check to see if the fs supports finding a hole or not and
will
adjust as
On 29/06/11 08:40, Christoph Hellwig wrote:
On Wed, Jun 29, 2011 at 04:53:07PM +1000, Dave Chinner wrote:
On Tue, Jun 28, 2011 at 11:33:19AM -0400, Josef Bacik wrote:
This is a test to make sure seek_data/seek_hole is acting like it does on
Solaris. It will check to see if the fs supports
On 06/29/2011 02:53 AM, Dave Chinner wrote:
On Tue, Jun 28, 2011 at 11:33:19AM -0400, Josef Bacik wrote:
This is a test to make sure seek_data/seek_hole is acting like it does on
Solaris. It will check to see if the fs supports finding a hole or not and will
adjust as necessary.
So I just
On 06/29/2011 12:40 AM, Christoph Hellwig wrote:
On Wed, Jun 29, 2011 at 04:53:07PM +1000, Dave Chinner wrote:
On Tue, Jun 28, 2011 at 11:33:19AM -0400, Josef Bacik wrote:
This is a test to make sure seek_data/seek_hole is acting like it does on
Solaris. It will check to see if the fs
On 29/06/11 18:29, Sunil Mushran wrote:
On 06/29/2011 03:42 AM, Pádraig Brady wrote:
There is the argument, that if this interface can distinguish
these dirty unwritten extents, then why can't the fiemap interface too?
The advantage of the fiemap interface is that it can distinguish
empty
This is a test to make sure seek_data/seek_hole is acting like it does on
Solaris. It will check to see if the fs supports finding a hole or not and will
adjust as necessary.
Signed-off-by: Josef Bacik jo...@redhat.com
---
255 | 71
255.out |2 +
group
This is a test to make sure seek_data/seek_hole is acting like it does on
Solaris. It will check to see if the fs supports finding a hole or not and will
adjust as necessary.
Cc: x...@oss.sgi.com
Signed-off-by: Josef Bacik jo...@redhat.com
---
255 | 71
255.out
On 2011-06-27, at 12:02 PM, Josef Bacik wrote:
This is a test to make sure seek_data/seek_hole is acting like it does on
Solaris. It will check to see if the fs supports finding a hole or not and
will
adjust as necessary.
diff --git a/src/seek-tester.c b/src/seek-tester.c
new file mode
On 06/27/2011 02:32 PM, Andreas Dilger wrote:
On 2011-06-27, at 12:02 PM, Josef Bacik wrote:
snip
+
+#define SEEK_DATA 3
+#define SEEK_HOLE 4
These should probably be #ifndef SEEK_DATA so that gcc doesn't complain
in the future when these are added to a standard header.
Good
25 matches
Mail list logo
