Re: [PATCH 02/10] btrfs-progs: save error number correctly in check_chunks_and_extents

2015-10-21 Thread David Sterba
On Tue, Oct 20, 2015 at 06:28:00PM +0800, Eryu Guan wrote: > On Mon, Oct 19, 2015 at 03:41:04PM +0200, David Sterba wrote: > > On Mon, Oct 19, 2015 at 07:37:52PM +0800, Eryu Guan wrote: > > > Coverity reports assigning value from "err" to "ret", but that stored > > > value is overwritten by check_e

Re: [PATCH 02/10] btrfs-progs: save error number correctly in check_chunks_and_extents

2015-10-20 Thread Eryu Guan
On Mon, Oct 19, 2015 at 03:41:04PM +0200, David Sterba wrote: > On Mon, Oct 19, 2015 at 07:37:52PM +0800, Eryu Guan wrote: > > Coverity reports assigning value from "err" to "ret", but that stored > > value is overwritten by check_extent_refs() before it can be used. > > If you fix a coverity issu

Re: [PATCH 02/10] btrfs-progs: save error number correctly in check_chunks_and_extents

2015-10-19 Thread David Sterba
On Mon, Oct 19, 2015 at 07:37:52PM +0800, Eryu Guan wrote: > Coverity reports assigning value from "err" to "ret", but that stored > value is overwritten by check_extent_refs() before it can be used. If you fix a coverity issue, please add a tag and the id, like Resolves-coverity-id: 1234 -- To u

[PATCH 02/10] btrfs-progs: save error number correctly in check_chunks_and_extents

2015-10-19 Thread Eryu Guan
Coverity reports assigning value from "err" to "ret", but that stored value is overwritten by check_extent_refs() before it can be used. Signed-off-by: Eryu Guan --- cmds-check.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/cmds-check.c b/cmds-check.c index 4