Re: [PATCH 06/10] btrfs: scrub: use bool for flush_all_writes

2017-05-29 Thread David Sterba
On Fri, May 19, 2017 at 03:08:22PM +0200, David Sterba wrote: > On Thu, May 18, 2017 at 05:42:24PM -0700, Liu Bo wrote: > > On Tue, May 16, 2017 at 07:10:38PM +0200, David Sterba wrote: > > > flush_all_writes is an atomic but does not use the semantics at all, > > > it's just on/off indicator, we

Re: [PATCH 06/10] btrfs: scrub: use bool for flush_all_writes

2017-05-19 Thread David Sterba
On Thu, May 18, 2017 at 05:42:24PM -0700, Liu Bo wrote: > On Tue, May 16, 2017 at 07:10:38PM +0200, David Sterba wrote: > > flush_all_writes is an atomic but does not use the semantics at all, > > it's just on/off indicator, we can use bool. > > > > It might use atomic to avoid reordering, but

Re: [PATCH 06/10] btrfs: scrub: use bool for flush_all_writes

2017-05-18 Thread Liu Bo
On Tue, May 16, 2017 at 07:10:38PM +0200, David Sterba wrote: > flush_all_writes is an atomic but does not use the semantics at all, > it's just on/off indicator, we can use bool. > It might use atomic to avoid reordering, but I'm not sure if reordering could really happen here. Thanks, -liubo

[PATCH 06/10] btrfs: scrub: use bool for flush_all_writes

2017-05-16 Thread David Sterba
flush_all_writes is an atomic but does not use the semantics at all, it's just on/off indicator, we can use bool. Signed-off-by: David Sterba --- fs/btrfs/scrub.c | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/fs/btrfs/scrub.c