Re: [PATCH 06/12] Fix btrfs/094 to work on non-4k block sized filesystems

2015-11-25 Thread Chandan Rajendra
On Wednesday 25 Nov 2015 11:51:52 Filipe Manana wrote: > On Wed, Nov 25, 2015 at 11:47 AM, Chandan Rajendra > > wrote: > > On Wednesday 25 Nov 2015 11:11:27 Filipe Manana wrote: > >> Hi Chandan, > >> > >> I can't agree with this change. We're no longer checking that

[PATCH 06/12] Fix btrfs/094 to work on non-4k block sized filesystems

2015-11-25 Thread Chandan Rajendra
This commit makes use of the new _filter_xfs_io_blocks_modified filtering function to print information in terms of file blocks rather than file offset. Signed-off-by: Chandan Rajendra --- tests/btrfs/094 | 78 +++--

Re: [PATCH 06/12] Fix btrfs/094 to work on non-4k block sized filesystems

2015-11-25 Thread Filipe Manana
On Wed, Nov 25, 2015 at 11:03 AM, Chandan Rajendra wrote: > This commit makes use of the new _filter_xfs_io_blocks_modified filtering > function to print information in terms of file blocks rather than file > offset. > > Signed-off-by: Chandan Rajendra

Re: [PATCH 06/12] Fix btrfs/094 to work on non-4k block sized filesystems

2015-11-25 Thread Filipe Manana
On Wed, Nov 25, 2015 at 11:47 AM, Chandan Rajendra wrote: > On Wednesday 25 Nov 2015 11:11:27 Filipe Manana wrote: >> >> Hi Chandan, >> >> I can't agree with this change. We're no longer checking that file >> data is correct after the cloning operations. The md5sum

Re: [PATCH 06/12] Fix btrfs/094 to work on non-4k block sized filesystems

2015-11-25 Thread Chandan Rajendra
On Wednesday 25 Nov 2015 11:11:27 Filipe Manana wrote: > > Hi Chandan, > > I can't agree with this change. We're no longer checking that file > data is correct after the cloning operations. The md5sum checks were > exactly for that. So essentially the test is only verifying the clone >