Re: [PATCH 1/4] btrfs-progs: check: Remove the ability to rebuild root overwritting existing tree blocks

2018-08-02 Thread David Sterba
On Fri, Jul 06, 2018 at 01:53:24AM +, Gu, Jinxiang wrote: > > >> Subject: [PATCH 1/4] btrfs-progs: check: Remove the ability to rebuild > > >> root overwritting existing tree blocks > > >> > > >> We have function btrfs_fsck_reinit_root(

RE: [PATCH 1/4] btrfs-progs: check: Remove the ability to rebuild root overwritting existing tree blocks

2018-07-05 Thread Gu, Jinxiang
t;> Sent: Thursday, July 05, 2018 3:37 PM > >> To: linux-btrfs@vger.kernel.org > >> Subject: [PATCH 1/4] btrfs-progs: check: Remove the ability to rebuild > >> root overwritting existing tree blocks > >> > >> We have function btrfs_fsck_reini

Re: [PATCH 1/4] btrfs-progs: check: Remove the ability to rebuild root overwritting existing tree blocks

2018-07-05 Thread Qu Wenruo
el.org >> Subject: [PATCH 1/4] btrfs-progs: check: Remove the ability to rebuild root >> overwritting existing tree blocks >> >> We have function btrfs_fsck_reinit_root() to reinit csum or extent tree. > > Nit: > or fs/file tree Nope, btrfs check is o

RE: [PATCH 1/4] btrfs-progs: check: Remove the ability to rebuild root overwritting existing tree blocks

2018-07-05 Thread Gu, Jinxiang
> -Original Message- > From: linux-btrfs-ow...@vger.kernel.org > [mailto:linux-btrfs-ow...@vger.kernel.org] On Behalf Of Qu Wenruo > Sent: Thursday, July 05, 2018 3:37 PM > To: linux-btrfs@vger.kernel.org > Subject: [PATCH 1/4] btrfs-progs: check: Remove the abili

[PATCH 1/4] btrfs-progs: check: Remove the ability to rebuild root overwritting existing tree blocks

2018-07-05 Thread Qu Wenruo
We have function btrfs_fsck_reinit_root() to reinit csum or extent tree. However this function allows us to let it overwrite existing tree blocks using @overwrite parameter. Such behavior is pretty dangerous while no caller is using this feature explicitly. So just remove @overwrite parameter