Re: [PATCH 1/5] Btrfs: fix use-after-free bug during umount

2013-05-27 Thread David Sterba
On Sun, May 26, 2013 at 09:50:27PM +0800, Liu Bo wrote: Commit be283b2e674a09457d4563729015adb637ce7cc1 (Btrfs: use helper to cleanup tree roots) introduced the following bug, Well, it did not introduce the bug, but made it visible. We've free'ed commit_root before actually getting to

Re: [PATCH 1/5] Btrfs: fix use-after-free bug during umount

2013-05-27 Thread Liu Bo
On Mon, May 27, 2013 at 02:07:00PM +0200, David Sterba wrote: On Sun, May 26, 2013 at 09:50:27PM +0800, Liu Bo wrote: Commit be283b2e674a09457d4563729015adb637ce7cc1 (Btrfs: use helper to cleanup tree roots) introduced the following bug, Well, it did not introduce the bug, but made it

[PATCH 1/5] Btrfs: fix use-after-free bug during umount

2013-05-26 Thread Liu Bo
Commit be283b2e674a09457d4563729015adb637ce7cc1 (Btrfs: use helper to cleanup tree roots) introduced the following bug, BUG: unable to handle kernel NULL pointer dereference at 0034 IP: [a039368c] extent_buffer_get+0x4/0xa [btrfs] [...] Pid: 2463, comm: btrfs-cache-1