Re: [PATCH 10/10] Dynamic fault injection

2018-05-18 Thread Andreas Dilger
On May 18, 2018, at 1:10 PM, Kent Overstreet wrote: > > On Fri, May 18, 2018 at 01:05:20PM -0600, Andreas Dilger wrote: >> On May 18, 2018, at 1:49 AM, Kent Overstreet >> wrote: >>> >>> Signed-off-by: Kent Overstreet

Re: [PATCH 10/10] Dynamic fault injection

2018-05-18 Thread Kent Overstreet
On Fri, May 18, 2018 at 01:05:20PM -0600, Andreas Dilger wrote: > On May 18, 2018, at 1:49 AM, Kent Overstreet > wrote: > > > > Signed-off-by: Kent Overstreet > > I agree with Christoph that even if there was some explanation in the cover

Re: [PATCH 10/10] Dynamic fault injection

2018-05-18 Thread Andreas Dilger
On May 18, 2018, at 1:49 AM, Kent Overstreet wrote: > > Signed-off-by: Kent Overstreet I agree with Christoph that even if there was some explanation in the cover letter, there should be something at least as good in the patch itself. The

Re: [PATCH 10/10] Dynamic fault injection

2018-05-18 Thread Kent Overstreet
On Fri, May 18, 2018 at 09:02:45AM -0700, Christoph Hellwig wrote: > On Fri, May 18, 2018 at 03:49:18AM -0400, Kent Overstreet wrote: > > Signed-off-by: Kent Overstreet > > Completely lacks any explanation or argument why it would be useful. It's in the cover

Re: [PATCH 10/10] Dynamic fault injection

2018-05-18 Thread Christoph Hellwig
On Fri, May 18, 2018 at 03:49:18AM -0400, Kent Overstreet wrote: > Signed-off-by: Kent Overstreet Completely lacks any explanation or argument why it would be useful. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to

[PATCH 10/10] Dynamic fault injection

2018-05-18 Thread Kent Overstreet
Signed-off-by: Kent Overstreet --- include/asm-generic/vmlinux.lds.h | 4 + include/linux/dynamic_fault.h | 117 + lib/Kconfig.debug | 5 + lib/Makefile | 2 + lib/dynamic_fault.c | 760