Re: [PATCH 15/26] Btrfs: add a new source file with device replace code

2012-11-12 Thread Stefan Behrens
On Fri, 9 Nov 2012 22:45:16 +0800, Liu Bo wrote: On Fri, Nov 09, 2012 at 11:19:17AM +0100, Stefan Behrens wrote: On Fri, 9 Nov 2012 08:44:01 +0800, Liu Bo wrote: On Thu, Nov 08, 2012 at 06:24:36PM +0100, Stefan Behrens wrote: On Thu, 8 Nov 2012 22:50:47 +0800, Liu Bo wrote: On Tue, Nov 06,

Re: [PATCH 15/26] Btrfs: add a new source file with device replace code

2012-11-09 Thread Stefan Behrens
On Fri, 9 Nov 2012 08:44:01 +0800, Liu Bo wrote: On Thu, Nov 08, 2012 at 06:24:36PM +0100, Stefan Behrens wrote: On Thu, 8 Nov 2012 22:50:47 +0800, Liu Bo wrote: On Tue, Nov 06, 2012 at 05:38:33PM +0100, Stefan Behrens wrote: + trans = btrfs_start_transaction(root, 0); why a

Re: [PATCH 15/26] Btrfs: add a new source file with device replace code

2012-11-09 Thread Liu Bo
On Fri, Nov 09, 2012 at 11:19:17AM +0100, Stefan Behrens wrote: On Fri, 9 Nov 2012 08:44:01 +0800, Liu Bo wrote: On Thu, Nov 08, 2012 at 06:24:36PM +0100, Stefan Behrens wrote: On Thu, 8 Nov 2012 22:50:47 +0800, Liu Bo wrote: On Tue, Nov 06, 2012 at 05:38:33PM +0100, Stefan Behrens wrote:

Re: [PATCH 15/26] Btrfs: add a new source file with device replace code

2012-11-08 Thread Liu Bo
On Tue, Nov 06, 2012 at 05:38:33PM +0100, Stefan Behrens wrote: This adds a new file to the sources together with the header file and the changes to ioctl.h that are required by the new C source file. Signed-off-by: Stefan Behrens sbehr...@giantdisaster.de --- fs/btrfs/dev-replace.c | 843

Re: [PATCH 15/26] Btrfs: add a new source file with device replace code

2012-11-08 Thread Stefan Behrens
On Thu, 8 Nov 2012 22:50:47 +0800, Liu Bo wrote: On Tue, Nov 06, 2012 at 05:38:33PM +0100, Stefan Behrens wrote: +out: +if (path) { +btrfs_release_path(path); +btrfs_free_path(path); btrfs_free_path(path) will do release for you :) Right :) Thanks. +int

Re: [PATCH 15/26] Btrfs: add a new source file with device replace code

2012-11-08 Thread Liu Bo
On Thu, Nov 08, 2012 at 06:24:36PM +0100, Stefan Behrens wrote: On Thu, 8 Nov 2012 22:50:47 +0800, Liu Bo wrote: On Tue, Nov 06, 2012 at 05:38:33PM +0100, Stefan Behrens wrote: [...] + btrfs_dev_replace_unlock(dev_replace); + + btrfs_wait_ordered_extents(root, 0); + + /* force

[PATCH 15/26] Btrfs: add a new source file with device replace code

2012-11-06 Thread Stefan Behrens
This adds a new file to the sources together with the header file and the changes to ioctl.h that are required by the new C source file. Signed-off-by: Stefan Behrens sbehr...@giantdisaster.de --- fs/btrfs/dev-replace.c | 843 +