Re: [PATCH 3/3] Btrfs: make raid6 rebuild retry more

2017-12-06 Thread Liu Bo
On Wed, Dec 06, 2017 at 08:11:30AM +0800, Qu Wenruo wrote: > > > On 2017年12月06日 06:55, Liu Bo wrote: > > On Tue, Dec 05, 2017 at 07:09:25PM +0100, David Sterba wrote: > >> On Tue, Dec 05, 2017 at 04:07:35PM +0800, Qu Wenruo wrote: > @@ -2166,11 +2166,21 @@ int raid56_parity_recover(struct

Re: [PATCH 3/3] Btrfs: make raid6 rebuild retry more

2017-12-05 Thread Qu Wenruo
On 2017年12月06日 06:55, Liu Bo wrote: > On Tue, Dec 05, 2017 at 07:09:25PM +0100, David Sterba wrote: >> On Tue, Dec 05, 2017 at 04:07:35PM +0800, Qu Wenruo wrote: @@ -2166,11 +2166,21 @@ int raid56_parity_recover(struct btrfs_fs_info *fs_info, struct bio *bio, }

Re: [PATCH 3/3] Btrfs: make raid6 rebuild retry more

2017-12-05 Thread Liu Bo
On Tue, Dec 05, 2017 at 07:09:25PM +0100, David Sterba wrote: > On Tue, Dec 05, 2017 at 04:07:35PM +0800, Qu Wenruo wrote: > > > @@ -2166,11 +2166,21 @@ int raid56_parity_recover(struct btrfs_fs_info > > > *fs_info, struct bio *bio, > > > } > > > > > > /* > > > - * reconstruct from the q

Re: [PATCH 3/3] Btrfs: make raid6 rebuild retry more

2017-12-05 Thread David Sterba
On Tue, Dec 05, 2017 at 11:04:03AM -0700, Liu Bo wrote: > On Tue, Dec 05, 2017 at 04:07:35PM +0800, Qu Wenruo wrote: > > > > > > On 2017年12月05日 06:40, Liu Bo wrote: > > > There is a scenario that can end up with rebuild process failing to > > > return good content, i.e. > > > suppose that all

Re: [PATCH 3/3] Btrfs: make raid6 rebuild retry more

2017-12-05 Thread Liu Bo
On Tue, Dec 05, 2017 at 04:07:35PM +0800, Qu Wenruo wrote: > > > On 2017年12月05日 06:40, Liu Bo wrote: > > There is a scenario that can end up with rebuild process failing to > > return good content, i.e. > > suppose that all disks can be read without problems and if the content > > that was read

Re: [PATCH 3/3] Btrfs: make raid6 rebuild retry more

2017-12-05 Thread David Sterba
On Tue, Dec 05, 2017 at 04:07:35PM +0800, Qu Wenruo wrote: > > @@ -2166,11 +2166,21 @@ int raid56_parity_recover(struct btrfs_fs_info > > *fs_info, struct bio *bio, > > } > > > > /* > > -* reconstruct from the q stripe if they are > > -* asking for mirror 3 > > +* Loop

Re: [PATCH 3/3] Btrfs: make raid6 rebuild retry more

2017-12-05 Thread Qu Wenruo
On 2017年12月05日 06:40, Liu Bo wrote: > There is a scenario that can end up with rebuild process failing to > return good content, i.e. > suppose that all disks can be read without problems and if the content > that was read out doesn't match its checksum, currently for raid6 > btrfs at most

Re: [PATCH 3/3] Btrfs: make raid6 rebuild retry more

2017-12-05 Thread Qu Wenruo
On 2017年12月05日 06:40, Liu Bo wrote: > There is a scenario that can end up with rebuild process failing to > return good content, i.e. > suppose that all disks can be read without problems and if the content > that was read out doesn't match its checksum, currently for raid6 > btrfs at most

[PATCH 3/3] Btrfs: make raid6 rebuild retry more

2017-12-04 Thread Liu Bo
There is a scenario that can end up with rebuild process failing to return good content, i.e. suppose that all disks can be read without problems and if the content that was read out doesn't match its checksum, currently for raid6 btrfs at most retries twice, - the 1st retry is to rebuild with