Re: [PATCH V2] btrfs: move leak debug code to functions

2013-04-22 Thread David Sterba
On Mon, Apr 22, 2013 at 12:18:37AM -0500, Eric Sandeen wrote: There was a time when sprinkling #ifdefs around was bad form. We can clean up the code a bit by moving the leak-list adds/removes into functions and make things more readable. Signed-off-by: Eric Sandeen sand...@redhat.com ---

Re: [PATCH V2] btrfs: move leak debug code to functions

2013-04-22 Thread Eric Sandeen
On 4/22/13 10:22 AM, David Sterba wrote: On Mon, Apr 22, 2013 at 12:18:37AM -0500, Eric Sandeen wrote: There was a time when sprinkling #ifdefs around was bad form. We can clean up the code a bit by moving the leak-list adds/removes into functions and make things more readable.

Re: [PATCH V2] btrfs: move leak debug code to functions

2013-04-22 Thread David Sterba
On Mon, Apr 22, 2013 at 10:27:11AM -0500, Eric Sandeen wrote: Yep I noticed that too, I'd be happy to elevate it to a CONFIG_ option if it's really something that will be kept around for a while. We have (and will have) more code for debugging aid. Could maybe be lumped in to a

[PATCH V2] btrfs: move leak debug code to functions

2013-04-21 Thread Eric Sandeen
There was a time when sprinkling #ifdefs around was bad form. We can clean up the code a bit by moving the leak-list adds/removes into functions and make things more readable. Signed-off-by: Eric Sandeen sand...@redhat.com --- V2: remove extra semicolons on no-op #defines, thanks Roger! p.s.