Re: [PATCH v2] xfstests btrfs/020: test device replace on RO btrfs

2013-10-24 Thread David Sterba
On Thu, Oct 24, 2013 at 12:44:43AM +0800, Eryu Guan wrote: +_cleanup() +{ + cd / Using root as temporary directory? + rm -f $tmp.* + $UMOUNT_PROG $loop_mnt + _destroy_loop_device $loop_dev1 + losetup -d $loop_dev2 /dev/null 21 + _destroy_loop_device $loop_dev3 +

[PATCH v2] xfstests btrfs/020: test device replace on RO btrfs

2013-10-23 Thread Eryu Guan
btrfs replace on readonly fs should not be allowed. Regression test case for commit: bbb651e Btrfs: don't allow the replace procedure on read only filesystems Signed-off-by: Eryu Guan eg...@redhat.com --- v2: Address Eric's review - use truncate to create fs image instead of writing to each

Re: [PATCH v2] xfstests btrfs/020: test device replace on RO btrfs

2013-10-23 Thread Stefan Behrens
On Thu, 24 Oct 2013 00:44:43 +0800, Eryu Guan wrote: btrfs replace on readonly fs should not be allowed. Regression test case for commit: bbb651e Btrfs: don't allow the replace procedure on read only filesystems Signed-off-by: Eryu Guan eg...@redhat.com --- v2: Address Eric's review -

Re: [PATCH v2] xfstests btrfs/020: test device replace on RO btrfs

2013-10-23 Thread Eric Sandeen
On 10/23/13 12:05 PM, Stefan Behrens wrote: On Thu, 24 Oct 2013 00:44:43 +0800, Eryu Guan wrote: btrfs replace on readonly fs should not be allowed. Regression test case for commit: bbb651e Btrfs: don't allow the replace procedure on read only filesystems Signed-off-by: Eryu Guan

Re: [PATCH v2] xfstests btrfs/020: test device replace on RO btrfs

2013-10-23 Thread Eric Sandeen
On 10/23/13 11:44 AM, Eryu Guan wrote: btrfs replace on readonly fs should not be allowed. Regression test case for commit: bbb651e Btrfs: don't allow the replace procedure on read only filesystems Signed-off-by: Eryu Guan eg...@redhat.com Reviewed-by: Eric Sandeen sand...@redhat.com

Re: [PATCH v2] xfstests btrfs/020: test device replace on RO btrfs

2013-10-23 Thread Dave Chinner
On Wed, Oct 23, 2013 at 12:45:07PM -0500, Eric Sandeen wrote: On 10/23/13 12:05 PM, Stefan Behrens wrote: On Thu, 24 Oct 2013 00:44:43 +0800, Eryu Guan wrote: +# real QA test starts here +_supported_fs btrfs +_supported_os Linux It is still unclear to me why everybody adds this