Re: [PATCH v2 2/2] btrfs-progs: use kernel for mounted and lblkid to scan disks

2013-09-13 Thread Anand Jain
Thanks for implementing it! I found a few things to fix, comments below. I wonder if we should keep --all-devices as a last resort fallback eg. Any idea whats the real use of --all-devices option anyway I am unsure. Anyway will restore --all-devices so now. all other suggestion were

Re: [PATCH v2 2/2] btrfs-progs: use kernel for mounted and lblkid to scan disks

2013-09-13 Thread David Sterba
On Fri, Sep 13, 2013 at 06:49:10PM +0800, Anand Jain wrote: I wonder if we should keep --all-devices as a last resort fallback eg. Any idea whats the real use of --all-devices option anyway I am unsure. Anyway will restore --all-devices so now. That's when udev breaks or is not present on

Re: [PATCH v2 2/2] btrfs-progs: use kernel for mounted and lblkid to scan disks

2013-09-13 Thread David Sterba
On Fri, Sep 13, 2013 at 05:56:46PM +0200, David Sterba wrote: Reproduced with today's linus tree (btrfs pull is there), progs contain the patches in question: Reproduces with the updated patches you sent today. -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body

Re: [PATCH v2 2/2] btrfs-progs: use kernel for mounted and lblkid to scan disks

2013-09-12 Thread David Sterba
On Fri, Sep 06, 2013 at 05:37:53PM +0800, Anand Jain wrote: Further, to scan for the disks this patch will use lblkid, so that we don't have to manually scan the /dev or /dev/mapper which means we don't need the all-devices options. Thanks for implementing it! I found a few things to fix,

[PATCH v2 2/2] btrfs-progs: use kernel for mounted and lblkid to scan disks

2013-09-06 Thread Anand Jain
As of now btrfs filesystem show reads directly from disks. So sometimes output can be stale, mainly when user want to verify their last operation like, labeling or device delete or add... etc. so this patch will read from the kernel ioctl if it finds that disk is mounted. Further, to scan for the