>Messaggio originale
>Da: l...@cn.fujitsu.com
>Data: 10/12/2010 8.12
>A:
>Cc:
>Ogg: Re: [PATCH v2 5/5] Btrfs: Add BTRFS_IOC_SUBVOL_GETFLAGS/SETFLAGS ioctl
>
>Goffredo Baroncelli wrote:
>> Hi Li,
>>
>> On Thursday, 09 December, 2010, Li Zefan w
On Fri, Dec 10, 2010 at 03:12:41PM +0800, Li Zefan wrote:
> >> + /* nothing to do */
> >> + if (!!(flags & BTRFS_SUBVOL_RDONLY) == root->readonly)
> >> + goto out_unlock;
> >
> > This is only an aesthetic comment: I prefer a simpler style like
> >
> > if ((flags & BTRFS_SUBVOL_RDON
Goffredo Baroncelli wrote:
> Hi Li,
>
> On Thursday, 09 December, 2010, Li Zefan wrote:
>> This allows us to set a snapshot or a subvolume readonly or writable
>> on the fly.
>>
>> Usage:
>>
>> Set BTRFS_SUBVOL_RDONLY of btrfs_ioctl_vol_arg_v2->flags, and then
>> call ioctl(BTRFS_IOCTL_SUBVOL_SETF
Hi Li,
On Thursday, 09 December, 2010, Li Zefan wrote:
> This allows us to set a snapshot or a subvolume readonly or writable
> on the fly.
>
> Usage:
>
> Set BTRFS_SUBVOL_RDONLY of btrfs_ioctl_vol_arg_v2->flags, and then
> call ioctl(BTRFS_IOCTL_SUBVOL_SETFLAGS);
>
> Changelog for v2:
> - Add
This allows us to set a snapshot or a subvolume readonly or writable
on the fly.
Usage:
Set BTRFS_SUBVOL_RDONLY of btrfs_ioctl_vol_arg_v2->flags, and then
call ioctl(BTRFS_IOCTL_SUBVOL_SETFLAGS);
Changelog for v2:
- Add _GETFLAGS ioctl.
- Check if the passed fd is the root of a subvolume.
- Chan
