Re: [PATCH v2 5/9] generic/102 open code dev_size _scratch_mkfs_sized()

2018-10-07 Thread Eryu Guan
On Wed, Sep 26, 2018 at 12:08:56PM +0800, Anand Jain wrote: > > > On 09/25/2018 06:54 PM, Nikolay Borisov wrote: > > > > > > On 25.09.2018 07:24, Anand Jain wrote: > > > Open code helps to grep and find out parameter sent to the > > > _scratch_mkfs_sized here. > > > > > > Signed-off-by: Anand

Re: [PATCH v2 5/9] generic/102 open code dev_size _scratch_mkfs_sized()

2018-09-25 Thread Anand Jain
On 09/25/2018 06:54 PM, Nikolay Borisov wrote: On 25.09.2018 07:24, Anand Jain wrote: Open code helps to grep and find out parameter sent to the _scratch_mkfs_sized here. Signed-off-by: Anand Jain IMO this is noise, you can just as simply do "grep _scratch_mkfs_sized" and then open the

Re: [PATCH v2 5/9] generic/102 open code dev_size _scratch_mkfs_sized()

2018-09-25 Thread Nikolay Borisov
On 25.09.2018 07:24, Anand Jain wrote: > Open code helps to grep and find out parameter sent to the > _scratch_mkfs_sized here. > > Signed-off-by: Anand Jain IMO this is noise, you can just as simply do "grep _scratch_mkfs_sized" and then open the file to inspect the actual argument. But

[PATCH v2 5/9] generic/102 open code dev_size _scratch_mkfs_sized()

2018-09-24 Thread Anand Jain
Open code helps to grep and find out parameter sent to the _scratch_mkfs_sized here. Signed-off-by: Anand Jain --- tests/generic/102 | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tests/generic/102 b/tests/generic/102 index faf940ac5070..aad496a5bc69 100755 ---