Re: [PATCH v3 3/3] btrfs: quasi-round-robin for chunk allocation

2011-05-13 Thread David Sterba
Hi, here are my comments, after first review round, mostly on code itself, not the functionality/quality of the allocator (although after this patch the allocator code looks quite straightforward a better to read and understand). Reviewing the patch directly does not work, Arne's advice was to

[PATCH v3 3/3] btrfs: quasi-round-robin for chunk allocation

2011-05-02 Thread Arne Jansen
In a multi device setup, the chunk allocator currently always allocates chunks on the devices in the same order. This leads to a very uneven distribution, especially with RAID1 or RAID10 and an uneven number of devices. This patch always sorts the devices before allocating, and allocates the