Re: [PATCH v3 4/7] btrfs-progs: lowmem: search key of root again after check_fs_root() after repair

2018-09-17 Thread Nikolay Borisov
On 17.09.2018 15:51, Qu Wenruo wrote: > > > On 2018/9/17 下午3:28, Su Yue wrote: >> In check_fs_roots_lowmem(), we do search and follow the resulted path >> to call check_fs_root(), then call btrfs_next_item() to check next >> root. >> However, if repair is enabled, the root tree can be cowed,

Re: [PATCH v3 4/7] btrfs-progs: lowmem: search key of root again after check_fs_root() after repair

2018-09-17 Thread Qu Wenruo
On 2018/9/17 下午8:55, Su Yue wrote: > > > On 2018/9/17 8:51 PM, Qu Wenruo wrote: >> >> >> On 2018/9/17 下午3:28, Su Yue wrote: >>> In check_fs_roots_lowmem(), we do search and follow the resulted path >>> to call check_fs_root(), then call btrfs_next_item() to check next >>> root. >>> However,

Re: [PATCH v3 4/7] btrfs-progs: lowmem: search key of root again after check_fs_root() after repair

2018-09-17 Thread Su Yue
On 2018/9/17 8:51 PM, Qu Wenruo wrote: On 2018/9/17 下午3:28, Su Yue wrote: In check_fs_roots_lowmem(), we do search and follow the resulted path to call check_fs_root(), then call btrfs_next_item() to check next root. However, if repair is enabled, the root tree can be cowed, the existed

Re: [PATCH v3 4/7] btrfs-progs: lowmem: search key of root again after check_fs_root() after repair

2018-09-17 Thread Qu Wenruo
On 2018/9/17 下午3:28, Su Yue wrote: > In check_fs_roots_lowmem(), we do search and follow the resulted path > to call check_fs_root(), then call btrfs_next_item() to check next > root. > However, if repair is enabled, the root tree can be cowed, the > existed path can cause strange errors. > >

[PATCH v3 4/7] btrfs-progs: lowmem: search key of root again after check_fs_root() after repair

2018-09-17 Thread Su Yue
In check_fs_roots_lowmem(), we do search and follow the resulted path to call check_fs_root(), then call btrfs_next_item() to check next root. However, if repair is enabled, the root tree can be cowed, the existed path can cause strange errors. Solution: If repair, save the key before calling