Re: [PATCH v3 5/7] btrfs-progs: lowmem: do missing check of last item after check_inode_item()

2018-09-18 Thread Qu Wenruo
On 2018/9/18 下午4:01, Su Yue wrote: > > > On 9/18/18 1:32 PM, Qu Wenruo wrote: >> >> >> On 2018/9/17 下午9:24, Su Yue wrote: >>> >>> >>> On 2018/9/17 8:53 PM, Qu Wenruo wrote: On 2018/9/17 下午3:28, Su Yue wrote: > After call of check_inode_item(), path may point to the last

Re: [PATCH v3 5/7] btrfs-progs: lowmem: do missing check of last item after check_inode_item()

2018-09-18 Thread Su Yue
On 9/18/18 1:32 PM, Qu Wenruo wrote: On 2018/9/17 下午9:24, Su Yue wrote: On 2018/9/17 8:53 PM, Qu Wenruo wrote: On 2018/9/17 下午3:28, Su Yue wrote: After call of check_inode_item(), path may point to the last unchecked slot of the leaf. The outer walk_up_tree() always treats the

Re: [PATCH v3 5/7] btrfs-progs: lowmem: do missing check of last item after check_inode_item()

2018-09-17 Thread Qu Wenruo
On 2018/9/17 下午9:24, Su Yue wrote: > > > On 2018/9/17 8:53 PM, Qu Wenruo wrote: >> >> >> On 2018/9/17 下午3:28, Su Yue wrote: >>> After call of check_inode_item(), path may point to the last unchecked >>> slot of the leaf. The outer walk_up_tree() always treats the position >>> as checked slot

Re: [PATCH v3 5/7] btrfs-progs: lowmem: do missing check of last item after check_inode_item()

2018-09-17 Thread Su Yue
On 2018/9/17 8:53 PM, Qu Wenruo wrote: On 2018/9/17 下午3:28, Su Yue wrote: After call of check_inode_item(), path may point to the last unchecked slot of the leaf. The outer walk_up_tree() always treats the position as checked slot then skips to the next. The last item will never be

Re: [PATCH v3 5/7] btrfs-progs: lowmem: do missing check of last item after check_inode_item()

2018-09-17 Thread Qu Wenruo
On 2018/9/17 下午3:28, Su Yue wrote: > After call of check_inode_item(), path may point to the last unchecked > slot of the leaf. The outer walk_up_tree() always treats the position > as checked slot then skips to the next. The last item will never be > checked. > > While checking backrefs, path

[PATCH v3 5/7] btrfs-progs: lowmem: do missing check of last item after check_inode_item()

2018-09-17 Thread Su Yue
After call of check_inode_item(), path may point to the last unchecked slot of the leaf. The outer walk_up_tree() always treats the position as checked slot then skips to the next. The last item will never be checked. While checking backrefs, path passed to walk_up_tree() always points to a