Re: [PATCH v6 5/4] copy_file_range.2: New page documenting copy_file_range()

2015-10-19 Thread Christoph Hellwig
On Mon, Oct 19, 2015 at 04:45:03PM -0400, J. Bruce Fields wrote: > So, continue to include a "flags" field but just error out if it's > anything but zero for now? Exactly! -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.or

Re: [PATCH v6 5/4] copy_file_range.2: New page documenting copy_file_range()

2015-10-19 Thread J. Bruce Fields
On Sun, Oct 18, 2015 at 11:30:13AM -0700, Christoph Hellwig wrote: > Just commenting on the man page here as the comment is about sematics. > All the infrastructure in the patch looks reasonable to me, but this > is something we need to get right. > > > +.B COPY_FR_REFLINK > > +Create a lightweigh

Re: [PATCH v6 5/4] copy_file_range.2: New page documenting copy_file_range()

2015-10-18 Thread Christoph Hellwig
Just commenting on the man page here as the comment is about sematics. All the infrastructure in the patch looks reasonable to me, but this is something we need to get right. > +.B COPY_FR_REFLINK > +Create a lightweight "reflink", where data is not copied until > +one of the files is modified. >

Re: [PATCH v6 5/4] copy_file_range.2: New page documenting copy_file_range()

2015-10-16 Thread Pádraig Brady
It's probably worth mentioning the sparse expansion caveat in the docs, as it's important and not obvious. I.E. copy_file_range() could be called from, but would still benefit from a user space app using a SEEK_{HOLE,DATA} loop. thanks, Pádraig. -- To unsubscribe from this list: send the line "un

Re: [PATCH v6 5/4] copy_file_range.2: New page documenting copy_file_range()

2015-10-16 Thread Andreas Dilger
> On Oct 16, 2015, at 3:08 PM, Anna Schumaker wrote: > > copy_file_range() is a new system call for copying ranges of data > completely in the kernel. This gives filesystems an opportunity to > implement some kind of "copy acceleration", such as reflinks or > server-side-copy (in the case of NF

[PATCH v6 5/4] copy_file_range.2: New page documenting copy_file_range()

2015-10-16 Thread Anna Schumaker
copy_file_range() is a new system call for copying ranges of data completely in the kernel. This gives filesystems an opportunity to implement some kind of "copy acceleration", such as reflinks or server-side-copy (in the case of NFS). Signed-off-by: Anna Schumaker Reviewed-by: Darrick J. Wong