Re: [PATCH v8 2/2] btrfs: check device for critical errors and mark failed

2017-10-15 Thread Anand Jain
On 10/14/2017 02:46 AM, Liu Bo wrote: On Sun, Oct 08, 2017 at 10:23:58PM +0800, Anand Jain wrote: On 10/07/2017 07:56 AM, Liu Bo wrote: On Thu, Oct 05, 2017 at 09:56:59PM +0800, Anand Jain wrote: On 10/05/2017 04:11 AM, Liu Bo wrote: On Tue, Oct 03, 2017 at 11:59:20PM +0800, Anand Jain

Re: [PATCH v8 2/2] btrfs: check device for critical errors and mark failed

2017-10-13 Thread Liu Bo
On Sun, Oct 08, 2017 at 10:23:58PM +0800, Anand Jain wrote: > > > On 10/07/2017 07:56 AM, Liu Bo wrote: > > On Thu, Oct 05, 2017 at 09:56:59PM +0800, Anand Jain wrote: > > > > > > > > > On 10/05/2017 04:11 AM, Liu Bo wrote: > > > > On Tue, Oct 03, 2017 at 11:59:20PM +0800, Anand Jain wrote: > >

Re: [PATCH v8 2/2] btrfs: check device for critical errors and mark failed

2017-10-09 Thread Austin S. Hemmelgarn
On 2017-10-06 19:33, Liu Bo wrote: On Thu, Oct 05, 2017 at 07:07:44AM -0400, Austin S. Hemmelgarn wrote: On 2017-10-04 16:11, Liu Bo wrote: On Tue, Oct 03, 2017 at 11:59:20PM +0800, Anand Jain wrote: From: Anand Jain Write and flush errors are critical errors, upon which the device fd must b

Re: [PATCH v8 2/2] btrfs: check device for critical errors and mark failed

2017-10-08 Thread Anand Jain
On 10/07/2017 07:56 AM, Liu Bo wrote: On Thu, Oct 05, 2017 at 09:56:59PM +0800, Anand Jain wrote: On 10/05/2017 04:11 AM, Liu Bo wrote: On Tue, Oct 03, 2017 at 11:59:20PM +0800, Anand Jain wrote: From: Anand Jain Write and flush errors are critical errors, upon which the device fd must b

Re: [PATCH v8 2/2] btrfs: check device for critical errors and mark failed

2017-10-06 Thread Liu Bo
On Thu, Oct 05, 2017 at 09:56:59PM +0800, Anand Jain wrote: > > > On 10/05/2017 04:11 AM, Liu Bo wrote: > > On Tue, Oct 03, 2017 at 11:59:20PM +0800, Anand Jain wrote: > > > From: Anand Jain > > > > > > Write and flush errors are critical errors, upon which the device fd > > > must be closed an

Re: [PATCH v8 2/2] btrfs: check device for critical errors and mark failed

2017-10-06 Thread Liu Bo
On Thu, Oct 05, 2017 at 07:07:44AM -0400, Austin S. Hemmelgarn wrote: > On 2017-10-04 16:11, Liu Bo wrote: > > On Tue, Oct 03, 2017 at 11:59:20PM +0800, Anand Jain wrote: > > > From: Anand Jain > > > > > > Write and flush errors are critical errors, upon which the device fd > > > must be closed a

Re: [PATCH v8 2/2] btrfs: check device for critical errors and mark failed

2017-10-05 Thread Anand Jain
On 10/05/2017 04:11 AM, Liu Bo wrote: On Tue, Oct 03, 2017 at 11:59:20PM +0800, Anand Jain wrote: From: Anand Jain Write and flush errors are critical errors, upon which the device fd must be closed and marked as failed. Can we defer the job of closing device to umount? Originally I th

Re: [PATCH v8 2/2] btrfs: check device for critical errors and mark failed

2017-10-05 Thread Austin S. Hemmelgarn
On 2017-10-04 16:11, Liu Bo wrote: On Tue, Oct 03, 2017 at 11:59:20PM +0800, Anand Jain wrote: From: Anand Jain Write and flush errors are critical errors, upon which the device fd must be closed and marked as failed. Can we defer the job of closing device to umount? We can go mark the dev

Re: [PATCH v8 2/2] btrfs: check device for critical errors and mark failed

2017-10-04 Thread Liu Bo
On Tue, Oct 03, 2017 at 11:59:20PM +0800, Anand Jain wrote: > From: Anand Jain > > Write and flush errors are critical errors, upon which the device fd > must be closed and marked as failed. > Can we defer the job of closing device to umount? We can go mark the device failed and skip it while d

[PATCH v8 2/2] btrfs: check device for critical errors and mark failed

2017-10-03 Thread Anand Jain
From: Anand Jain Write and flush errors are critical errors, upon which the device fd must be closed and marked as failed. There are two type of device close in btrfs, one, close as part of clean up where we shall release the struct btrfs_device and or btrfs_fs_devices as well. And the other typ