Re: [RFC PATCH 0/4] Add readonly support to replace BUG_ON phrase

2010-11-29 Thread liubo
On 11/30/2010 10:30 AM, Josef Bacik wrote: > On Tue, Nov 30, 2010 at 10:03:58AM +0800, liubo wrote: >> On 11/30/2010 04:10 AM, Josef Bacik wrote: >>> On Thu, Nov 25, 2010 at 05:52:47PM +0800, Miao Xie wrote: Btrfs has a number of BUG_ON()s, which may lead btrfs to unpleasant panic. Meanwh

Re: [RFC PATCH 0/4] Add readonly support to replace BUG_ON phrase

2010-11-29 Thread Josef Bacik
On Tue, Nov 30, 2010 at 10:03:58AM +0800, liubo wrote: > On 11/30/2010 04:10 AM, Josef Bacik wrote: > > On Thu, Nov 25, 2010 at 05:52:47PM +0800, Miao Xie wrote: > >> Btrfs has a number of BUG_ON()s, which may lead btrfs to unpleasant panic. > >> Meanwhile, they are very ugly and should be handled

Re: [RFC PATCH 0/4] Add readonly support to replace BUG_ON phrase

2010-11-29 Thread liubo
On 11/30/2010 04:10 AM, Josef Bacik wrote: > On Thu, Nov 25, 2010 at 05:52:47PM +0800, Miao Xie wrote: >> Btrfs has a number of BUG_ON()s, which may lead btrfs to unpleasant panic. >> Meanwhile, they are very ugly and should be handled more propriately. >> >> There are mainly two ways to deal with

Re: [RFC PATCH 0/4] Add readonly support to replace BUG_ON phrase

2010-11-29 Thread Josef Bacik
On Mon, Nov 29, 2010 at 01:12:17PM -0800, Mike Fedyk wrote: > On Mon, Nov 29, 2010 at 12:10 PM, Josef Bacik wrote: > > On Thu, Nov 25, 2010 at 05:52:47PM +0800, Miao Xie wrote: > >> Btrfs has a number of BUG_ON()s, which may lead btrfs to unpleasant panic. > >> Meanwhile, they are very ugly and sh

Re: [RFC PATCH 0/4] Add readonly support to replace BUG_ON phrase

2010-11-29 Thread Mike Fedyk
On Mon, Nov 29, 2010 at 12:10 PM, Josef Bacik wrote: > On Thu, Nov 25, 2010 at 05:52:47PM +0800, Miao Xie wrote: >> Btrfs has a number of BUG_ON()s, which may lead btrfs to unpleasant panic. >> Meanwhile, they are very ugly and should be handled more propriately. >> >> There are mainly two ways to

Re: [RFC PATCH 0/4] Add readonly support to replace BUG_ON phrase

2010-11-29 Thread Josef Bacik
On Thu, Nov 25, 2010 at 05:52:47PM +0800, Miao Xie wrote: > Btrfs has a number of BUG_ON()s, which may lead btrfs to unpleasant panic. > Meanwhile, they are very ugly and should be handled more propriately. > > There are mainly two ways to deal with these BUG_ON()s. > > 1. For those errors which

Re: [RFC PATCH 0/4] Add readonly support to replace BUG_ON phrase

2010-11-25 Thread Wenyi Liu
2010/11/25, Miao Xie : > Btrfs has a number of BUG_ON()s, which may lead btrfs to unpleasant panic. > Meanwhile, they are very ugly and should be handled more propriately. > > There are mainly two ways to deal with these BUG_ON()s. Yes, I agree. > > 1. For those errors which can be handled well by

[RFC PATCH 0/4] Add readonly support to replace BUG_ON phrase

2010-11-25 Thread Miao Xie
Btrfs has a number of BUG_ON()s, which may lead btrfs to unpleasant panic. Meanwhile, they are very ugly and should be handled more propriately. There are mainly two ways to deal with these BUG_ON()s. 1. For those errors which can be handled well by callers, we just return their error number to c